Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow smaller (16x16 pixels) icon size #210

Closed
eugenesvk opened this issue Jul 6, 2017 · 9 comments
Closed

Allow smaller (16x16 pixels) icon size #210

eugenesvk opened this issue Jul 6, 2017 · 9 comments

Comments

@eugenesvk
Copy link

@eugenesvk eugenesvk commented Jul 6, 2017

Due to Windows scaling on my PC the miminum icon size your app offers (32x32) is too big and overlaps the search string (unless replaced by another icon, appropriate for the found item). Could you please also add an option to allow showing the smaller icon size (16x16) to avoid this?
Thsnk

#satellite_pos = topleft

# Size of the satellite icon
# * Accepted values:
#   * small: icon size is 32x32 pixels
#            if position is 'topleft', icon is small enough to be embedded in
#            the LaunchBox
#   * large: icon size is 64x64 pixels
#   * jumbo: icon size is 128x128 pixels, may look ugly for some items
# * The sizes in pixels given above are relative to a resolution of 96dpi (100%
#   scaling). Keypirinha is DPI-aware and will take care of scaling its GUI
#   according to the DPI resolution of each monitor
#satellite_size = jumbo

Update: Note the no in the "nothing found", the K icon is a bit too wide

keypirinha

And here is a proper icon that fits perfectly when it's not scaled along with the desktop DPI scaling
keypirinha2

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Jul 8, 2017

Just in case I would need it, would you mind sharing a screenshot of the issue please?

@eugenesvk
Copy link
Author

@eugenesvk eugenesvk commented Jul 10, 2017

Added a screenshot

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Jul 15, 2017

Thanks for the screenshots. I will correct the behavior of the small option to ensure the icon remains embedded in the LaunchBox regardless of the current DPI (it should already, like it's the case for other GUI elements).

The small icon option is only advertised to be 32x32 for the sake of documenting it, but the purpose of this option is actually to have the icon "embedded" in the LaunchBox.

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Jul 17, 2017

@eugenesvk your message is a bit confusing to me. Does this issue implies that, always in Hi-DPI, some icons are scaled properly and some are not? Or does it mean it always occurs in Hi-DPI?

@eugenesvk
Copy link
Author

@eugenesvk eugenesvk commented Jul 18, 2017

@polyvertex I've just checked Windows without scaling (e.g. at 100%) and all icons fit properly, but at any scaling above 100% other icons are larger, but still fit, while the K icon doesn't fit. So it seems to be an issue with the K icon only, which is scaled "faster" than other icons and thus exceeds the limits
Hope that clarifies it, though I'm not sure I understand the distinction you're making between "always in Hi-DPI" and "always occurs in HiDPI"

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Jul 19, 2017

@eugenesvk yes sorry, my question was unclear. The distinction to make between the two was some icons are scaled properly and some are not. I asked because your screenshots seemed to reveal that only the K icon was implied by this scaling issue, which seems to be the case according to your last comment. Thanks! I will investigate.

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Jul 19, 2017

Should be fixed in 2.15.2.
Do not hesitate to comment if issue persists.

@polyvertex polyvertex closed this Jul 19, 2017
@polyvertex
Copy link
Member

@polyvertex polyvertex commented Sep 13, 2018

It seems issue persists as of v2.18.2. Reopening this...

@polyvertex polyvertex reopened this Sep 13, 2018
@polyvertex
Copy link
Member

@polyvertex polyvertex commented Sep 13, 2018

Second fix attempt in v2.19

@polyvertex polyvertex closed this Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.