Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing get stuck sometimes during populating #216

Closed
Andreasvb opened this issue Jul 18, 2017 · 7 comments
Closed

Typing get stuck sometimes during populating #216

Andreasvb opened this issue Jul 18, 2017 · 7 comments

Comments

@Andreasvb
Copy link

@Andreasvb Andreasvb commented Jul 18, 2017

Sometimes when you type it gets stuck until it populates the list, maybe finishing reading icons, not sure.
When it's stuck it'll not update the typing until it's done, which can take some seconds at worst.

I understand it'll need to read from the disk and load all icons, but maybe if it could do that in another thread or similar so the typing won't be affected and whole program freezes. :)

I have 2 524 items in the catalog.

apps.ini

scan_start_menu = yes
scan_env_path = no
extra_paths =
C:\Windows
D:\Portable\Apps**.bat
D:\Portable\Apps*
*.exe
D:\Portable\Apps**.lnk
D:\Mp3- CHIP -\f
*.bat
D:\Mp3- CHIP -\f**.exe
D:\Mp3- CHIP -\f**.lnk
D:\Mp3- CHIP -\XMPlay*.exe
D:\Mp3- CHIP -\ZXTune*.exe
D:-= Games =-\Steam\

Windows 10 Pro x64 (15063) // Keypirinha 2.15.1

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Jul 18, 2017

At first glance I have only a tiny clue, however I can say for sure that your assumption is incorrect because icons are read and loaded in an asynchronous fashion by a different thread. Definitely not the bottleneck here.

  1. What is the type of your D: drive? (HDD, SSD, network, ...)
  2. I assume the last line D:-= Games =-\Steam\ has a typo?
  3. Did you install additional packages?
  4. Would you mind sharing the full content of your Keypirinha.ini file(s) so I can perform some tests in similar conditions?
@Andreasvb
Copy link
Author

@Andreasvb Andreasvb commented Jul 18, 2017

Yes, it's probably something else than icons, just that's what I see loading when it freezes (it load dynamically, it's only the typing that's frozen).

C: is an SSD.
D: is a HDD.

The formatting removes some backslashes. 😄

I've attached both files.
Keypirinha.ini.txt
apps.ini.txt

Thanks.

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Jul 18, 2017

It's very probably due to the check made to filter out the matching FILE history items that do not exist at search time.

The best workaround to this would be to add an exclude_nonexistent_local_files setting (same than the existing exclude_nonexistent_remote_files one, but for local files), so users with slower drives do not get affected by the filter-out process, but they would get non-existent files in the results list though.

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Jul 19, 2017

exclude_nonexistent_local_files setting added in 2.15.2.
Do not hesitate to comment if the issue persists.

@polyvertex polyvertex closed this Jul 19, 2017
@Andreasvb
Copy link
Author

@Andreasvb Andreasvb commented Jul 19, 2017

I added the option but not sure if it helped.

I'm typing at about same pace each time, can happen regardless if it's same sequence, like kkkkkkkk.
I've recorded a little gif demonstrating: http://i.imgur.com/iWHUOlW.gif


Edit: oh, was that not an implemented option?, read your comment now.
I'll try new version.
Also, think I misinterpreted it, it should be "no" so it doesn't check, I'll change and try.

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Jul 19, 2017

Yes, both settings are explained in the inline doc.
Try with the following config for your tests:

[app]
exclude_nonexistent_local_files = no
exclude_nonexistent_remote_files = no

Bear in mind that there may be some external application that interfere as well. Typically, an antivirus that locks the read-access to a file during its analysis, in which case KP has to wait for the file to be unlocked.

@Andreasvb
Copy link
Author

@Andreasvb Andreasvb commented Jul 19, 2017

Ok, maybe is Windows Defender that's locking then. Maybe can try disable it and see if anything changes .
Thanks so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.