Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When scrolling it jumps to the top #229

Closed
guruas3 opened this issue Aug 19, 2017 · 13 comments
Closed

When scrolling it jumps to the top #229

guruas3 opened this issue Aug 19, 2017 · 13 comments
Labels

Comments

@guruas3
Copy link

@guruas3 guruas3 commented Aug 19, 2017

The issue is pretty simple when i scroll the list with my keyboard down key or with my mouse after some delay it jumps to the top of the list.

I tried reinstalling the app and it didn't help. On my other pc this issue doesn't occur.
If it's weird behavior i don't know how to reproduce it on your side.

There is no errors in the console so i will just copy the first 5 lines:

17:32:10.782 Keypirinha 2.15.3 (b4ca020) for x64
17:32:10.782 System: WinNT-x64 6.1.7601-ws-0x0100 SP1.0
17:32:10.782 Portable mode
17:32:10.782 Keyboard layout: 00000409
17:32:10.783 Monitor #1: Name[\\.\DISPLAY1] Rect[0, 0, 2560, 1440] DpiScale[1.00] PRIMARY```
@polyvertex
Copy link
Member

@polyvertex polyvertex commented Aug 19, 2017

Thanks for reporting this.

  1. For one given search term, does the issue keeps repeating or does it jump only once for all (at least until your search term changes)
  2. Does the GUI hang before your selection jumps to the top (i.e. can you keep scrolling until it jumps)?
  3. Do you have HDD and/or mounted network drives on the machine where this issue occurs? If yes, is the HDD "old" or maybe almost full, anything that could make it exceptionally slow compared to "normal" expected behavior?

This "jump to top" behavior you observe is probably because the list of results changed after the delay you mentioned so KP updates the GUI with the new list of results, forcing your selection to be reset to the top because items' matching scores changed. So our goal here is to understand why the results list takes so long on this very machine to be updated.

@guruas3
Copy link
Author

@guruas3 guruas3 commented Aug 19, 2017

  1. It keeps repeating
  2. No, it runs very smoothly no freezes at all.
  3. I'm on SSD with powerful configuration.

I just noticed that it occurs even if i go down by 1 item( so no scroll at all). So i go down by 1 or more items and it jumps back to top after some delay.
Maybe it's something weird on my part as you haven't seen this before.

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Aug 19, 2017

It keeps repeating

Just to clarify, it keeps repeating even if you don't type another letter in the search box? What's the delay approximately? Does the frequency seem constant?

Maybe it's something weird on my part as you haven't seen this before.

You are the first to report such an issue indeed. At least the way you worded it. And so far I'm not sure how to investigate on this one since you say there is no warning/error message in the console and there's nothing special about KP's behavior except the symptoms you mentioned... Are you positive about your KP install being completely vanilla? I.e.: KP is just unzipped to a new empty directory, in portable mode, with no config and no extra package?

@guruas3
Copy link
Author

@guruas3 guruas3 commented Aug 19, 2017

Exactly it keeps repeating even if i don't type more symbols. Just repeatedly going down on the same search term over and over again. The delay is from 3-8 seconds from the point when i start going down with the selection.

Downloaded again fresh portable KP, restarted my pc, uninstalled other launchers.

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Aug 19, 2017

There are some events that may indirectly trigger this update of the results list. Here are some from the top of my head that may help to narrow down the list of potential culprits:

  • Environment variable updated (even if no value has actually changed, there are some software that broadcast a notification)
  • The content of the Start Menu and/or your Desktop has changed (same remarks than above, even if the Start Menu items don't seem to have changed, some software may have removed-then-recreated one of them for example, which is enough for the OS to send some "changed" notifications)
  • A device has been connected/disconnected. I.e. network/usb device (un)mounted
  • Your system network options have changed (same remark than above about notifications without real changes)
@polyvertex
Copy link
Member

@polyvertex polyvertex commented Aug 30, 2017

@guruas3 have you got the chance to investigate further considering the list of potential triggers I mentioned before?

@guruas3
Copy link
Author

@guruas3 guruas3 commented Aug 30, 2017

well i haven't found the cause yet but it's definitely not the latest 2 points. it's hard to track which software sends these "changed" notifications

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Aug 30, 2017

Admittedly it is cumbersome to shutdown all the running programs on your machine (foreground and background), then re-enable them one by one, but it seems to be the only reliable test.

@gondarr
Copy link

@gondarr gondarr commented Aug 30, 2017

I had the exact same issue, I guess the software sending the "changed" notifications is Keypirinha itself, notice how it's Tray System symbol turns green every time it happens.

I believe @guruas3 has Keypirinha laying around on his Desktop or some Desktop subfolder, same as me. Change it to Program Files or anything outside Desktop, it fixed it for me.

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Aug 30, 2017

... notice how it's Tray System symbol turns green every time it happens

The icon is expected to turn green in this case, to indicate that the Catalog is being refreshed: it is the consequence of the issue! You are perfectly right in your diagnosis though: if KP is installed in one of the monitored folders (for now: the Desktop folders and the Start Menu folders), it creates a loop of events. KP doesn't perform that safety check. Good catch! Is it the reason of this issue for you as well @guruas3?

@guruas3
Copy link
Author

@guruas3 guruas3 commented Aug 30, 2017

@polyvertex yes that was the problem. thank you it solved the issue.

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Aug 30, 2017

Well, thanks both for your feedback! I'll improve the documentation by adding a warning about that.

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Oct 27, 2017

FYI, in the next release (after v2.16.3), Keypirinha will not start monitoring the Desktop or the Start Menu if the application is installed in one of them. In this case, a warning will be issued to the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.