-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation issue with python callbacks in FilesCatalog package #254
Comments
Yes I forgot to replicate the modifications made to In fact, the way filters is interpreted in that regard has been modified already for the next version as explained in #253 (comment), so the documentation has been updated already. See the dev branch of the Packages repo for the details. Caution though: |
I guess I'll close this to cleanup. Do not hesitate to comment though |
So wait the template got updated, but it still doesn't do it like you commented:
Suppose you have one positive (inclusive) and one negative (exclusive) filter, like ...
filters =
+ ext: .txt
- ext: .exe The default behavior would only put |
With the next release (dev branch), the filters of your example will only include The new behavior to be released is meant to be more intuitive than the current one. So if for some reason you believe it could be improved, shoot before I roll the release :)
You mean there's a bug in the dev branch? I will double-check. |
I didn't check the dev branch. I should learn to read :( |
In the template file for user defined python callbacks it says:
After that there is a template callback. This callback function however does not do the filtering right. That is to say, it doesn't do it like the rest of the package.
I stumbled upon this while write my own callback function and was confused that so many items weren't filtered out and landed in my catalog.
Here is the original bit of code that should do the filtering:
If there is only an inclusive filter, it doesn't exclude items that aren't matching.
My suggestion for an improvement:
The text was updated successfully, but these errors were encountered: