New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portable.ini doesn't accept environment variables #315

Closed
Memphizzz opened this Issue Sep 10, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@Memphizzz

Memphizzz commented Sep 10, 2018

Hi,

I got a portable.ini which has the following line:

portable_dir = C:\Users<user>\keypirinha

I tried to use ${var:KNOWNFOLDER_PROFILE}\keypirinha and %USERPROFILE%\keypirinha but nothing works. Could you add support for environment variables in the portable.ini?

Thanks in advance and keep up the great work!

@polyvertex

This comment has been minimized.

Show comment
Hide comment
@polyvertex

polyvertex Sep 10, 2018

Member

So sorry for that, it was supposed to be implemented already. It will be there in next release.

Note that portable.ini is loaded quite early in the init process so only the conventional notation will be supported (e.g. %USERPROFILE%). This will be documented.

Member

polyvertex commented Sep 10, 2018

So sorry for that, it was supposed to be implemented already. It will be there in next release.

Note that portable.ini is loaded quite early in the init process so only the conventional notation will be supported (e.g. %USERPROFILE%). This will be documented.

@Memphizzz

This comment has been minimized.

Show comment
Hide comment
@Memphizzz

Memphizzz Sep 10, 2018

I see, well thanks for the quick response! I'm looking forward to that feature ;)

Memphizzz commented Sep 10, 2018

I see, well thanks for the quick response! I'm looking forward to that feature ;)

@Memphizzz Memphizzz closed this Sep 10, 2018

@polyvertex

This comment has been minimized.

Show comment
Hide comment
@polyvertex

polyvertex Sep 11, 2018

Member

Reopening until next release is out

Member

polyvertex commented Sep 11, 2018

Reopening until next release is out

@polyvertex polyvertex reopened this Sep 11, 2018

@polyvertex

This comment has been minimized.

Show comment
Hide comment
@polyvertex

polyvertex Sep 13, 2018

Member

Support for env vars in portable.ini added in v2.19

Member

polyvertex commented Sep 13, 2018

Support for env vars in portable.ini added in v2.19

@polyvertex polyvertex closed this Sep 13, 2018

@Memphizzz

This comment has been minimized.

Show comment
Hide comment
@Memphizzz

Memphizzz Sep 13, 2018

Just reporting back, works fine now using:

portable_dir = %USERPROFILE%\keypirinha\

Thanks for the quick fix!

Memphizzz commented Sep 13, 2018

Just reporting back, works fine now using:

portable_dir = %USERPROFILE%\keypirinha\

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment