Make retain_last_search text unselected

[alexandr-san4ez]

Fixed: the space_as_tab setting is now ignored unless the caret is at the end of the search terms while the Space key is pressed

This does not work if the text is selected and caret is at the end.

If press <Space>, will be write space char. I think it less user friendly action.

[polyvertex]

Well, I was not sure about how to handle that case to be honest. I thought, without being positive about it, it would be more conventional to keep it that way in that particular case.

For instance, would space_as_tab be honored in that case, how KP should interpret it? Should it erase the selection then simulate a Tab press? Makes little sense... Even if some text remains after deletion.

[alexandr-san4ez]

I forgot to mention about retain_last_search = yes. It store last command.

When I want reusing last command this is problematic. Because pressing erased text.
And need press Tab or move cursor to last position.

[polyvertex]

Again, to my knowledge, common behavior is to have text erased and replaced by a space character upon Space key press.

So the initial "issue" put aside, would you prefer to have the text unselected when the retain_last_search is enabled?

[alexandr-san4ez]

Previously (version 2.16.3) is opening action list. Honestly, I'm used to it. ;-)
I think will be nice save this behavior.

We cannot check position of cursor after text is selected? Or this not have logic?

[polyvertex]

I still have to check but what may be done to avoid backward compatibility issues is to add a supported value to retain_last_search. Something like unselected in addition to already supported boolean values. So that KP would pop up with last search term unselected.

Would that be an acceptable solution to you?

[alexandr-san4ez]

Yes, sure.

Thank you for your work!

[polyvertex]

The type of the retain_last_search setting changed in v2.20 and now accepts unselected value