Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add horizontal padding in list items #325

Closed
dreadnaut opened this Issue Oct 3, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@dreadnaut
Copy link

dreadnaut commented Oct 3, 2018

(Replaces #324)

The listitem_padding setting is currently applied above and below the icon and label of a list item. This leaves the icon and text immediately next to each other, and in contact with the edges of the element. Adding some horizontal padding could be a simple change that greatly improves the look of the result list.

The diagram below shows the current layout and its configurable values. The bottom half introduces horizontal padding for the result items (the blue markers), at both ends of the bounding box, and between the icon and the label.

layout

I'm uncertain whether re-using the listitem_padding value for the horizontal padding would always make the list visually consistent, so introducing a new configuration entry might work better.

Here's a screenshot of the application (with control_margin = 0), and a mock-up of the same list with horizontal padding.

Without padding

without-padding

With padding

with-padding

@polyvertex

This comment has been minimized.

Copy link
Member

polyvertex commented Oct 4, 2018

Thanks for having taken the time to illustrate your request.

At first glance this probably requires a new setting to avoid breaking backward compatibility just for this and also to keep values format normalized (i.e. CSS-like style value for this setting only whereas other similar settings accept only one numeric value).

@polyvertex

This comment has been minimized.

Copy link
Member

polyvertex commented Oct 9, 2018

I completely have forgotten that request for the v2.20 that has just been released! Not on purpose really! So sorry for that!

@dreadnaut

This comment has been minimized.

Copy link
Author

dreadnaut commented Oct 9, 2018

No problem, it's not exactly urgent!
I must say that if the core project had been open, I would have had a pull request ready 😉

@polyvertex

This comment has been minimized.

Copy link
Member

polyvertex commented Oct 12, 2018

Feature added in v2.21.
For consistency, all spacing-related settings now differentiate horizontal and vertical spacing.

@polyvertex polyvertex closed this Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.