New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set (smaller) font size for item description separately #327

Closed
lindeloev opened this Issue Oct 8, 2018 · 10 comments

Comments

Projects
None yet
3 participants
@lindeloev

lindeloev commented Oct 8, 2018

I would like to set a much smaller font size for item descriptions in order to increase the focus on the item name. I am coming from Albert which has this layout:

image

So maybe add font_description_size and font_description_style options?

@polyvertex

This comment has been minimized.

Show comment
Hide comment
@polyvertex

polyvertex Oct 8, 2018

Member

This will probably end up with a listitem_title_size setting being added as an enum (small, normal, large) so to match the desired font size, as defined by the font_small_size, font_normal_size and font_large_size settings respectively. Default value would be small for consistency with previous releases.

Member

polyvertex commented Oct 8, 2018

This will probably end up with a listitem_title_size setting being added as an enum (small, normal, large) so to match the desired font size, as defined by the font_small_size, font_normal_size and font_large_size settings respectively. Default value would be small for consistency with previous releases.

@lindeloev

This comment has been minimized.

Show comment
Hide comment
@lindeloev

lindeloev Oct 8, 2018

Sounds great to me. Thanks for considering it!

lindeloev commented Oct 8, 2018

Sounds great to me. Thanks for considering it!

@polyvertex

This comment has been minimized.

Show comment
Hide comment
@polyvertex

polyvertex Oct 9, 2018

Member

Implemented in v2.20.
Feature is slightly different than described above but same spirit!

Member

polyvertex commented Oct 9, 2018

Implemented in v2.20.
Feature is slightly different than described above but same spirit!

@polyvertex polyvertex closed this Oct 9, 2018

@lindeloev

This comment has been minimized.

Show comment
Hide comment
@lindeloev

lindeloev Oct 9, 2018

That is beyond aweseome, @polyvertex! 26 hours from feature wish to implementation. I'm very happy I donated via PayPal. I hope others are supporting economically as well.

Waiting for the chocolatey to get v2.20. http://keypirinha.com/update.html does not mention upgrading via chocolatey, but I assume it's just

  • Close Keypirinha
  • Run choco update keypirinha

lindeloev commented Oct 9, 2018

That is beyond aweseome, @polyvertex! 26 hours from feature wish to implementation. I'm very happy I donated via PayPal. I hope others are supporting economically as well.

Waiting for the chocolatey to get v2.20. http://keypirinha.com/update.html does not mention upgrading via chocolatey, but I assume it's just

  • Close Keypirinha
  • Run choco update keypirinha
@polyvertex

This comment has been minimized.

Show comment
Hide comment
@polyvertex

polyvertex Oct 9, 2018

Member

Well, to be fully honest, it's just that I was about to make a release and decided to include your request since it was no big deal :)

Re: choco, their CDN might take a while to be updated (up to 30 minutes announced).

Member

polyvertex commented Oct 9, 2018

Well, to be fully honest, it's just that I was about to make a release and decided to include your request since it was no big deal :)

Re: choco, their CDN might take a while to be updated (up to 30 minutes announced).

@laurin1

This comment has been minimized.

Show comment
Hide comment
@laurin1

laurin1 Oct 9, 2018

That is beyond aweseome, @polyvertex! 26 hours from feature wish to implementation. I'm very happy I donated via PayPal. I hope others are supporting economically as well.

Waiting for the chocolatey to get v2.20. http://keypirinha.com/update.html does not mention upgrading via chocolatey, but I assume it's just

  • Close Keypirinha
  • Run choco update keypirinha

You don't have to close Keypirinha - the installation script closes it automatically. You will have to launch it again manually.

laurin1 commented Oct 9, 2018

That is beyond aweseome, @polyvertex! 26 hours from feature wish to implementation. I'm very happy I donated via PayPal. I hope others are supporting economically as well.

Waiting for the chocolatey to get v2.20. http://keypirinha.com/update.html does not mention upgrading via chocolatey, but I assume it's just

  • Close Keypirinha
  • Run choco update keypirinha

You don't have to close Keypirinha - the installation script closes it automatically. You will have to launch it again manually.

@polyvertex

This comment has been minimized.

Show comment
Hide comment
@polyvertex

polyvertex Oct 9, 2018

Member

@laurin1 while not being a technical requirement, it is still good practice to exit the app gracefully first.

Member

polyvertex commented Oct 9, 2018

@laurin1 while not being a technical requirement, it is still good practice to exit the app gracefully first.

@laurin1

This comment has been minimized.

Show comment
Hide comment
@laurin1

laurin1 Oct 9, 2018

@polyvertex that kind of kills the point of using choco though. I'm almost never updating AN application. On my primary machines, I'm updating 30-50 apps, on my servers, 10-20, using "cup all".

laurin1 commented Oct 9, 2018

@polyvertex that kind of kills the point of using choco though. I'm almost never updating AN application. On my primary machines, I'm updating 30-50 apps, on my servers, 10-20, using "cup all".

@polyvertex

This comment has been minimized.

Show comment
Hide comment
@polyvertex

polyvertex Oct 10, 2018

Member

@laurin1 well, it all boils down to how choco scripts are crafted and more specifically what the commonly used Stop-Process cmdlet really does under the hood - if you happen to know.

For instance, it seems the taskkill util will first try to send a close message to the target app and wait for it before just terminating the process after some reasonable amount of time in case it's still running and the force flag has been specified. This is would happen to be in accordance with MS' guidelines.

If Stop-Process follows the same pattern, then all good. I would tend to guess it does since its flags are pretty similar to taskkill's and both are developed by MS so they hopefully opted for consistency. But I have no clue.

Member

polyvertex commented Oct 10, 2018

@laurin1 well, it all boils down to how choco scripts are crafted and more specifically what the commonly used Stop-Process cmdlet really does under the hood - if you happen to know.

For instance, it seems the taskkill util will first try to send a close message to the target app and wait for it before just terminating the process after some reasonable amount of time in case it's still running and the force flag has been specified. This is would happen to be in accordance with MS' guidelines.

If Stop-Process follows the same pattern, then all good. I would tend to guess it does since its flags are pretty similar to taskkill's and both are developed by MS so they hopefully opted for consistency. But I have no clue.

@laurin1

This comment has been minimized.

Show comment
Hide comment
@laurin1

laurin1 Oct 10, 2018

I feel confident that Stop-Process does attempt a safe shutdown first, but I'm doing some digging to get a better answer.

laurin1 commented Oct 10, 2018

I feel confident that Stop-Process does attempt a safe shutdown first, but I'm doing some digging to get a better answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment