Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks Plugin - UnicodeDecodeError #336

Closed
mockroot opened this issue Nov 1, 2018 · 6 comments
Closed

Bookmarks Plugin - UnicodeDecodeError #336

mockroot opened this issue Nov 1, 2018 · 6 comments

Comments

@mockroot
Copy link

@mockroot mockroot commented Nov 1, 2018

After updating Keypirinha to v2.22, this error appeared in console:

16:26:22.963 ** ERROR: Error from Bookmarks.Bookmarks.on_catalog: <class 'UnicodeDecodeError'>: 'charmap' codec can't decode byte 0x9d in position 27708: character maps to <undefined>
Traceback (most recent call last):
  File "D:\Files\Win\Portable\Keypirinha\default\Packages\Bookmarks.keypirinha-package\bookmarks.py", line 60, in on_catalog
  File "D:\Files\Win\Portable\Keypirinha\default\Packages\Bookmarks.keypirinha-package\providers\chrome.py", line 43, in list_bookmarks
  File "D:\Files\Win\Portable\Keypirinha\default\Packages\Bookmarks.keypirinha-package\providers\chrome.py", line 78, in _read_bookmarks
  File "lib\json\__init__.py", line 296, in load
  File "lib\encodings\cp1254.py", line 23, in decode
@mockroot mockroot changed the title Bookmark Plugin - UnicodeDecodeError Bookmarks Plugin - UnicodeDecodeError Nov 1, 2018
@polyvertex
Copy link
Member

@polyvertex polyvertex commented Nov 1, 2018

Very probably due to the upgrade of the chardet Python library, of which I am not the author.

Unless you have the skills to track down this bug, would you be willing to send me privately (i.e. not here) your Chrome's Bookmarks file so I can investigate on this and report to the author of chardet?

Loading

@mockroot
Copy link
Author

@mockroot mockroot commented Nov 1, 2018

Sorry, I can't share.

New info:
I tried bookmarks package with other browsers: Chrome and Vivaldi cause this error, but Firefox don't. (same bookmarks)

Anyway, error doesn't bother me and it seems working as usual. I just wanted to let you know. Thank you.

Loading

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Nov 2, 2018

Fair enough.

Unfortunately I cannot fix what I cannot reproduce so unless someone reading this is willing to provide any sample material, there is nothing that can be done on my side. Sorry for that.

Loading

@polyvertex polyvertex closed this Nov 2, 2018
@Zottelchen
Copy link

@Zottelchen Zottelchen commented Aug 10, 2019

Similiar issue:

14:48:11.821 ** ERROR: Error from Bookmarks.Bookmarks.on_catalog: <class 'UnicodeDecodeError'>: 'charmap' codec can't decode byte 0x8f in position 21361: character maps to <undefined>
Traceback (most recent call last):
  File "C:\Program Files\Keypirinha\default\Packages\Bookmarks.keypirinha-package\bookmarks.py", line 60, in on_catalog
  File "C:\Program Files\Keypirinha\default\Packages\Bookmarks.keypirinha-package\providers\chrome.py", line 43, in list_bookmarks
  File "C:\Program Files\Keypirinha\default\Packages\Bookmarks.keypirinha-package\providers\chrome.py", line 78, in _read_bookmarks
  File "lib\json\__init__.py", line 296, in load
  File "lib\encodings\cp1254.py", line 23, in decode

Send you my Bookmarks on Gitter.im

Loading

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Aug 13, 2019

@Zottelchen thanks for jumping in. I will use your file to do some tests on my side

Loading

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Aug 18, 2019

This should be fixed in v2.24 that just has been released. Thanks!

Loading

@polyvertex polyvertex closed this Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants