New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

score system ignored when typing "e" #38

Closed
ZIEXED opened this Issue Apr 8, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@ZIEXED

ZIEXED commented Apr 8, 2016

Item properties:
label: =
args: e
short_desc: = 2.718281828459045 (Press Enter to copy the result)
target: =
category: keyword (10)
args_hint: required
hit_hint: ignore
plugin: Calc.Calc
id: 12382293855684180354

e is always associated with this item

edit:
I unpacked the calc plugin it looks like this is premeditated but it still annoying so I edited this my self for now

@polyvertex

This comment has been minimized.

Member

polyvertex commented Apr 11, 2016

It is on purpose indeed. A way to get around this cleanly would be to modify the on_suggest method of the plugin so it populates suggestions only when user has selected Calc's = item already. It's an easy fix. Insert the following block at the beginning of the on_suggest method:

if not initial_item:
    return
@ZIEXED

This comment has been minimized.

ZIEXED commented Apr 11, 2016

Thanks for your response :)

@ZIEXED ZIEXED closed this Apr 11, 2016

@polyvertex

This comment has been minimized.

Member

polyvertex commented Apr 13, 2016

I will add a setting for that in the next version, which is about to be released.

@polyvertex polyvertex reopened this Apr 13, 2016

@polyvertex polyvertex added this to the v2.5 milestone Apr 13, 2016

@polyvertex

This comment has been minimized.

Member

polyvertex commented Apr 13, 2016

Done. See v2.5

@polyvertex polyvertex closed this Apr 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment