Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error using filter attr directory in files catalog #388

Closed
ueffel opened this issue Jun 8, 2019 · 3 comments

Comments

@ueffel
Copy link

commented Jun 8, 2019

Keypirinha Version: 2.23

Multiple users reported problems with the + attr: directory filters setting for files catalog profiles.

Profiles like this:

[profile/Projects]
activate = yes
paths = 
    ${var:KNOWNFOLDER_DESKTOP}\**
filters =
    + attr: directory
max_depth = -1
include_dirs = yes
file_item_label = {profile}: {dir1}\{clean_name}

Produce the following error:

** ERROR: Error from FilesCatalog.FilesCatalog.on_events: <class 'TypeError'>: '_GlobExEntry_Path' object does not support indexing
Traceback (most recent call last):
  File "C:\Apps\Keypirinha\default\Packages\FilesCatalog.keypirinha-package\filescatalog.py", line 356, in on_events
  File "C:\Apps\Keypirinha\default\Packages\FilesCatalog.keypirinha-package\filescatalog.py", line 311, in on_catalog
  File "C:\Apps\Keypirinha\default\Packages\FilesCatalog.keypirinha-package\filescatalog.py", line 203, in default_scan_callback
  File "C:\Apps\Keypirinha\python\site\filefilter.py", line 423, in match
    elif path_or_entry[0] == '.':

References to the chatroom:

@polyvertex

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Because I trust you @ueffel. Because I believe in you. I will just blindly flag this as a bug straight away without even trying it myself. Fear the pain if it proves itself not to be a bug!

@polyvertex

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

Well, it was a bug! :)
Thanks for reporting it and sorry for the inconvenience

@polyvertex polyvertex removed the status/done label Aug 18, 2019

@polyvertex

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

Fixed (should be) in release v2.24, thanks!

@polyvertex polyvertex closed this Aug 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.