Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Package : Inserted IP doesn't work #40

Closed
ZIEXED opened this issue Apr 13, 2016 · 4 comments
Closed

URL Package : Inserted IP doesn't work #40

ZIEXED opened this issue Apr 13, 2016 · 4 comments

Comments

@ZIEXED
Copy link

@ZIEXED ZIEXED commented Apr 13, 2016

The package works fine for URLs but does nothing when inserting any IP
Win7 default Browser:FF

@ZIEXED
Copy link
Author

@ZIEXED ZIEXED commented Apr 13, 2016

78:19:32.669 ** ERROR: Error from URL.URL.on_execute: <class 'FileNotFoundError'>: file not found: 192.168.1.1
Traceback (most recent call last):
File "D:\Keypirinha\default\Packages\URL.keypirinha-package\url.py", line 91, in on_execute
File "D:\Keypirinha\python\site\keypirinha_util.py", line 760, in execute_default_action
shell_execute(catalog_item.target())
File "D:\Keypirinha\python\site\keypirinha_util.py", line 461, in shell_execute
raise FileNotFoundError("file not found: {}".format(thing))

@ZIEXED
Copy link
Author

@ZIEXED ZIEXED commented Apr 14, 2016

inserting "http:" before any IP then lunch will open a new window in the default browser
and it won't navigate to the IP, Just a new window with the homepage or whatever the default browser behavior selected

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Apr 14, 2016

The package works fine for URLs but does nothing when inserting any IP

This should be corrected in 2.5.1

inserting "http:" before any IP then lunch will open a new window in the default browser
and it won't navigate to the IP, Just a new window with the homepage or whatever the default browser behavior selected

The correct prefix would be http:// in this case, though it's is automatically corrected by Chrome for example (i.e. \ replaced by /), but not by Firefox obviously. In any case, it is not up to the URL plugin to automatically do this correction.

@ZIEXED
Copy link
Author

@ZIEXED ZIEXED commented Apr 14, 2016

Updated to latest version
Thank you it's working fine now :)

@ZIEXED ZIEXED closed this Apr 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.