Calc gets triggered with some URLs

[polyvertex]

When I paste a URL that contain an equal = sign in it, the Calc plugin now gets triggered since v2.24.

Example: https://www.youtube.com/watch?v=xZdGnAJGvrY

I suppose PR Keypirinha/Packages#29 might be the culprit by having a too permissive regex? Maybe @DrorHarari has a clue?

[DrorHarari]

I can confirm that this is cause by that PR but it is not too permissive regex but intermixing of existing behaviors.

In general, there are two patterns it matches:
name=expression and expression=name

Here, 'name' is very restricted (essentially an identifier) while 'expression' is as permissive as possible (because the expression part is open-ended).

It is the second pattern that matches the URL "https://www.youtube.com/watch?v=xZdGnAJGvrY" but since what's to the left of the equal sign is not a valid expression, you get a red error text, interfering with the proper URL selection in the first place.

It is not easy to identify that the expression in expression=name is not a valid expression in order to suppress the error. Normally, Calc evaluates all expressions and does not report an error unless the = sign is given explicitly which in this case it is.

Possible fixes:

1. Maintain the exception suppression in the case expression=name pattern is matched
2. Make the second pattern be expression=>name (that is change = to =>)

I prefer to use #1 and have submitted a PR with a fix.

[DrorHarari]

For whomever find this bug annoying I have released a fix just for the Calc plugin at https://github.com/DrorHarari/Packages/releases/tag/v.2.24-calc-plugin-patch - it will most likely be resolved in the next release of Keypirinha at which point, this patch will be removed.

[polyvertex]

Fixed in v2.25, thanks!