New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ESC to close the launchbox on first keypress #41

Closed
mtaki14 opened this Issue Apr 14, 2016 · 9 comments

Comments

Projects
None yet
4 participants
@mtaki14

mtaki14 commented Apr 14, 2016

Not sure if this is currently possible but I wasn't able to find such a setting in the configuration file.

Current behaviour when pressing ESC:

  1. On first press contents of launchbox are cleared
  2. On second press KeyPirinha is minimized

Requested behaviour:

  1. On first press KeyPirinha is minimized

This request makes sense for when the setting "retain_last_search" is set to "yes".

@ZIEXED

This comment has been minimized.

ZIEXED commented Apr 14, 2016

When you select an item from the list the last search string will still exist next time you call KP
You can use Alt+F4 to close the KP window without losing your string

@mtaki14

This comment has been minimized.

mtaki14 commented Apr 14, 2016

I understand that but I'm so used to using ESC for closing from using Launchy and Everything that switching to alt-F4 seems really inconvenient now. An option for this behaviour would be ideal.

i think your suggestion would make more sense if I only occasionally wanted to retain the search string.

@polyvertex

This comment has been minimized.

Member

polyvertex commented Apr 14, 2016

This request makes sense for when the setting "retain_last_search" is set to "yes".

Good point. Following a similar idea I planned a while ago, but totally forgot, to implement the Shift+Esc shortcut to close the LaunchBox since I always found the standard Alt+F4 shortcut inconvenient.

Both option and shortcut will be implemented in the next version.

@polyvertex polyvertex changed the title from [request] Using ESC to close the launchbox on first keypress to Using ESC to close the launchbox on first keypress Apr 14, 2016

@polyvertex polyvertex added this to the v2.6 milestone Apr 14, 2016

@polyvertex polyvertex closed this Apr 16, 2016

@polyvertex polyvertex removed this from the v2.6 milestone Apr 16, 2016

@sergeevabc

This comment has been minimized.

sergeevabc commented Apr 16, 2016

Was looking for option to hide K using ESC, thanks for implementing.

@sergeevabc

This comment has been minimized.

sergeevabc commented Apr 16, 2016

Was worried about new hard-coded Shift+Esc sequence to hide K because I use this shortcut to invoke Everything. Great to see they play nicely together, i.e. K does not hide when Everything is invoked in this manner. In short, the less hard-coded sequences, the longer life without compatibility issues.

@polyvertex

This comment has been minimized.

Member

polyvertex commented Apr 16, 2016

I wouldn't bind such too simple global shortcuts if I were you. Binding Shift+Esc as a global hotkey is as bad as trying to bind a Win+Letter shortcut, because the environment you chose to work with, Windows, comes with some conventions. The reason why Shift+Esc "works" for now on your config is because event is trapped before KP has a chance to know about it. In other words, you shouldn't rely on this unstable behavior.

So while I agree about the "hard-coded" part (obviously), you definitely chose the wrong use-case to illustrate your theory.

@sergeevabc

This comment has been minimized.

sergeevabc commented Apr 16, 2016

Windows hard-coded conventions (especially introduced in 7 and later editions) annoy users so much no wonder Autohotkey became popular. It seems there is nothing wrong to have any global shortcut to do anything if you agree other apps will not work as expected without remapping that shortcut (that’s why I was worried about unremappable hard-coded Shift+Esc in K).

For years I set globally

And current shortcut for Keypirinha is `Alt+``
Alas, it can’t be set naturally, so Autohotkey comes into play again:

$!`::
KeyWait Alt
SendInput ^#k
Return
@polyvertex

This comment has been minimized.

Member

polyvertex commented Apr 16, 2016

Like I said, whether you're willing to admit it or not, you technically have to take the conventions of the system you are working with into account. And obviously you did. As a counter-example, there is nothing wrong to hard-code the binding of Shift+Esc locally (i.e. per application).

Anyway, I was just pointing out that KP has nothing to do with the fact that your global binding still works on your config.

You should have made a request about your Alt+` problem though.

@sergeevabc

This comment has been minimized.

sergeevabc commented Apr 16, 2016

Meanwhile, let’s drink to peace, comrade.

Caipirinhas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment