Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert recent search entries by pressing down arrow #45

Closed
ZIEXED opened this issue Apr 16, 2016 · 4 comments
Closed

Insert recent search entries by pressing down arrow #45

ZIEXED opened this issue Apr 16, 2016 · 4 comments

Comments

@ZIEXED
Copy link

@ZIEXED ZIEXED commented Apr 16, 2016

Get recent search entries by pressing down arrow
And maybe in settings you can control how many entries KP can keep 馃憤
This would be very useful.

@ZIEXED ZIEXED changed the title Get recent search entries by pressing down arrow Insert recent search entries by pressing down arrow Apr 16, 2016
@sergeevabc
Copy link

@sergeevabc sergeevabc commented Apr 16, 2016

Simple approach is to remember last entry and to 鈥減aste鈥 it when Down is pressed. Advanced approach (resembling visual behavior of Executor) is to show (let鈥檚 say 5) past entries below empty launchbox to choose one with Down key.

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Jul 8, 2016

This collides with the retain_last_search option in case it is enabled. The last search would be restored so pressing the Down key only won't suffice anymore for KP to differentiate between the I want to see the history list versus I just want to select the item below actions.

Haven't thought much about it yet but things look like this so far:

  • retain_last_search is disabled, the LaunchBox is empty, just pressing Down will list the history (configurable length), as well as Ctrl+Down.
  • retain_last_search is enabled, the LaunchBox is displayed and last search is restored. Then only Ctrl+Down would allow to list the history.

So to summarize, Ctrl+Down would always reset the current search, if any, and display the history list. Down would only do so if and only if search state is clean (i.e. no typed terms/args).
Also, in case the history list is already displayed, Ctrl+Down would just select the history item below the currently selected one.

@psistorm
Copy link

@psistorm psistorm commented Jul 14, 2016

Ctrl-Down seems to be a good option to implement this request. I also found myself several times trying to get back an item from my typed history

@polyvertex
Copy link
Member

@polyvertex polyvertex commented Aug 20, 2016

Implemented in 2.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can鈥檛 perform that action at this time.