-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No launching while the catalog is being updated #52
Comments
It's in my todo list since ages.
Which one? #22? |
What I meant to say is: |
I don't know how much of a problem this is across the user base but, at least for me, it is a major inconvenience: My catalogue takes a bunch of minutes to rebuild, which renders the tool unpractical for me. I say this only for feedback, not cynically at all, but this issue, together with #16 (#32) are the only ones that are keeping me from transitioning from Launchy to Keypirinha. I know the day will come, I'm just sharing what the trigger will be for me. |
@egabrum I'm marking this as "done" because this issue, at least the way I understood it, should mechanically be solved by the implementation of a persistent catalog mechanism, which will be available in the next release (#22). Your items will be available and searchable at startup time while plugins fetch their items. Once they're done, the list of new items is then merged into the catalog. Now this "merge" operation becomes the true bottleneck here because catalog is not searchable while being updated (it doesn't duplicate itself to avoid increasing too much memory usage). However it takes only from a few milliseconds up to a second to be done, depending on the size of the catalog and the speed of the CPU. It's insignificant in most cases but if you still happen to use Keypirinha and experience annoyance after upgrading to next release, do not hesitate to comment here. |
Should now be obsoleted by the persistent catalog feature implement in v2.10 (see #22). |
After upgrading to version 2.10 still cannot run any item from catalog during updating. |
@aleksey-khokhryakov many parts of Keypirinha are involved during catalog's updating, I would need more info so I can reproduce the issue, or at least help to track it down. Please try to follow these guidelines. Also, it may help to share the content of your |
I can reproduce to issue to some extend:
Note that Notepad would be within the
=> After finishing the Apps.ExtraPaths catalog KP launches my item (ConsoleZ) So i think items from the catalog that is currently refreshing cannot be launched, items from any other calalog can. |
Mmh situation B is not supposed to happen that way since the Catalog is cleared/merged only at the end of the EDIT Reopening this during investigation... |
Silly me, of course it doesn't work! Everyone here is talking about launching an item, whereas, for some mystical reason I thought you folks meant it was because items were not searchable at cataloging time. |
Thank you in advance 8) |
Should be fine now as of 2.11 |
Excellent work!!! |
I can't seem to be able to launch anything while KP is refreshing the catalog, which in my case takes a few minutes. It does seem to grant my latest request, but only after it finishes refreshing the catalog.
Together with issue #22, this pretty much makes my KP a sitting duck when I launch it
The text was updated successfully, but these errors were encountered: