Firefox padding bookmarks gets listed #66

Closed
poisonborz opened this Issue May 10, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@poisonborz

Firefox (but I suspect other browsers too) uses paddign elements in its bookmarks storage eg. to define folders/hierarchy. These are picked up by KP as a bookmark. Maybe the solution would be for KP to check bookmarks for being actual url-s.
clipboard01

@polyvertex

This comment has been minimized.

Show comment
Hide comment
@polyvertex

polyvertex May 10, 2016

Member

What's your item_label_format value?
Could you paste the item properties please (first item of the screenshot should be enough)?

(but I suspect other browsers too) ...
... Maybe the solution would be for KP to check bookmarks for being actual url-s

In the context of a faulty feature and as a rule of thumb, if this is not something you observed yourself, do not write it. Please stick to the facts as this kind of comments don't add any value to your feedback. I mean no offence but be aware that this practice may lead the developer to a wrong way in the quest to improve user's experience or to search for a bug. I repeat, please stick to the facts.

Member

polyvertex commented May 10, 2016

What's your item_label_format value?
Could you paste the item properties please (first item of the screenshot should be enough)?

(but I suspect other browsers too) ...
... Maybe the solution would be for KP to check bookmarks for being actual url-s

In the context of a faulty feature and as a rule of thumb, if this is not something you observed yourself, do not write it. Please stick to the facts as this kind of comments don't add any value to your feedback. I mean no offence but be aware that this practice may lead the developer to a wrong way in the quest to improve user's experience or to search for a bug. I repeat, please stick to the facts.

@ZIEXED

This comment has been minimized.

Show comment
Hide comment
@ZIEXED

ZIEXED May 10, 2016

That's not important but I can confirm this [Firefox]

ZIEXED commented May 10, 2016

That's not important but I can confirm this [Firefox]

@poisonborz

This comment has been minimized.

Show comment
Hide comment
@poisonborz

poisonborz May 10, 2016

In the context of a faulty feature and as a rule of thumb, if this is not something you observed yourself, do not write it.

Feedback accepted - and while I agree that we should stick to facts, there was added value: "other browsers might also use similar padding items, so this might be not specific to Firefox". Sure, any dev worth its salt would suspect this, but I thought a bracketed half-sentence wouldn't hurt. I won't try to defend the suggestion solution though :D

My format is simply
item_label_format = {label} ({provider})

In the context of a faulty feature and as a rule of thumb, if this is not something you observed yourself, do not write it.

Feedback accepted - and while I agree that we should stick to facts, there was added value: "other browsers might also use similar padding items, so this might be not specific to Firefox". Sure, any dev worth its salt would suspect this, but I thought a bracketed half-sentence wouldn't hurt. I won't try to defend the suggestion solution though :D

My format is simply
item_label_format = {label} ({provider})

@polyvertex

This comment has been minimized.

Show comment
Hide comment
@polyvertex

polyvertex May 10, 2016

Member

Could you paste the item properties please (first item of the screenshot should be enough)?

Member

polyvertex commented May 10, 2016

Could you paste the item properties please (first item of the screenshot should be enough)?

@ZIEXED

This comment has been minimized.

Show comment
Hide comment
@ZIEXED

ZIEXED May 11, 2016

99:24:47.719 Item properties:
label: Bookmark: place:folder=BOOKMARKS_MENU (Firefox)
args:
short_desc:
target: place:folder=BOOKMARKS_MENU
category: url (40)
args_hint: forbidden
hit_hint: noargs
plugin: Bookmarks.Bookmarks
item_id: 9772809686195440809
loop_on_suggest: false

ZIEXED commented May 11, 2016

99:24:47.719 Item properties:
label: Bookmark: place:folder=BOOKMARKS_MENU (Firefox)
args:
short_desc:
target: place:folder=BOOKMARKS_MENU
category: url (40)
args_hint: forbidden
hit_hint: noargs
plugin: Bookmarks.Bookmarks
item_id: 9772809686195440809
loop_on_suggest: false

@polyvertex

This comment has been minimized.

Show comment
Hide comment
@polyvertex

polyvertex Jul 11, 2016

Member

Fixed in 2.8

Member

polyvertex commented Jul 11, 2016

Fixed in 2.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment