Showing history hits without scores #84

Closed
wwwald opened this Issue Jul 7, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@wwwald

wwwald commented Jul 7, 2016

I would like to set up this configuration:

...
show_scores = no
show_history_hits = yes
...

But: the history hits do not appear without the scores being switched on.

@polyvertex

This comment has been minimized.

Show comment
Hide comment
@polyvertex

polyvertex Jul 7, 2016

Member

Yes, as explained by the comments in the configuration file, the show_history_hits feature is only available if show_scores is enabled. It was due to a small technical constraint in the early days of the project.

There is no reason why it should remain like this anymore though so it will be changed in the next release to match your request.

Member

polyvertex commented Jul 7, 2016

Yes, as explained by the comments in the configuration file, the show_history_hits feature is only available if show_scores is enabled. It was due to a small technical constraint in the early days of the project.

There is no reason why it should remain like this anymore though so it will be changed in the next release to match your request.

@polyvertex

This comment has been minimized.

Show comment
Hide comment
@polyvertex

polyvertex Jul 11, 2016

Member

Implemented in 2.8

Member

polyvertex commented Jul 11, 2016

Implemented in 2.8

@kevin-stuart

This comment has been minimized.

Show comment
Hide comment
@kevin-stuart

kevin-stuart Aug 16, 2017

I recently updated Keypirinha and saw that the history hits are not displayed anymore. How do I enable it again? If I use show_history_hits = yes in [gui] the console warns that this is deprecated. If I put it in the section of the currently selected theme, I still do not see the history hits again.

I recently updated Keypirinha and saw that the history hits are not displayed anymore. How do I enable it again? If I use show_history_hits = yes in [gui] the console warns that this is deprecated. If I put it in the section of the currently selected theme, I still do not see the history hits again.

@polyvertex

This comment has been minimized.

Show comment
Hide comment
@polyvertex

polyvertex Aug 16, 2017

Member

@kevin-stuart show_history_hits has been removed in v2.14 in favor of the layout setting that is part of the theme feature. Sorry for the inconvenience. Do not hesitate to ask for help in the chat room if you need help with that.

Member

polyvertex commented Aug 16, 2017

@kevin-stuart show_history_hits has been removed in v2.14 in favor of the layout setting that is part of the theme feature. Sorry for the inconvenience. Do not hesitate to ask for help in the chat room if you need help with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment