Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoogleTranslate: idle_time setting #5

Merged
merged 2 commits into from Aug 26, 2017
Merged

GoogleTranslate: idle_time setting #5

merged 2 commits into from Aug 26, 2017

Conversation

alexandr-san4ez
Copy link
Contributor

No description provided.

@polyvertex polyvertex changed the title Added waiting parameter GoogleTranslate: idle_time setting Aug 12, 2017
# * Time in seconds (can be used with float type)
# * The minimum value is 0.25
# * Default: 0.25
#waiting_time = 0.25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remarks than for WebSuggest:

  • hard-coded maximum value of 3 seconds
  • I think idle_time is more appropriate than waiting_time

@@ -227,6 +229,10 @@ def _warn_skip_custitem(name, section):
else:
self.default_lang_out = validated_lang_code

self.waiting_time = settings.get_float(
"waiting_time", self.CONFIG_SECTION_DEFAULTS,
fallback=self.DEFAULT_WAITING_TIME, min=0.25)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(max value)

@polyvertex
Copy link
Member

Please PR on the dev branch

@alexandr-san4ez alexandr-san4ez changed the base branch from master to dev August 12, 2017 10:27
@alexandr-san4ez
Copy link
Contributor Author

Maybe you did not see the change. Check this PR and #4.

@polyvertex polyvertex merged commit f288ffe into Keypirinha:dev Aug 26, 2017
@alexandr-san4ez alexandr-san4ez deleted the google-translate branch August 27, 2017 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants