GoogleTranslate: idle_time setting #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polyvertex
changed the title
polyvertex
requested changes
Aug 12, 2017
GoogleTranslate/googletranslate.ini
Outdated
| # * Time in seconds (can be used with float type) | ||
| # * The minimum value is 0.25 | ||
| # * Default: 0.25 | ||
| #waiting_time = 0.25 |
There was a problem hiding this comment.
Same remarks than for WebSuggest:
- hard-coded maximum value of 3 seconds
- I think
idle_timeis more appropriate thanwaiting_time
GoogleTranslate/googletranslate.py
Outdated
| @@ -227,6 +229,10 @@ def _warn_skip_custitem(name, section): | |||
| else: | |||
| self.default_lang_out = validated_lang_code | |||
|
|
|||
| self.waiting_time = settings.get_float( | |||
| "waiting_time", self.CONFIG_SECTION_DEFAULTS, | |||
| fallback=self.DEFAULT_WAITING_TIME, min=0.25) | |||
|
Please PR on the |
|
Maybe you did not see the change. Check this PR and #4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.