New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost property tree with rapidjson #80

Open
hendrikmuhs opened this Issue May 4, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@hendrikmuhs
Contributor

hendrikmuhs commented May 4, 2018

The code uses rapidjson for json parsing but also the json version of boost property tree in other places. It should be possible to replace all boost property trees with rapidjson.

(FWIW: The reason is historical, property trees have been used before all the json support was added)

hendrikmuhs added a commit to hendrikmuhs/keyvi-1 that referenced this issue Sep 13, 2018

hendrikmuhs added a commit that referenced this issue Sep 29, 2018

remove SetManifest from boost property trees (#108)
removes SetManifest(boost:ptree) in favor of SetManifest(std::string), the first wasn't in use, so it is IMHO safe to remove.

relates #80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment