New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter some build files from coveralls #100

Merged
merged 3 commits into from Sep 11, 2018

Conversation

Projects
None yet
3 participants
@hendrikmuhs
Contributor

hendrikmuhs commented Sep 9, 2018

fixes the coveralls filter to ignore some build files

hendrikmuhs added some commits Sep 9, 2018

@coveralls

This comment has been minimized.

coveralls commented Sep 9, 2018

Coverage Status

Coverage remained the same at 95.183% when pulling e3fa5fa on hendrikmuhs:fix-coveralls-filter into d8faf0b on KeyviDev:master.

@hendrikmuhs

This comment has been minimized.

Contributor

hendrikmuhs commented Sep 10, 2018

Removes some cmake related coverage data, see the tree view of:

https://coveralls.io/github/KeyviDev/keyvi?branch=master
vs.
https://coveralls.io/builds/18903062

Unexpectedly the coverage itself isn't affected.

@narekgharibyan

This comment has been minimized.

Member

narekgharibyan commented Sep 11, 2018

Probably for some reason that results was NaN, so it was not taken into account.

screen shot 2018-09-11 at 10 34 40

@hendrikmuhs

This comment has been minimized.

Contributor

hendrikmuhs commented Sep 11, 2018

yes, still good to get rid of this.

@narekgharibyan

This comment has been minimized.

Member

narekgharibyan commented Sep 11, 2018

Sure thing, is this ready to be merged ?

@hendrikmuhs

This comment has been minimized.

Contributor

hendrikmuhs commented Sep 11, 2018

yes, that's all. Squashing will make sure, it is just 1 commit in the end.

@hendrikmuhs hendrikmuhs merged commit db85ff9 into KeyviDev:master Sep 11, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.183%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment