New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang 6.0 #98

Merged
merged 4 commits into from Sep 6, 2018

Conversation

Projects
None yet
2 participants
@narekgharibyan
Member

narekgharibyan commented Sep 5, 2018

  • using clang-format-6.0
  • renamed folder docker/manylinux -> docker/manylinux-builder

@narekgharibyan narekgharibyan requested a review from hendrikmuhs Sep 5, 2018

&& rm -rf /var/lib/apt/lists/*

# symlink for clang-format
RUN ln -s /usr/bin/clang-format-6.0 /usr/bin/clang-format

This comment has been minimized.

@hendrikmuhs

hendrikmuhs Sep 5, 2018

Contributor

The ubuntu/debian way:

update-alternatives --install /usr/bin/clang-format clang-format /usr/bin/clang-format-6.0 1000

This comment has been minimized.

@narekgharibyan

narekgharibyan Sep 5, 2018

Member

Didn't know, thanks for the hint.

narekgharibyan added some commits Sep 5, 2018

- exposed TRAVIS* env vars to coveralls
 - removed use of COVERALLS_REPO_TOKEN, as it's not needed on Travis-CI
@narekgharibyan

This comment has been minimized.

Member

narekgharibyan commented Sep 6, 2018

It turns out COVERALLS_REPO_TOKEN is not needed when submitting coverage reports from Travis-CI. So will remove it from Travis once this PR is merged.

@hendrikmuhs

LGTM

@narekgharibyan narekgharibyan merged commit ea121d3 into KeyviDev:master Sep 6, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on clang-6.0 at 95.183%
Details

@narekgharibyan narekgharibyan deleted the narekgharibyan:clang-6.0 branch Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment