New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch makeGlue from .mord .rule to .mspace #1295
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1295 +/- ##
=======================================
Coverage 83.88% 83.88%
=======================================
Files 61 61
Lines 3978 3978
Branches 661 661
=======================================
Hits 3337 3337
Misses 543 543
Partials 98 98
Continue to review full report at Codecov.
|
Amazingly, only two screenshots were affected. Here's the diff: The result of this PR is in green/yellow, with more spaces. Somewhat easier to see in the Github diff. I think this shows that the change fixes some spacing bugs, properly treating the |
Yay! That solves a mystery. I couldn't figure out why |
@edemaine could you post diff images between the new render and the LaTeX rendering? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad that this didn't change much and ended up improving things a bit in the places it did change.
I posted it on #1080 where you can compare to the old diff. I'm afraid it's not much better... but hopefully a step in the right direction. |
* Line breaks for inline formulas * Basic support for \allowbreak and \nobreak * Fix spacing around \nobreak, and add documentation * Backwards-compatibility _getBuilt to fix tests * Put operator spacing on same line as operator * One approach to ~ * Simplify \allowbreak/\nobreak, make ~/\nobreakspace prevent line breaks * Adapt to #1295 * Prevent wrapping within a .base * Implement \hspace* properly * Fix flow error * Update comment for regularSpace * Update screenshots * Move `width: min-content` from .katex into .base * Fix screenshot * Add min-width rule to .vlist-s * Factor out hasClass method * Cleanup nobreak test * Pull out buildHTMLUnbreakable * Fix \hspace* test (no longer the same as \hspace) * Fix \nobreak handling * Add screenshot test
Fix #1289
I haven't run screenshot tests yet; I'm curious to see whether this messes with anything.