Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple animation names #167

Merged
merged 1 commit into from Nov 8, 2016

Conversation

@joshwcomeau
Copy link
Contributor

joshwcomeau commented Nov 6, 2016

  • Updated the animationName handler to accept arrays of animation
    names
  • Added an example showcasing two asynchronous animations
  • Updated documentation to include info about single and multiple
    animations.
  • closes #78
* Updated the `animationName` handler to accept arrays of animation
  names
* Added an example showcasing two asynchronous animations
* Updated documentation to include info about single and multiple
  animations.
@khanbot

This comment has been minimized.

Copy link

khanbot commented Nov 6, 2016

Hey @joshwcomeau,

Thanks for the PR! Mind signing our Contributor License Agreement?

When you've done so, go ahead and comment [clabot:check] and I'll check again.

Yours truly,
khanbot

@joshwcomeau

This comment has been minimized.

Copy link
Contributor Author

joshwcomeau commented Nov 6, 2016

[clabot:check]

@khanbot

This comment has been minimized.

Copy link

khanbot commented Nov 6, 2016

CLA signature looks good 👍

@xymostech

This comment has been minimized.

Copy link
Contributor

xymostech commented Nov 7, 2016

This all looks great to me! I'll let @jlfwong give it a look before we merge.

@jlfwong

This comment has been minimized.

Copy link
Collaborator

jlfwong commented Nov 7, 2016

LGTM! Thanks @joshwcomeau! Implementation simple and clean, with docs + tests ❤️

@xymostech Can you merge and push a new minor release to npm?

@xymostech xymostech merged commit bff20d6 into Khan:master Nov 8, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xymostech

This comment has been minimized.

Copy link
Contributor

xymostech commented Nov 8, 2016

@jlfwong done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.