From 2924ebb9223c135009475c495208cd5abf80e059 Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Thu, 28 May 2015 09:10:32 +1000
Subject: [PATCH] Send arcanist error output to STDERR

Summary: Currently, arcanist error output is sent to `STDOUT` instead of `STDOUT`. This is annoying because I am running `arc lint --everything --never-apply-patches --output=xml > checkstyle.xml` and the `checkstyle.xml` file is not valid XML.

Test Plan: Forced a linter to throw an exception and ran `arc lint >/dev/null`... saw error output.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D13043
---
 scripts/arcanist.php | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/scripts/arcanist.php b/scripts/arcanist.php
index ca557f57f..ff0875f72 100755
--- a/scripts/arcanist.php
+++ b/scripts/arcanist.php
@@ -394,10 +394,10 @@
 } catch (Exception $ex) {
   $is_usage = ($ex instanceof ArcanistUsageException);
   if ($is_usage) {
-    echo phutil_console_format(
+    fwrite(STDERR, phutil_console_format(
       "**%s** %s\n",
       pht('Usage Exception:'),
-      $ex->getMessage());
+      $ex->getMessage()));
   }
 
   if ($config) {
@@ -405,15 +405,15 @@
   }
 
   if ($config_trace_mode) {
-    echo "\n";
+    fwrite(STDERR, "\n");
     throw $ex;
   }
 
   if (!$is_usage) {
-    echo phutil_console_format("**%s**\n", pht('Exception'));
+    fwrite(STDERR, phutil_console_format("**%s**\n", pht('Exception')));
 
     while ($ex) {
-      echo $ex->getMessage()."\n";
+      fwrite(STDERR, $ex->getMessage()."\n");
 
       if ($ex instanceof PhutilProxyException) {
         $ex = $ex->getPreviousException();
@@ -422,9 +422,9 @@
       }
     }
 
-    echo phutil_console_format(
+    echo fwrite(STDERR, phutil_console_format(
       "(%s)\n",
-      pht('Run with `%s` for a full exception trace.', '--trace'));
+      pht('Run with `%s` for a full exception trace.', '--trace')));
   }
 
   exit(1);