Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: master
Commits on Mar 25, 2015
  1. @csilvers
Commits on Mar 23, 2015
  1. @joshuaspence

    Add a linter rule for unnecessary use of the `final` modifier

    joshuaspence authored
    Summary: Ref T7409. This was based on rhttps://github.com/squizlabs/PHP_CodeSniffer/blob/master/CodeSniffer/Standards/Generic/Sniffs/CodeAnalysis/UnnecessaryFinalModifierSniff.php.
    
    Test Plan: Added unit tests.
    
    Reviewers: epriestley, #blessed_reviewers
    
    Reviewed By: epriestley, #blessed_reviewers
    
    Subscribers: Korvin, epriestley
    
    Maniphest Tasks: T7409
    
    Differential Revision: https://secure.phabricator.com/D12135
  2. @csilvers
  3. @joshuaspence

    Fix a few edge cases for call-time pass-by-reference linting

    joshuaspence authored
    Summary: Fix a few false positives.
    
    Test Plan: Added test cases.
    
    Reviewers: epriestley, #blessed_reviewers
    
    Reviewed By: epriestley, #blessed_reviewers
    
    Subscribers: Korvin, epriestley
    
    Differential Revision: https://secure.phabricator.com/D12134
Commits on Mar 19, 2015
  1. @csilvers
  2. @epriestley

    Fix chunk upload fallback behavior

    epriestley authored
    Summary:
    Ref T7594. Currently, if a chunk upload fails, we incorrectly swallow the failure and fall back to single-file upload, which will often fail by hitting size limits. This also silences the original error.
    
    Instead, do chunk uploads outside the block so that any exceptions escape, and we don't try to fall back to single-file upload.
    
    Mostly just trying to get more info about what's going wrong on @joshuaspence's install.
    
    Test Plan: Faked an exception in chunk upload, ran `arc upload` on a big file, saw the exception displayed on the console.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley, joshuaspence
    
    Maniphest Tasks: T7594
    
    Differential Revision: https://secure.phabricator.com/D12111
Commits on Mar 16, 2015
  1. @csilvers
Commits on Mar 15, 2015
  1. @epriestley

    Explicitly draw progress bar when resuming file uploads in `arc upload`

    epriestley authored
    Summary: Ref T7149. Make sure we sit at "Resuming: 60%" or whatever while uploading the first chunk.
    
    Test Plan: Ran `arc upload` on a large file, cancelled it, resumed it, got sensible progress bar.
    
    Reviewers: chad, btrahan
    
    Reviewed By: chad, btrahan
    
    Subscribers: epriestley
    
    Maniphest Tasks: T7149
    
    Differential Revision: https://secure.phabricator.com/D12082
  2. @epriestley

    Remove "force chunking" code from Arcanist

    epriestley authored
    Summary: Ref T7149. This was just for testing and is no longer required.
    
    Test Plan: `grep`
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Maniphest Tasks: T7149
    
    Differential Revision: https://secure.phabricator.com/D12077
Commits on Mar 13, 2015
  1. @epriestley

    Make "arc upload" chunk-aware

    epriestley authored
    Summary: Ref T7149. This makes the client try to use the new `file.allocate` API before falling back to the old stuff.
    
    Test Plan: Used `arc upload` to upload files. With chunking forced, uploaded chunked files.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: joshuaspence, epriestley
    
    Maniphest Tasks: T7149
    
    Differential Revision: https://secure.phabricator.com/D12061
  2. @csilvers
Commits on Mar 12, 2015
  1. @Yomi0 @epriestley

    Add a space in the translation when a error message is printed.

    Yomi0 authored epriestley committed
    Summary: Change 'themto' to 'them to'.
    
    Test Plan: Check message printed...
    
    Reviewers: #blessed_reviewers, epriestley
    
    Reviewed By: #blessed_reviewers, epriestley
    
    Subscribers: Korvin, epriestley
    
    Differential Revision: https://secure.phabricator.com/D12057
Commits on Mar 9, 2015
  1. @csilvers
Commits on Mar 6, 2015
  1. @nevogd @epriestley

    Add untracked files to commit using prompt

    nevogd authored epriestley committed
    Summary:
    Refs D11990. When using `arc diff` with untracked files in the working
    copy, add the untracked file(s) to the commit (as they weren't stashed or
    ignored). Add the untracked paths to the list of changes in the editor
    template, indicating that the files were added to the commit.
    
    This doesn't add a separate prompt to add untracked files as per the
    behaviour prior to D11843.
    
    Test Plan:
    Ran `arc diff` with only untracked files, answered yes to the 'create
    new commit' prompt. Saw the commit-message with the updated changes
    including untracked files. Completed the arc template, and got commit
    containing uncommitted, unstaged and untracked files.
    
    Reviewers: epriestley, #blessed_reviewers
    
    Reviewed By: epriestley, #blessed_reviewers
    
    Subscribers: Korvin, epriestley
    
    Differential Revision: https://secure.phabricator.com/D11995
Commits on Mar 5, 2015
  1. @epriestley

    Check for untracked files in order to fire untracked file prompt

    epriestley authored
    Summary: Fixes T7465. I think I just missed this when untangling the old logic.
    
    Test Plan: Ran `arc diff` with //only// untrakced files, saw warning.
    
    Reviewers: btrahan, chad
    
    Reviewed By: chad
    
    Subscribers: epriestley
    
    Maniphest Tasks: T7465
    
    Differential Revision: https://secure.phabricator.com/D11990
Commits on Mar 2, 2015
  1. @csilvers
  2. @epriestley

    Fix a newline issue in "arc" workflows

    epriestley authored
    Summary:
    We end up with one too few newline here in some workflows, like `arc land` with unstaged changes.
    
    Root issue here is that `phutil_console_prompt|confirm` lead with too much whitespace but that's a harder fix.
    
    Test Plan: Saw reasonable whitespace.
    
    Reviewers: btrahan, chad
    
    Reviewed By: chad
    
    Subscribers: epriestley
    
    Differential Revision: https://secure.phabricator.com/D11927
Commits on Feb 26, 2015
  1. @csilvers
Commits on Feb 25, 2015
  1. @epriestley

    Make "arc which --show-base" work as expected

    epriestley authored
    Summary: This is supposed to just print out the base revision, but actually prints out the repository section first.
    
    Test Plan: Ran `arc which`, `arc which --show-base`.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Differential Revision: https://secure.phabricator.com/D11888
Commits on Feb 23, 2015
  1. @csilvers
Commits on Feb 21, 2015
  1. @epriestley

    Use $EDITOR to prompt users when creating a new commit out of dirty w…

    epriestley authored
    …orking copy changes
    
    Summary:
    Fixes T7344.
    Currently, we use `phutil_console_prompt()`, which isn't a very good editor. Use the real $EDITOR instead.
    
    100% of the logic here was also a gigantic mess. Clean it up.
    
    Test Plan: Will update in a second with console output from this run.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Maniphest Tasks: T7344
    
    Differential Revision: https://secure.phabricator.com/D11843
Commits on Feb 17, 2015
  1. @csilvers
Commits on Feb 11, 2015
  1. @epriestley

    Update arcanist to work with more modular translations

    epriestley authored
    Summary:
    Ref T7152. Ref T1139.
    
      - Tweak API.
      - Move translations out of __init__ file.
    
    Test Plan:
      - Ran `arc`.
      - Added a goofy translation and made sure it was working.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    Subscribers: epriestley
    
    Maniphest Tasks: T7152, T1139
    
    Differential Revision: https://secure.phabricator.com/D11746
  2. @joshuaspence

    Fix `xsprintf` callback

    joshuaspence authored
    Summary: After all that, I forgot to change this back.
    
    Test Plan: Eyeball it.
    
    Reviewers: epriestley, #blessed_reviewers
    
    Reviewed By: epriestley, #blessed_reviewers
    
    Subscribers: Korvin, epriestley
    
    Differential Revision: https://secure.phabricator.com/D11735
Commits on Feb 10, 2015
  1. @cburroughs @epriestley

    losen pep8 version check

    cburroughs authored epriestley committed
    Summary:
    pep8 has used both 2 (`1.2`) and 3 (`1.2.1`) digit versions.  Losen
    the version check to allow for both.
    
    NOTE: This is the same regex as flake8.
    
    Test Plan: `arc unit` with a 2 and 3 digit pep8 version on `$PATH`.
    
    Reviewers: #blessed_reviewers, epriestley
    
    Reviewed By: #blessed_reviewers, epriestley
    
    Subscribers: joshuaspence, epriestley
    
    Differential Revision: https://secure.phabricator.com/D11728
  2. @joshuaspence

    Fix `pht` method calls

    joshuaspence authored
    Summary: Ref T7046. This is mainly a proof-of-concept for D11661.
    
    Test Plan: `arc lint`
    
    Reviewers: epriestley, #blessed_reviewers
    
    Reviewed By: epriestley, #blessed_reviewers
    
    Subscribers: Korvin, epriestley
    
    Maniphest Tasks: T7046
    
    Differential Revision: https://secure.phabricator.com/D11683
  3. @joshuaspence

    Add a linter rule to detect mismatched parameters for formatted strings

    joshuaspence authored
    Summary: Fixes T7046. Adds a linter rule to detect mismatched parameters for formatted strings. Originally I had considered putting this rule in `ArcanistPhutilXHPASTLinter`, but I later decided to move it to `ArcanistXHPASTLinter` as I think that it is general enough to be more widely useful.
    
    Test Plan: This seems to work but needs some polish.
    
    Reviewers: epriestley, #blessed_reviewers
    
    Reviewed By: epriestley, #blessed_reviewers
    
    Subscribers: Korvin, epriestley
    
    Maniphest Tasks: T7046
    
    Differential Revision: https://secure.phabricator.com/D11661
Commits on Feb 9, 2015
  1. @joshuaspence

    Rename `ComprehensiveLintEngine` class for consistency

    joshuaspence authored
    Summary: Ref T5655.
    
    Test Plan: Ran `arc lint` with `lint.engine` set to `ComprehensiveLintEngine` and saw a deprecation notice.
    
    Reviewers: epriestley, #blessed_reviewers
    
    Reviewed By: epriestley, #blessed_reviewers
    
    Subscribers: epriestley
    
    Maniphest Tasks: T5655
    
    Differential Revision: https://secure.phabricator.com/D11673
  2. @joshuaspence

    Rename `ArcanistCompilerLikeLintRenderer`

    joshuaspence authored
    Summary: Ref T5655. "Compiler-like" seems a bit odd to me.
    
    Test Plan: `arc lint` + `arc unit`
    
    Reviewers: #blessed_reviewers, epriestley
    
    Reviewed By: #blessed_reviewers, epriestley
    
    Subscribers: Korvin, epriestley
    
    Maniphest Tasks: T5655
    
    Differential Revision: https://secure.phabricator.com/D11670
  3. @joshuaspence

    Remove deprecated support for specifying flags as a string

    joshuaspence authored
    Summary: It should be safe to remove this now.
    
    Test Plan: `arc unit`
    
    Reviewers: #blessed_reviewers, epriestley
    
    Reviewed By: #blessed_reviewers, epriestley
    
    Subscribers: Korvin, epriestley
    
    Differential Revision: https://secure.phabricator.com/D11714
  4. @joshuaspence

    Rename `ArcanistXHPASTLintTestSwitchHook` class

    joshuaspence authored
    Summary: Ref T5655.
    
    Test Plan: N/A
    
    Reviewers: epriestley, #blessed_reviewers
    
    Reviewed By: epriestley, #blessed_reviewers
    
    Subscribers: Korvin, epriestley
    
    Maniphest Tasks: T5655
    
    Differential Revision: https://secure.phabricator.com/D11712
  5. @joshuaspence

    Change a method name

    joshuaspence authored
    Summary: Ref T5655.
    
    Test Plan: `arc unit`
    
    Reviewers: epriestley, #blessed_reviewers
    
    Reviewed By: epriestley, #blessed_reviewers
    
    Subscribers: Korvin, epriestley
    
    Maniphest Tasks: T5655
    
    Differential Revision: https://secure.phabricator.com/D11713
Commits on Feb 4, 2015
  1. @joshuaspence

    `pht`ize some strings in `ArcanistPhutilTestCaseTestCase`

    joshuaspence authored
    Summary: Self-explanatory.
    
    Test Plan: Eyeball it.
    
    Reviewers: epriestley, #blessed_reviewers
    
    Reviewed By: epriestley, #blessed_reviewers
    
    Subscribers: Korvin, epriestley
    
    Differential Revision: https://secure.phabricator.com/D11671
  2. @joshuaspence

    Remove the `ArcanistArcanistLinterTestCase`

    joshuaspence authored
    Summary: I don't think that this provides too much value. I think that we should rework this to be inferred from the `.arcconfig` file perhaps?
    
    Test Plan: `arc unit`
    
    Reviewers: epriestley, #blessed_reviewers
    
    Reviewed By: epriestley, #blessed_reviewers
    
    Subscribers: Korvin, epriestley
    
    Differential Revision: https://secure.phabricator.com/D11662
  3. @csilvers
Something went wrong with that request. Please try again.