Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fix log-trimming bug, updated readme.md

  • Loading branch information...
commit 9d78be1348196b06a1f5163b3f2048a4a403c688 1 parent 7993af7
@MattFaus MattFaus authored
Showing with 10 additions and 3 deletions.
  1. +1 −1  notify.py
  2. +9 −2 readme.md
View
2  notify.py
@@ -118,6 +118,6 @@ def build_message(last_version, version):
# "stuck", so we can clear the log and detect an inadvertant flip.
if ((checks_since_new_version_found * seconds_between_checks) / 60
> minutes_for_new_version_to_stick):
- version_log = version_log[-1]
+ version_log = version_log[-1:]
time.sleep(seconds_between_checks)
View
11 readme.md
@@ -1,4 +1,4 @@
-This runs as a process on our Continuous Integration server. Every 10 seconds it will check the version returned by http://www.khanacademy.org/api/v1/dev/version and send a notification to HipChat if it has changed since the last check.
+This runs as a process on our Continuous Integration server (codename toby). Every 10 seconds it will check the version returned by http://www.khanacademy.org/api/v1/dev/version and send a notification to HipChat if it has changed since the last check.
Since GAE will serve this URL from different instances for about an hour after a new default version is designated, we have added some buffering to alleviate flip-flopping. This behavior is documented at http://stackoverflow.com/questions/15416938/app-engine-version-served-by-default-appears-to-be-inconsistent-and-thrash-for
@@ -7,4 +7,11 @@ This means we cannot detect when an actual rollback to a previous version has oc
You can download the hipchat source here: https://github.com/Khan/python-hipchat
You can install ConfigObj with:
-pip install configobj
+pip install configobj
+
+After modifying this script, the deployment steps are:
+1. ssh toby
+2. Find the current process and kill it with ps aux | grep notify.py and kill
+3. cd gae-default-version-notifier
+4. git pull ??
+5. nohup python ~/gae-default-version-notifier/notify.py &
Please sign in to comment.
Something went wrong with that request. Please try again.