Permalink
Switch branches/tags
Nothing to show
Commits on Apr 14, 2017
  1. Substate alertlib to pull in lint ignores from khan-linter upgrade

    Test Plan:
    `~/khan/devtools/khan-linter/runlint.py .`
    
    Auditors: csilvers
    cjfuller committed Apr 14, 2017
Commits on Jul 6, 2016
  1. Substate for alertlib

    Test plan:
    
    None
    csilvers committed Jul 6, 2016
Commits on Jun 28, 2016
  1. Substate for alertlib

    Test plan:
    
    None
    csilvers committed Jun 28, 2016
Commits on Dec 3, 2015
  1. Check the version of the default module

    Summary:
    By default, `/api/internal/dev/` gets routed to frontend-highmem because it
    contains a lot of slow and memory-intensive routes.  Now we'll explicitly check
    the default module.
    
    Test Plan:
    Deploy it, then watch timestamps on a few deploys to see that it matches when
    default flipped, rather than frontend-highmem.
    
    Reviewers: mroth, csilvers
    
    Reviewed By: csilvers
    
    Differential Revision: https://phabricator.khanacademy.org/D23755
    benjaminjkraft committed Dec 3, 2015
Commits on Oct 23, 2015
  1. remove short notices for 1s-and-0s slack channel

    Summary:
    based upon 1mo. poll results:
    https://khanacademy.slack.com/archives/1s-and-0s/p1445548043000845
    
    Test Plan: N/A
    
    Reviewers: benjaminpollack, benkraft, csilvers
    
    Reviewed By: csilvers
    
    Subscribers: csilvers
    
    Differential Revision: https://phabricator.khanacademy.org/D22673
    mroth committed Oct 23, 2015
Commits on Oct 13, 2015
Commits on Sep 22, 2015
  1. Delete all references to HipChat

    Test Plan: None
    
    Reviewers: mroth, benkraft
    
    Reviewed By: benkraft
    
    Differential Revision: https://phabricator.khanacademy.org/D21875
    bpollack committed Sep 22, 2015
Commits on Sep 2, 2015
  1. minor formatting improvements

    Summary: add app-engine emoji, and use a unicode arrow in short message
    
    Test Plan: YOLO.
    
    Reviewers: benkraft, benjaminpollack
    
    Reviewed By: benjaminpollack
    
    Differential Revision: https://phabricator.khanacademy.org/D21282
    mroth committed Sep 2, 2015
Commits on Aug 17, 2015
  1. activate slack support for notifier

    Summary:
    - update alertlib submodule to slack version
    
    see above
    
    - add slack support
    
    resisting the temptation to change too much, for now just threw the
    existing hipchat integration into a subclass, and made another one for
    slack posting with more sane formatting.
    
    NOTE: when updated on toby, the manual checkout of secrets.py will have to be updated!
    
    Test Plan: Tested manually on local machine with overriding Hipchat room names
    
    Reviewers: ethan, benjaminpollack
    
    Reviewed By: ethan, benjaminpollack
    
    Differential Revision: https://phabricator.khanacademy.org/D20577
    mroth committed Aug 17, 2015
Commits on Jul 29, 2015
  1. Add default .arcconfig/.arclint file

    Summary: as per https://phabricator.khanacademy.org/D18088
    and the existence of ka-clone, we now add .arclint/.arcconfig
    files to all repos by default making linting opt-out.
    
    this adds both files to this repo which makes it so that all
    our non-forked repositories all have arclint setup.
    
    if you feel that this is no longer necessary or if this repo's
    linting needs have changed, please feel free to update the
    arclint/arcconfig pair or remove them altogether.
    
    Test Plan: tested on thumbnail-sketches repo
    
    Auditors: csilvers, mroth
    nsfmc committed Jul 29, 2015
Commits on Oct 23, 2014
  1. Change /api/v1 to /api/internal in gae-default-version-notifier

    Test Plan: Fingers crossed.
    
    Reviewers: csilvers
    
    Reviewed By: csilvers
    
    Differential Revision: http://phabricator.khanacademy.org/D14064
    Alan Pierce committed Oct 22, 2014
Commits on Jul 30, 2014
  1. Change the hipchat message that goes to 1s and 0s to be short.

    Summary:
    This is by request -- the deploy message in 1s and 0s just needs to be
    a 'this happened' kind of thing, and doesn't need all the details; you
    can get those in '1s/0s: deploy' if need be.
    
    Test Plan:
    Manually ran
       env PYTHONPATH=$HOME/khan/webapp/third_party:$HOME/khan/webapp python notify.py
    and saw it say:
    
       App Engine default version just changed: None → 0730-1146-bb604a073a1e
    
    in '1s and 0s', while in '1s/0s: deploys' it still says:
    
       App Engine default version just changed: khanacademy.org, appspot dashboard, app versions
       • old: None (error logs, instances)
       • new: 0730-1146-bb604a073a1e (error logs, instances)
    
    Reviewers: alpert
    
    Reviewed By: alpert
    
    Differential Revision: http://phabricator.khanacademy.org/D11771
    csilvers committed Jul 30, 2014
Commits on Jul 23, 2014
  1. Use alertlib (now a submodule) to send to hipchat.

    Summary:
    With this change, a lot of the files in this repo can go away.
    The readme got a lot simpler as well.
    
    Update .gitmodules to get rid of the unneeded python-hipchat submodule.
    
    I though that my 'git rm' would do that, but maybe I was using an old
    version of git?
    
    Test Plan:
    Ran
       env PYTHONPATH=alertlib:$HOME/khan/webapp python ./notify.py
    and saw it send this to both 1s and 0s and 1s/0s: deploys:
    
    Mr Gorilla
    10:10 PM
    Restarting notify.py!
    Mr Gorilla
    10:10 PM
    App Engine default version just changed: khanacademy.org, appspot dashboard, app versions
    • old: None (error logs, instances)
    • new: 0722-1740-ed533ed268fd (error logs, instances)
    
    Fingers crossed.
    
    Reviewers: alpert
    
    Reviewed By: alpert
    
    Subscribers: chris
    
    Differential Revision: http://phabricator.khanacademy.org/D11439
    csilvers committed Jul 23, 2014
Commits on Mar 15, 2013
  1. Merge pull request #1 from MattFaus/master

    Expand Mr Gorilla's short-term memory
    csilvers committed Mar 15, 2013
  2. Adding a version_log to track versions we have previously seen.

    This should alleviate HipChat spamming when versions flip-flop
    after changing the default version.
    MattFaus committed Mar 15, 2013
Commits on Feb 5, 2013
  1. I verified that the hipchat.py on toby can use room names, so do that.

    Summary:
    It's much easier to read (and figure out) than room numbers!
    
    Publish to hipchat every time this script restarts.
    
    If it's all the time, we want to know.  We also want to know, when
    restarting the script, that it can actually successfully speak to
    hipchat.
    
    Test Plan:
    Manually ran the hipchat function in notify.py, with the room_id as
    '1s and 0s'.
    
    None yet.  But once this is installed, I'll restart notify.py manually
    on toby.
    
    Reviewers: alpert
    
    Reviewed By: alpert
    
    Differential Revision: http://phabricator.khanacademy.org/D2003
    csilvers committed Feb 1, 2013
Commits on Feb 1, 2013
  1. I verified that the hipchat.py on toby can use room names, so do that.

    It's much easier to read (and figure out) than room numbers!
    
    Test plan:
    Manually ran the hipchat function in notify.py, with the room_id as
    '1s and 0s'.
    csilvers committed Feb 1, 2013
Commits on Sep 7, 2012
  1. Catch socket errors as well

    spicyj committed Sep 7, 2012
Commits on Jul 10, 2012
  1. Be safer about 'finally' here

    spicyj committed Jul 10, 2012
Commits on Jul 9, 2012
  1. A few more fixes

    spicyj committed Jul 9, 2012
  2. Add comments

    spicyj committed Jul 9, 2012
Commits on Jul 8, 2012
  1. Initial commit

    spicyj committed Jul 8, 2012