Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Get rid of out-of-date comment about appstats locking

  • Loading branch information...
commit ae58f07ae617b403707a09b66c7c566c4cb85d0a 1 parent e2127f2
@kamens kamens authored
Showing with 3 additions and 11 deletions.
  1. +3 −11 appstats_profiler.py
View
14 appstats_profiler.py
@@ -26,17 +26,9 @@ def __init__(self):
def results(self):
"""Return appstats results in a dictionary for template context."""
if not self.recorder:
- # Appstats may not always be initialized when we want it to be due
- # to its own internal memcache locking. It won't run more than one
- # appstats profiling request at a time, across all GAE instances.
- # This means we may've failed to record appstats results for this
- # request because a different instance handling a different request
- # already has the global appstats lock.
- #
- # In this case, we simply return an empty set of appstats results
- # so the profiler's client still functions.
- #
- # TODO(kamens): fix or make this error case more clear to user.
+ # If appstats fails to initialize for any reason, return an empty
+ # set of results.
+ logging.warn("Missing recorder for appstats profiler.")
return {
"calls": [],
"total_time": 0,
Please sign in to comment.
Something went wrong with that request. Please try again.