Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

Author names stored incorrectly #36

Open
petercollingridge opened this issue Nov 3, 2012 · 10 comments
Open

Author names stored incorrectly #36

petercollingridge opened this issue Nov 3, 2012 · 10 comments

Comments

@petercollingridge
Copy link

The value for the key 'authors' in video objects is generally a list of strings of individual names, however there are 7 cases in which there is a single string "Beth Harris,Steven Zucker", as opposed to two strings.

Rishi is sometimes referred to "Rishi" and sometimes "Rishi Desai".
Karl Wendt is sometimes stored with a space after his name, sometimes not.

@sophiebits
Copy link
Contributor

Thanks for letting us know about this.

@stchangg?

@tomyedwab
Copy link
Member

I don't think there is anything wrong with the code, there is just a lot of inconsistency with the data that someone will have to go back and correct. I believe Marcia's new UI will help to fix this going forward.

@sophiebits
Copy link
Contributor

Would be nice if the field stored and encouraged you to use existing values.

@stephjang
Copy link

Thanks Tom & Ben. Yes this is the case. I added the author_names field just as a quick and simple fix to add the Google+ author links, and didn't make the input fancy (the data type is simply an array of strings) since Marcia was going to overhaul the content editing tool. We can retroactively fix some of this data inconsistency through backfills later.

@marcia
Copy link

marcia commented Nov 5, 2012

aloha @petercollingridge! if you'd like to send me those 7 cases, i'll update them to be consistent. the new-ish (and still being iterated upon) interface for editing videos/exercises will prevent these author name inconsistencies in the future. https://s3.amazonaws.com/uploads.hipchat.com/6574/17223/utgk2kki7s66nmv/upload.png

thanks for all that you do!
marcia

@petercollingridge
Copy link
Author

What information do you need? I'm calling: /api/v1/playlists/library/list

The titles of the videos are:
"Ancient Greek Temples at Paestum, Italy"
"Ara Pacis" x 2
"Pair of Centaurs Fighting Cats of Prey from Hadrian's Villa"
"Exekias, Attic black figure amphora with Ajax and Achilles playing a game"
"Giorgione's The Adoration of the Shepherds"
"Institutional Critique: Hans Haacke's Seurat's 'Les Poseuses' (small version)"

Thanks for that. I really wasn't a big problem, I just noticed they were inconsistent. The new interface looks very nice.

Peter

@tzjames
Copy link

tzjames commented Nov 5, 2012

Hi Marcia,

I happened to be logged in to devshell. The full list is 36 items long:
[Video(readable_id=u'membrane-potentials---part-1',
youtube_id=u'PtKAeihnbv0'),
Video(readable_id=u'bit-zee classroom', youtube_id=u'CcziDRr5Myc'),
Video(readable_id=u'permeability-and-membrane-potentials',
youtube_id=u'920PtNX-WCE'),
Video(readable_id=u'action-potentials-in-pacemaker-cells',
youtube_id=u'OQpFFiLdE0E'),
Video(readable_id=u'membrane-potentials---part-2',
youtube_id=u'eROhIFBGKuU'),
Video(readable_id=u'electrical-system-of-the-heart',
youtube_id=u'7K2icszdxQc'),
Video(readable_id=u'Compare-motors', youtube_id=u'V7P2dnrWDeQ'),
Video(readable_id=u'meet-the-heart', youtube_id=u'Vi1JK6IYVt8'),
Video(readable_id=u'depolarization-waves-flowing-through-the-heart',
youtube_id=u's5smas8uum4'),
Video(readable_id=u'flow-through-the-heart',
youtube_id=u'7XaftdE_h60'),
Video(readable_id=u'layers-of-the-heart', youtube_id=u'bm65xCS5ivo'),
Video(readable_id=u'Bit-zee goes to school',
youtube_id=u'KmmFBC0gNSg'),
Video(readable_id=u'what-is-inside-a-tap-light',
youtube_id=u'qLMsZKx_a8s'),
Video(readable_id=u'build-a-motor-controller-for-your-bit-zee-bot',
youtube_id=u'T4iRq8_ZmAA'),
Video(readable_id=u'a-race-to-keep-pace', youtube_id=u'_yR9DBHMFXE'),
Video(readable_id=u'Fun with Bit-zee', youtube_id=u'8-wOsRyIoe8'),
Video(readable_id=u'changing-the-av-node-delay---chronotropic-effect',
youtube_id=u'cmQtbpYihAI'),

Video(readable_id=u'increasing-ventricular-contractility---inotropic-effect',
youtube_id=u'0eu-3FIRRz8'),
Video(readable_id=u'new-perspective-on-the-heart',
youtube_id=u'8zrJxuVW3u4'),
Video(readable_id=u'changing-the-heart-rate---chronotropic-effect',
youtube_id=u'3HvIKsQb6es'),
Video(readable_id=u'reseting-cardiac-concentration-gradients',
youtube_id=u'j2iY1cT2gEE'),
Video(readable_id=u'build-your-own-motor', youtube_id=u'jabo8iTesqQ'),
Video(readable_id=u'thinking-about-heartbeats',
youtube_id=u'7TafYJLjhY4'),
Video(readable_id=u'getting-a-new-heart', youtube_id=u'dqmaxkxInZ4'),

Video(readable_id=u'adding-a-coach-and-creating-class-lists-on-khan-academy',
youtube_id=u'G5jy7iE7d0o'),

Video(readable_id=u'creating-khan-academy-accounts-for-users-under-age-13',
youtube_id=u'gzTLyxSi1vM'),
Video(readable_id=u'how-to-delete-a-student-or-class-list',
youtube_id=u'0dLNOCMRkGk'),

Video(readable_id=u'institutional-critique--hans-haacke-s-seurat-s--les-poseuses---small-version---1884-1975--1975',
youtube_id=u'sdM6aGhKdTI'),

Video(readable_id=u'giorgione--the-adoration-of-the-shepherds--1505-10',
youtube_id=u'M0Nf2Osgwkc'),
Video(readable_id=u'creating-khan-academy-accounts-for-users-ages-13',
youtube_id=u'qot5e1jMBRs'),
Video(readable_id=u'how-to-add-a-coach-on-khan-academy',
youtube_id=u'TFOAaIg-B3c'),

Video(readable_id=u'pair-of-centaurs-fighting-cats-of-prey-from-hadrian-s-villa--c--130-b-c-e-1',
youtube_id=u'L5OkFR8GScU'),

Video(readable_id=u'exekias--attic-black-figure-amphora-with-ajax-and-achilles-playing-a-game',
youtube_id=u'k2fdtepbkz8'),

Video(readable_id=u'ara-pacis-augustae--altar-of-augustan-peace---13-9-b-c-e---rome',
youtube_id=u'kiMNT18c4Ko'),
Video(readable_id=u'ancient-greek-temples-at-paestum',
youtube_id=u'_tNnI_w6TTQ'),
Video(readable_id=u'autonomic-nervous-system-effects-on-the-heart',
youtube_id=u'KiouveG278Y')]

On Mon, Nov 5, 2012 at 1:23 PM, Marcia Lee notifications@github.com wrote:

aloha @petercollingridge https://github.com/petercollingridge! if you'd
like to send me those 7 cases, i'll update them to be consistent. the
new-ish (and still being iterated upon) interface for editing
videos/exercises will prevent these author name inconsistencies in the
future.
https://s3.amazonaws.com/uploads.hipchat.com/6574/17223/utgk2kki7s66nmv/upload.png

thanks for all that you do!
marcia


Reply to this email directly or view it on GitHubhttps://github.com//issues/36#issuecomment-10088521.

@marcia
Copy link

marcia commented Nov 5, 2012

whoazers! i'll take a look tomorrow and let you all know when the issue's
been resolved. thanks friends.

On Mon, Nov 5, 2012 at 2:14 PM, tzjames notifications@github.com wrote:

Hi Marcia,

I happened to be logged in to devshell. The full list is 36 items long:
[Video(readable_id=u'membrane-potentials---part-1',
youtube_id=u'PtKAeihnbv0'),
Video(readable_id=u'bit-zee classroom', youtube_id=u'CcziDRr5Myc'),
Video(readable_id=u'permeability-and-membrane-potentials',
youtube_id=u'920PtNX-WCE'),
Video(readable_id=u'action-potentials-in-pacemaker-cells',
youtube_id=u'OQpFFiLdE0E'),
Video(readable_id=u'membrane-potentials---part-2',
youtube_id=u'eROhIFBGKuU'),
Video(readable_id=u'electrical-system-of-the-heart',
youtube_id=u'7K2icszdxQc'),
Video(readable_id=u'Compare-motors', youtube_id=u'V7P2dnrWDeQ'),
Video(readable_id=u'meet-the-heart', youtube_id=u'Vi1JK6IYVt8'),
Video(readable_id=u'depolarization-waves-flowing-through-the-heart',
youtube_id=u's5smas8uum4'),
Video(readable_id=u'flow-through-the-heart',
youtube_id=u'7XaftdE_h60'),
Video(readable_id=u'layers-of-the-heart', youtube_id=u'bm65xCS5ivo'),
Video(readable_id=u'Bit-zee goes to school',
youtube_id=u'KmmFBC0gNSg'),
Video(readable_id=u'what-is-inside-a-tap-light',
youtube_id=u'qLMsZKx_a8s'),
Video(readable_id=u'build-a-motor-controller-for-your-bit-zee-bot',
youtube_id=u'T4iRq8_ZmAA'),
Video(readable_id=u'a-race-to-keep-pace', youtube_id=u'_yR9DBHMFXE'),
Video(readable_id=u'Fun with Bit-zee', youtube_id=u'8-wOsRyIoe8'),
Video(readable_id=u'changing-the-av-node-delay---chronotropic-effect',
youtube_id=u'cmQtbpYihAI'),

Video(readable_id=u'increasing-ventricular-contractility---inotropic-effect',

youtube_id=u'0eu-3FIRRz8'),
Video(readable_id=u'new-perspective-on-the-heart',
youtube_id=u'8zrJxuVW3u4'),
Video(readable_id=u'changing-the-heart-rate---chronotropic-effect',
youtube_id=u'3HvIKsQb6es'),
Video(readable_id=u'reseting-cardiac-concentration-gradients',
youtube_id=u'j2iY1cT2gEE'),
Video(readable_id=u'build-your-own-motor', youtube_id=u'jabo8iTesqQ'),
Video(readable_id=u'thinking-about-heartbeats',
youtube_id=u'7TafYJLjhY4'),
Video(readable_id=u'getting-a-new-heart', youtube_id=u'dqmaxkxInZ4'),

Video(readable_id=u'adding-a-coach-and-creating-class-lists-on-khan-academy',

youtube_id=u'G5jy7iE7d0o'),

Video(readable_id=u'creating-khan-academy-accounts-for-users-under-age-13',

youtube_id=u'gzTLyxSi1vM'),
Video(readable_id=u'how-to-delete-a-student-or-class-list',
youtube_id=u'0dLNOCMRkGk'),

Video(readable_id=u'institutional-critique--hans-haacke-s-seurat-s--les-poseuses---small-version---1884-1975--1975',

youtube_id=u'sdM6aGhKdTI'),

Video(readable_id=u'giorgione--the-adoration-of-the-shepherds--1505-10',
youtube_id=u'M0Nf2Osgwkc'),
Video(readable_id=u'creating-khan-academy-accounts-for-users-ages-13',
youtube_id=u'qot5e1jMBRs'),
Video(readable_id=u'how-to-add-a-coach-on-khan-academy',
youtube_id=u'TFOAaIg-B3c'),

Video(readable_id=u'pair-of-centaurs-fighting-cats-of-prey-from-hadrian-s-villa--c--130-b-c-e-1',

youtube_id=u'L5OkFR8GScU'),

Video(readable_id=u'exekias--attic-black-figure-amphora-with-ajax-and-achilles-playing-a-game',

youtube_id=u'k2fdtepbkz8'),

Video(readable_id=u'ara-pacis-augustae--altar-of-augustan-peace---13-9-b-c-e---rome',

youtube_id=u'kiMNT18c4Ko'),
Video(readable_id=u'ancient-greek-temples-at-paestum',
youtube_id=u'_tNnI_w6TTQ'),
Video(readable_id=u'autonomic-nervous-system-effects-on-the-heart',
youtube_id=u'KiouveG278Y')]

On Mon, Nov 5, 2012 at 1:23 PM, Marcia Lee notifications@github.com
wrote:

aloha @petercollingridge https://github.com/petercollingridge! if
you'd
like to send me those 7 cases, i'll update them to be consistent. the
new-ish (and still being iterated upon) interface for editing
videos/exercises will prevent these author name inconsistencies in the
future.

https://s3.amazonaws.com/uploads.hipchat.com/6574/17223/utgk2kki7s66nmv/upload.png

thanks for all that you do!
marcia


Reply to this email directly or view it on GitHub<
https://github.com/Khan/khan-api/issues/36#issuecomment-10088521>.


Reply to this email directly or view it on GitHubhttps://github.com//issues/36#issuecomment-10090520.

@petercollingridge
Copy link
Author

Just curious - the genetics 101 videos (e.g http://www.khanacademy.org/science/biology/heredity-and-genetics/v/genetics-101-part-1--what-are-genes) have Sal as the author and yet they are not narrated by him. Should there be another author for them?

@sophiebits
Copy link
Contributor

@petercollingridge That's definitely a mistake. I've removed Sal as a listed author, so currently there isn't anyone listed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants