Add git prs as an alias for git pull-requests
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khan/our-lovely-cli#530 added a git pull-requests command to OLC. This adds an alias for it that's easier to type. Issue: none Test plan: Run `git prs`. You should see a report of your outstanding pull requests.
benchristel
commented
Sep 21, 2022
| @@ -27,6 +27,7 @@ | |||
| rb = !git review-branch | |||
| pb = !git review-branch ; short for 'phabricator branch' | |||
| pr = !git pull-request | |||
| prs = !git pull-requests | |||
There was a problem hiding this comment.
TIL about the ! prefix for git aliases. https://git-scm.com/book/en/v2/Git-Basics-Git-Aliases
lillialexis
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
Before you land this, I would double-check that this command (and– I'm realizing totally too late– the git pull-requests command) doesn't collide with GitHub's official CLI, gh. That might also have "porcelain" commands pull-requests and prs, and if a user has both installed, one or the other will trample the other. (Based on order in the _PATH_, I believe.
|
Ooh, good call. Looks like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
https://github.com/Khan/our-lovely-cli/pull/530 added a git
pull-requests command to OLC. This adds an alias for it that's easier to
type.
Issue: none
Test plan:
Run
git prs. You should see a report of your outstanding pullrequests.