HTTPS clone URL
Subversion checkout URL
Please sign in to comment.
Fix bug in khan-exercise.js where appropriate modules are not loaded …
…as users navigate to new exercises via tutorial-nav Summary: This fixes two bugs: 1. First, with khan-exercise.js. Essentially, the modules of all loaded exercises, instead of the current exercise, were being used in runModules(), which executes the functions of the form $.fn["module"], $.fn["moduleLoad"], and $.fn["moduleCleanup"]. As a result, the current exercise was compiled using modules for all loaded exercises. This bug had not been found earlier b/c matrix-input is pretty unique right now in visibly modifying the answer area & b/c the matrices tutorial contains both exercises that use and don't use it. This bug was probably slowing down fairly lightweight exercises that were in the same tutorial as heavy exercises (ex: using the word-problems package), since they were running $.fn["word-problemsLoad"] on every newProblem event. 2. Make sure matrix-input events are not attached again when each hint is requested. There is room for improvement for whoever is brave enough to dive into this crazy mess of code. Test Plan: Devappserver: 1. Visit /math/algebra/algebra-matrices/e/scalar_matrix_multiplication 2. Navigate to "matrix dimensions" via tutorial nav 3. Observe that the matrix input braces do not appear in the answer area Exercise land: 1. Visit scalar_matrix_multiplication.html and matrix_dimensions.html 2. Observe that nothing's visibly changed Reviewers: eater Reviewed By: eater CC: marcia, desmond Differential Revision: http://phabricator.khanacademy.org/D938
- Loading branch information...
commit 8a389e547033ca33ee8221ab08fcc05ff5ef61da 1 parent ebfcd74
Stephanie H. Chang authored
Showing with 114 additions and 26 deletions.