Skip to content
This repository

Apr 18, 2014

  1. Marcos Ojeda

    fixes lint error for global oauth var in interface.js

    summary: oauth is defined only for specific projects that include it in the global namespace to perform authenticated calls to the api. In this case, interface.js assumed that webview-bridge was available and was setting the `oauth` object in the global namespace, but this isn't always the case so the linter complained.
    
    test plan: rebuilt ipad app and successfully saw a 200 OK when posting to /attempt
    
    auditors: laura, ben
    authored April 18, 2014
  2. Justin Jaffray

    Add `var` to fraction - fix lint

    Test Plan:
    N/A
    
    Auditors: brianmerlob
    authored April 18, 2014
  3. Brian Merlob

    Change getFormat to getNumericFormat for clarity

    Test Plan: should still work
    
    Auditors: jack
    authored April 17, 2014
  4. Jack Toole

    Merge pull request #161342 from mauk81/html

    fix html
    authored April 18, 2014
  5. maik

    fix html

    authored April 18, 2014

Apr 17, 2014

  1. Laura Savino

    Make sure oauth ajax requests from exercises are going to ka.org

    Summary: We'd tried appending https://ka.org in $.ajax beforeStart, but since that happens after oauth is set up, authentication failed. This adds ka.org to the requested URL if the URL is missing a domain and is trying to access the API (without this change, it defaulted to the window's location protocol, which is file:// in the iOS app).
    
    Test Plan: Logged in & did exercises in the iOS & web apps; progress posted to the server successfully!
    
    Reviewers: mgp, ben
    
    Reviewed By: ben
    
    Subscribers: alpert
    
    Differential Revision: http://phabricator.khanacademy.org/D8321
    authored April 17, 2014
  2. Laura Savino

    Add kaOauthAjax call (so mobile web view can send authenticated reque…

    …sts without cookies)
    
    Summary: The iOS web view doesn't set cookies, so we need to handle authentication via oauth. If the oauth library is included, we'll use that mechanism to make the API request; otherwise, this returns the $.ajax request that was used before.
    
    Test Plan: Do some exercises while logged into the iOS & web apps; advancement works!
    
    Reviewers: mgp, ben
    
    Reviewed By: ben
    
    Subscribers: marcos, alpert
    
    Differential Revision: http://phabricator.khanacademy.org/D8300
    authored April 16, 2014
  3. Laura Savino

    Make sure LocalStore exists before trying to access it for the scratc…

    …hpads
    
    Summary:
    This section assumes a LocalStore is set up, which isn't currently true on the iOS app (and may not be in the future, either).
    
    Checking its existence before accessing it avoids an exception.
    
    Test Plan: Ran khan-exercises in both the iOS and web apps; scratchpads work in the web still, and the iOS app doesn't throw an exception there.
    
    Reviewers: mgp, ben
    
    Reviewed By: mgp, ben
    
    Subscribers: marcos
    
    Differential Revision: http://phabricator.khanacademy.org/D8295
    authored April 16, 2014
  4. Laura Savino

    Use Exercises.getTaskId() function in interface.js to find learning t…

    …ask ID with no learning task
    
    Summary: The iOS web view doesn't have a learningTask on the Exercises object, so couldn't post that parameter back to the server on making an exercise attempt. Since it only needs the taskId, I'm creating a function on the iOS Exercises object that just returns that piece. For now, to make minimal changes to the web app, I'm leaving the current structure in place and just adding this additional path to the data we need to complete the request.
    
    Test Plan: Do some exercises on the iOS app and in the web app and make sure they advance to the next one and handle attempts appropriately.
    
    Reviewers: mgp, ben
    
    Reviewed By: mgp, ben
    
    Differential Revision: http://phabricator.khanacademy.org/D8297
    authored April 16, 2014

Apr 16, 2014

  1. Jascha Sohl-Dickstein

    log subhint usage

    Summary: Added code to log when subhints are clicked on and expanded.  This will be used in the header text intervention experiment to see when users interact with dropdown text.  This will not work without the corresponding webapp checkin, at http://phabricator.khanacademy.org/D6914 .
    
    Test Plan: Ran it on local appserver.
    
    Reviewers: jace, alpert, eliana
    
    Reviewed By: alpert, eliana
    
    Subscribers: alpert, mattfisher, mattfaus
    
    Differential Revision: http://phabricator.khanacademy.org/D6913

Apr 15, 2014

  1. Ben Eater

    Use PRETTY instead of POTATO

    I'm apparently bad at this...
    
    Test Plan: none
    
    Auditors: peter
    authored April 14, 2014
  2. Ben Eater

    Use POTATO instead of BETTER

    BETTER has two sets of letters that repeat :(
    
    Test Plan: /exercises/permutations_and_combinations_2.html?debug&problem=letters&seed=94
    
    Auditors: peter
    authored April 14, 2014

Apr 14, 2014

  1. Brian Merlob

    Deprecating the answer format percentage

    I forgot we were deprecating this.
    
    Test Plan: never used, no need to test
    authored April 14, 2014
  2. Brian Merlob

    Add getFormat(text) - returns format (string) of given text

    It's purposively more inclusive than answer-types' predicate.forms, but more for sake of brevity than necessity. Optimally, I could just tap into answer-types' predicate.forms, go through each one in some order and return the key if it matches. It might also be wise to do it the other way, have several function in KhanUtil for isMixed(text), isInteger(text), isDecimal(text) accounting for commas/spaces/badLeadingZeros, etc. and then having those functions called from inside answer-types.
    
    If you have strong feelings against this, lemme know
    
    Test Plan: Try "1", "1/2", "3/2", "1 1/2", "1 3/2", "1.3", "1,3", "3 1,3.4" (deliberate, if not foolish), "pi", "topic", "topau", "topau%"
    
    Auditors: eater, jack
    authored April 14, 2014
  3. Brian Merlob

    Delete default for toNumericString

    Now pi will turn into 3.1415926..., but NumberInput will (hopefully) soon have a dynamically set format, making this ok.
    
    Test Plan: none
    
    Auditors: jack
    authored April 13, 2014

Apr 11, 2014

  1. Peter Collingridge

    Swap orange for pink

    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D8132
  2. Peter Collingridge

    Make sentence nicer

    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D8133
  3. Peter Collingridge

    Add back missing sentence and tweak colour code

    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D8131
  4. Peter Collingridge

    Remove plusTrim code dealing with leading coefficients

    Summary: Simplify colours
    
    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D8136

Apr 10, 2014

  1. Brian Merlob

    Change default format for toNumericString Test Plan: see that it show…

    …s as decimal Auditors: Jack
    authored April 10, 2014
  2. Peter Collingridge

    Merge pull request #161305 from simonjtyler/FixConstructions1

    New validator for parallel line exercise in constructions_1, fix #155778 #129989 #156728
    Auditor: peter
  3. Peter Collingridge

    Move css to external file and swap pink for orange

    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D8098
  4. Peter Collingridge

    Make hints easier to translate

    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D8096
  5. Peter Collingridge

    Make styling more consistent and improve hints

    Summary:
    Fix hints
    
    More hints improved
    
    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D7973
  6. Peter Collingridge

    Replace BUMMED with BETTER

    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D8099
  7. Ben Eater

    lint

    Test Plan: Update khan-exercises in webapp and run `make lint` from webapp
    
    Auditors: peter
    authored April 09, 2014
  8. Jack Toole

    Fix line drawing again, for reals!

    Summary:
    kmath to the rescue!
    Not the prettiest kmath i have written, but at least it's a bit cleaner and
    works. angleDeg/angleRad functions might be worthy additions to kvector
    
    Test Plan:
    https://ka-perseus-graphie.s3.amazonaws.com/3c21069ce144e46c20c6356dfe1b56d9975418aa.js
    https://ka-perseus-graphie.s3.amazonaws.com/e1360753e207013f565783a24b40f20cfb9e8a7e.js
    
    Auditors: alex
    authored April 09, 2014

Apr 09, 2014

  1. Jack Toole

    Fix line arrow bug

    Summary:
    Fix drawing of line arrows
    
    Test Plan:
    https://ka-perseus-graphie.s3.amazonaws.com/3c21069ce144e46c20c6356dfe1b56d9975418aa.js
    
    Auditors: alex
    authored April 09, 2014
  2. Peter Collingridge

    Remove unnecessary hint

    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D8057
  3. Peter Collingridge

    Avoid accidental correct answer

    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D8056
  4. Peter Collingridge

    Fix divider hint counting (again)

    Test Plan: Try examples of Dividing Decimals 3 and 4, and Division 0.5, 1, 2, 3 and 4.
    
    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D7852
  5. Peter Collingridge

    Allow exact answer to be given when division is by 8

    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D8055
  6. Peter Collingridge

    Accept answers even with floating point errors

    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D8053
  7. Peter Collingridge

    Add parenthesis and i18n

    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D7944
  8. Peter Collingridge

    Change answer type to expression and tweak hints

    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D8011
Something went wrong with that request. Please try again.