Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Mar 4, 2015
  1. Craig Silverstein

    No longer pass 'card' to /attempt and /hint.

    csilvers authored
    Summary:
    This is an unused param, and I already got rid of it on the server
    side.  This gets rid of it on the client side too, saving a few
    bytes.
    
    Test Plan:
    Fingers crossed.  I'll test when I update substate in webapp to bring
    in this commit.
    
    Reviewers: desmond
    
    Subscribers: eater
    
    Differential Revision: https://phabricator.khanacademy.org/D16536
Commits on Mar 3, 2015
  1. Ben Eater

    Fix views_of_a_function answer type in iPad app

    beneater authored
    Summary:
    In the iOS app, we hide the inputs and show MathOutput thingies instead. This
    means that we muck around in the DOM such that each <td> has a <span> and a
    hidden <input> as children rather than just the <input>. The guess extraction
    part of the custom answer type assumed that the <input>s were the only children
    of <td>s. This change explicitly looks for input elements rather than assuming.
    
    This also adds a fix that prevents grading if you don't fill out any answers.
    
    Test Plan:
    iOS
    ===
    1. Update khan-exercises in the iOS app with this change.
    2. Run the iPad app, find the Views of a function exercise.
    3. Answer a question that requires filling out a table, submit and get it right.
    4. Hit "check" on a question that requires filling out a table without entering anything and see that it doesn't grade it.
    
    Local mode
    ===
    1. Load http://exercises.ka.local/exercises/views_of_a_function.html
    2. Answer a question that requires filling out a table, submit and get it right.
    3. Hit "check answer" on a question that requires filling out a table without entering anything and see that it doesn't grade it.
    
    Reviewers: emily
    
    Reviewed By: emily
    
    Differential Revision: https://phabricator.khanacademy.org/D16426
Commits on Mar 2, 2015
  1. Emily Eisenberg

    Upgrade katex in to v0.2.0

    xymostech authored
    Summary: Upgrade katex to the latest version.
    
    Test Plan:
     - Visit an exercise (like [this
       one](http://exercises.ka.local/exercises/adding_decimals_0.5.html))
     - Find some math on the page.
     - See that it's katex-y.
     - See that it has mathml in it (ooh, ahh).
     - See that there are no errors in the console (oh wait there are! oh
       but they're not related to katex...)
    
    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: https://phabricator.khanacademy.org/D16454
Commits on Feb 27, 2015
  1. Marcia Lee

    Close experiment in favor of clues (khan-exercises)

    marcia authored
    Summary:
    Khan-exercises companion to:
    - webapp https://phabricator.khanacademy.org/D16411
    - perseus https://phabricator.khanacademy.org/D16412
    
    See https://app.asana.com/0/2465302980218/24278591617679
    
    When the user answers incorrectly, we will now always show the clue (or rather, "rationale" as it's known to some) for why that answer was incorrect if that content exists. Though the experiment was only for perseus exercises, this khan-ex change is required because both rationales and "hey you, simplify your answer to be more correct" messages share some codes.
    
    Not sure who owns this, so sending to Eater and CC'ing Michelle. Feel free to redirect.
    
    Test Plan:
    Test a perseus exercise with rationales:
    ===
    Visit /exercise/naming-shapes-2, one of the exercises in targeted_clues_exercises.Exercise
    Get the answer wrong
    See that a rationale popped up
    https://s3.amazonaws.com/uploads.hipchat.com/6574/17223/mz1VI41oFSaHfFt/upload.png
    
    See that you can select the right answer and proceed
    
    Test a perseus exercise without rationales:
    ===
    Visit any other exercise, say /e/recognizing-shapes, that doesn't have rationales
    Get some right / wrong and make sure nothing exploded
    
    Test a khan-exercise exercise with a score.message
    ===
    Visit /e/simplifying_fractions
    Enter the correct fraction but unsimplified
    See a message under the check answer button about simplifying
    https://s3.amazonaws.com/uploads.hipchat.com/6574/17223/Cb2RaGudAevpdSj/upload.png
    
    Answer correctly too
    
    Test a khan-exercise exercises without triggering score.message
    ===
    Visit /e/addition_1
    Answer wrong and right successfully
    
    Reviewers: eater
    
    Reviewed By: eater
    
    Subscribers: michelle
    
    Differential Revision: https://phabricator.khanacademy.org/D16413
Commits on Feb 22, 2015
  1. Ben Eater
Commits on Feb 19, 2015
  1. Ben Eater

    Fix dropdown z-index

    beneater authored
    Test Plan:
    Load http://exercises.ka.local/exercises/inequalities_on_a_number_line.html?problem=equation_from_line
    Turn on the scratchpad
    Use the dropdown
    
    Auditors: aria
Commits on Feb 5, 2015
  1. Aria Buckles

    Check Answer: Remove defunct "Try Again" code

    ariabuckles authored
    Summary:
    This code currently doesn't do anything useful.
    We can revisit this in the future if we want to (though
    we all seem to sort of like the current way), but I guess
    for now the code ought to reflect what actually happens ;)
    
    Test Plan:
    Do additon_1 in webapp and see that I can still check answer
    and progress.
    
    Auditors: emily, eater
Commits on Feb 4, 2015
  1. Michael Parker

    Include any error with each apiRequestEnded event

    mgp authored
    Summary:
    Toward fixing
    https://app.asana.com/0/16089597562651/24907729174260/f.
    
    The native side of the iOS app cannot determine whether the underlying
    JS has failed a request. This provides such telemetry.
    
    Test Plan:
    Add a breakpoint in the always method.
    Make a successful attempt. Assert that requestEndedParameters is undefined.
    Go offline. Make a failed attempt. Assert that requestEndedParameters is a JS object.
    
    Reviewers: david, benkomalo, nacho, eater
    
    Reviewed By: nacho, eater
    
    Subscribers: nacho, andy
    
    Differential Revision: https://phabricator.khanacademy.org/D16050
Commits on Feb 2, 2015
  1. Emily Eisenberg

    Add mobile support for the primeFactorization answer type

    xymostech authored
    Summary:
    Add a class to the input that is produced so that mobile can
    tell that the input should use the expression widget. Also, add some
    more filtering of the guess to handle the LaTeX that it recieves from
    MyScript.
    
    Test Plan:
     - Apply the corresponding mobile diff
     - Visit the Prime Factorization exercise
     - Answer problems where the solution looks like:
       - `2`
       - `2^3`
       - `2 \cdot 3`
       - `2 \times 3`
       - `2 ^ 3 \times 3 ^ 2`
     - See that they all work
    
    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: https://phabricator.khanacademy.org/D15918
Commits on Jan 28, 2015
  1. Ben Eater

    Determinstically choose problem type

    beneater authored
    Somehow some refactor resulted in us using `Math.random()` instead of `KhanUtil.random()` for choosing the problem type. The latter is stable for a given user.
    
    Test Plan:
    1. Load http://stable.ka.local/math/geometry/geometric-constructions/geo-bisectors/e/constructions_1 in webapp
    2. Refresh the page ~5 times
    3. Get the same problem each time
    4. Cross fingers that we didn't get the same problem by chance (p=0.0016)
    
    Auditors: emily
Commits on Jan 26, 2015
  1. Ben Eater

    Don't always assume double arrows in graphInit()

    beneater authored
    Summary: This if statement would always evaluate as true, which I'm pretty sure isn't what we want, though who knows what's out there that depends on this behavior :\
    
    Test Plan:
    1. Substate this into graphie-to-png
    2. Run app.py in graphie-to-png
    3. Go to http://localhost:5001/ and choose "1. Simple plot"
    4. Change the `axisArrows: "<->"` line to `"->"` and `""` and regraph, seeing the correct axis arrows
    
    Reviewers: aria, emily
    
    Reviewed By: emily
    
    Differential Revision: https://phabricator.khanacademy.org/D15861
Commits on Jan 23, 2015
  1. Ben Eater

    Can't have <p> inside a <p>

    beneater authored
    Test Plan: `make lint` in webapp
    
    Auditors: emily
  2. Desmond Brand

    Send client local datetime when submitting problem attempts

    dmnd authored
    Summary:
    Streaks needs clients to send client local time when recording activity like
    problem attempts.
    
    So, use moment().format() to send an ISO 8601 datetime string:
    
      * In webapp, moment is listed as a dependency of interface.js
        (see D15748)
      * In standalone mode moment is l loaded from local-only
      * In iOS moment is loaded from local-only via exercise-view.html
        (diff pending)
    
    Test Plan:
      * Opened standalone mode, answered a question and things seem to work.
      * Tested with webapp and saw that the endpoint received a value for `client_dt`.
      * Tested with iOS and saw that the app sent a value for `client_dt`
    
    Reviewers: emily, eater, jlfwong
    
    Reviewed By: eater, jlfwong
    
    Subscribers: alpert, emily, marcia
    
    Differential Revision: https://phabricator.khanacademy.org/D15725
Commits on Jan 21, 2015
  1. Ben Eater

    Fix congruent angles exercise in IE

    beneater authored
    This seems to work...
    
    Test Plan:
    Test http://exercises.ka.local/exercises/congruent_angles.html in IE9 and Chrome. In both browsers:
    - Verify no JS errors in console
    - Verify all angles (except the given angle) are clickable
    - Verify the midpoint of the lines is not clickable (to see that the mouse target for hash marks was properly removed)
    - Take hints
    - Verify the correct answer is accepted and incorrect answers aren't
    
    Auditors: emily, charlie
Commits on Jan 15, 2015
  1. Emily Eisenberg

    Fix up graphing inequalities exercises (for mobile)

    xymostech authored
    Summary:
    Make some changes to the different graphing inequalities
    exercises so that they're more mobile friendly. The main change is
    making the checkboxes and radio buttons play nicely with the funky
    styling we put on them in mobile land, while still looking good in
    non-mobile (done through some `body:not(.mobile)` trickery). Also, add
    some padding to graphs to reduce text collisions, and remove/move around
    some input elements to make more sense.
    
    Test Plan:
     - Visit all 4 exercises locally (not on mobile)
       - See that all of the radio buttons/checkboxes look about the same as
         before
       - Take hints, see no text overlaps
       - See that all of the exercises are still answerable.
     - Visit all 4 exercises on mobile ("Graphing and solving linear
       inequalities", "Graphing linear inequalities in two variables",
       "Graphing systems of inequalities", and "Graphing and solving systems
       of inequalities")
       - See that all of the radio buttons/checkboxes look good and are not
         squished together.
       - Take hints, see that no text overlaps.
    
    Reviewers: eater
    
    Reviewed By: eater
    
    Subscribers: marcos
    
    Differential Revision: https://phabricator.khanacademy.org/D15747
Commits on Jan 14, 2015
  1. Peter Collingridge

    Fix cut and copy questions

    petercollingridge authored
    Summary: Unit plural for https://khanacademy.atlassian.net/browse/AI-466113 and says tools are below for https://khanacademy.atlassian.net/browse/AI-478982
    
    Reviewers: eater, emily
    
    Reviewed By: emily
    
    Differential Revision: https://phabricator.khanacademy.org/D15633
  2. Peter Collingridge
  3. Peter Collingridge

    Make question clearer and hints nicer

    petercollingridge authored
    Summary: I've made the question larger as a lot of people can't see negative signs in the exponents. I also made the hints a bit nicer and colour-coded.
    
    Reviewers: eater, emily
    
    Reviewed By: emily
    
    Differential Revision: https://phabricator.khanacademy.org/D15575
Commits on Jan 12, 2015
  1. Joel Burget

    Fix congruent angles mouse target radii.

    joelburget authored
    Test plan:
    * open http://dev:8001/exercises/congruent_angles.html
    * see no js errors on load
    * complete one problem successfully
    
    Auditors: emily
  2. Joel Burget

    Confine hack to scientific notation intuition.

    joelburget authored
    ... as suggested by @charlie.
    
    Test plan:
    * open http://dev:8001/exercises/scientific_notation_intuition.html
    * repeatedly drag blue dot back and forth
    * open http://dev:8001/exercises/derivative_intuition.html
    * drag orange dots up and down
    
    Auditors: emily
Commits on Jan 9, 2015
  1. Charles Marsh

    Use mouseTarget.getMouseTarget() where applicable

    crm416 authored
    Summary:
    A lot of the highlight effects were failing due to use of mouseTarget[0] that
    should have been changed to mouseTarget.getMouseTarget(). This changes all the necessary
    calls in khan-exercises.
    
    I also snuck in a line to remove arrowheads from lines when `remove` is called as I noticed
    that they were lingering in the transformer.
    
    Test Plan:
    - Run khan-exercises
        - Run [Inscribing and Circumscribing Circles on a Triangle](http://localhost:8000/exercises/inscribing_and_circumscribing_circles_on_a_triangle.html).
        - Add a compass
            - Verify that the whole circle highlights when you mouseover the center
        - Add a straightedge
            - Verify that the whole line (including the points, but not the arrowheads) highlights when you mouseover the line
    - Run Perseus
        - Create a [transformer](http://localhost:9000/test.html#content=%7B%22question%22%3A%7B%22content%22%3A%22%2A%2AMove%20the%20line%20using%20a%20translation%20of%20%24-2%24%20in%20the%20%24x%24-direction%20and%20%24%2B4%24%20in%20the%20%24y%24-direction.%2A%2A%5Cn%5Cn%5B%5B%E2%98%83%20transformer%201%5D%5D%5Cn%5CnWhen%20a%20line%20is%20translated%2C%20the%20image%20created%20is%20a%20%5B%5B%E2%98%83%20dropdown%201%5D%5D.%5Cn%5CnWe%20know%20this%20is%20true%2C%20because%20the%20translated%20image%20has%20%5B%5B%E2%98%83%20dropdown%202%5D%5D%20endpoints.%22%2C%22images%22%3A%7B%7D%2C%22widgets%22%3A%7B%22transformer%201%22%3A%7B%22type%22%3A%22transformer%22%2C%22graded%22%3Atrue%2C%22options%22%3A%7B%22starting%22%3A%7B%22shape%22%3A%7B%22type%22%3A%5B%22line%22%5D%2C%22coords%22%3A%5B%5B-5%2C-7%5D%2C%5B7%2C-3%5D%5D%7D%2C%22transformations%22%3A%5B%5D%7D%2C%22graphMode%22%3A%22interactive%22%2C%22listMode%22%3A%22dynamic%22%2C%22tools%22%3A%7B%22translation%22%3A%7B%22enabled%22%3Atrue%2C%22constraints%22%3A%7B%7D%7D%2C%22rotation%22%3A%7B%22enabled%22%3Atrue%2C%22constraints%22%3A%7B%22fixed%22%3Afalse%7D%2C%22coord%22%3A%5B0%2C0%5D%7D%2C%22reflection%22%3A%7B%22enabled%22%3Atrue%2C%22constraints%22%3A%7B%22fixed%22%3Afalse%7D%2C%22coords%22%3A%5B%5B1%2C1%5D%2C%5B3%2C3%5D%5D%7D%2C%22dilation%22%3A%7B%22enabled%22%3Atrue%2C%22constraints%22%3A%7B%22fixed%22%3Afalse%7D%2C%22coord%22%3A%5B6%2C6%5D%7D%7D%2C%22drawSolutionShape%22%3Afalse%2C%22gradeEmpty%22%3Afalse%2C%22graph%22%3A%7B%22range%22%3A%5B%5B-10%2C10%5D%2C%5B-10%2C10%5D%5D%2C%22step%22%3A%5B1%2C1%5D%2C%22markings%22%3A%22graph%22%2C%22labels%22%3A%5B%22x%22%2C%22y%22%5D%2C%22backgroundImage%22%3A%7B%22url%22%3Anull%2C%22scale%22%3A1%2C%22bottom%22%3A0%2C%22left%22%3A0%7D%2C%22showProtractor%22%3Afalse%2C%22showRuler%22%3Afalse%2C%22rulerLabel%22%3A%22%22%2C%22rulerTicks%22%3A10%2C%22gridStep%22%3A%5B1%2C1%5D%2C%22snapStep%22%3A%5B0.5%2C0.5%5D%7D%2C%22version%22%3A1.2%2C%22correct%22%3A%7B%22transformations%22%3A%5B%7B%22type%22%3A%22translation%22%2C%22vector%22%3A%5B-2%2C4%5D%7D%5D%2C%22shape%22%3A%7B%22type%22%3A%5B%22line%22%5D%2C%22coords%22%3A%5B%5B-7%2C-3%5D%2C%5B5%2C1%5D%5D%2C%22options%22%3A%5B%7B%7D%5D%7D%7D%7D%2C%22version%22%3A%7B%22major%22%3A0%2C%22minor%22%3A0%7D%7D%2C%22dropdown%201%22%3A%7B%22type%22%3A%22dropdown%22%2C%22graded%22%3Atrue%2C%22options%22%3A%7B%22choices%22%3A%5B%7B%22content%22%3A%22ray%22%2C%22correct%22%3Afalse%7D%2C%7B%22content%22%3A%22line%22%2C%22correct%22%3Atrue%7D%2C%7B%22content%22%3A%22segment%22%2C%22correct%22%3Afalse%7D%5D%2C%22placeholder%22%3A%22%22%7D%2C%22version%22%3A%7B%22major%22%3A0%2C%22minor%22%3A0%7D%7D%2C%22dropdown%202%22%3A%7B%22type%22%3A%22dropdown%22%2C%22graded%22%3Atrue%2C%22options%22%3A%7B%22choices%22%3A%5B%7B%22content%22%3A%220%22%2C%22correct%22%3Atrue%7D%2C%7B%22content%22%3A%223%22%2C%22correct%22%3Afalse%7D%2C%7B%22content%22%3A%221%22%2C%22correct%22%3Afalse%7D%5D%2C%22placeholder%22%3A%22%22%7D%2C%22version%22%3A%7B%22major%22%3A0%2C%22minor%22%3A0%7D%7D%7D%7D%2C%22answerArea%22%3A%7B%22type%22%3A%22multiple%22%2C%22options%22%3A%7B%22content%22%3A%22%22%2C%22images%22%3A%7B%7D%2C%22widgets%22%3A%7B%7D%7D%2C%22calculator%22%3Afalse%7D%2C%22itemDataVersion%22%3A%7B%22major%22%3A0%2C%22minor%22%3A1%7D%2C%22hints%22%3A%5B%7B%22content%22%3A%22Here%27s%20how%20to%20translate%20the%20%24%5C%5Cblue%5C%5Ctext%7Bblue%20line%7D%24%3A%20%20%5Cn%24%5C%5Cbullet%24%20Click%20the%20%5C%22Translate%5C%22%20button.%20%20%5Cn%24%5C%5Cbullet%24%20Drag%20any%20orange%20point%20%242%24%20units%20to%20the%20%2Aleft%2A%20and%20%244%24%20units%20%2Aup%2A.%22%2C%22images%22%3A%7B%7D%2C%22widgets%22%3A%7B%7D%7D%2C%7B%22content%22%3A%22When%20a%20line%20is%20translated%2C%20it%20remains%20a%20line.%20%20It%20still%20goes%20on%20forever%20in%20both%20directions.%20%20The%20new%20line%20has%20no%20endpoints%2C%20just%20like%20the%20original%20line.%5Cn%5CnThe%20translated%20line%20should%20look%20like%20this%3A%5Cn%21%5B%5D%28https%3A%2F%2Fka-perseus-graphie.s3.amazonaws.com%2Fb13b453e5ea64dec3e0a0d97110cf81c85424986.png%29%22%2C%22images%22%3A%7B%22https%3A%2F%2Fka-perseus-graphie.s3.amazonaws.com%2Fb13b453e5ea64dec3e0a0d97110cf81c85424986.png%22%3A%7B%22width%22%3A425%2C%22height%22%3A425%7D%7D%2C%22widgets%22%3A%7B%7D%7D%5D%7D).
        - Switch to 'reflect' and then to 'dilate'.
        - Verify that the arrowheads are gone.
    
    Reviewers: emily
    
    Reviewed By: emily
    
    Differential Revision: https://phabricator.khanacademy.org/D15635
  2. Peter Collingridge

    Ensure names are different

    petercollingridge authored
    Summary: For https://khanacademy.atlassian.net/browse/AI-442271
    
    Reviewers: eater, emily
    
    Reviewed By: emily
    
    Differential Revision: https://phabricator.khanacademy.org/D15576
Commits on Jan 8, 2015
  1. Joel Burget

    Fix "Properties of Rigid Transformations".

    joelburget authored
    I don't know why the parent node is gone or if that could cause
    problems. Well, I'm sure it could, but this is a hacky fix. Anyway,
    things worked fine in my limited testing and this is surely better than
    just breaking.
    
    Auditors: emily
    
    Test plan:
    http://dev:9000/test.html#content=%7B%22question%22%3A%7B%22content%22%3A%22%2A%2AMove%20the%20line%20using%20a%20translation%20of%20%24-2%24%20in%20the%20%24x%24-direction%20and%20%24%2B4%24%20in%20the%20%24y%24-direction.%2A%2A%5Cn%5Cn%5B%5B%E2%98%83%20transformer%201%5D%5D%5Cn%5CnWhen%20a%20line%20is%20translated%2C%20the%20image%20created%20is%20a%20%5B%5B%E2%98%83%20dropdown%201%5D%5D.%5Cn%5CnWe%20know%20this%20is%20true%2C%20because%20the%20translated%20image%20has%20%5B%5B%E2%98%83%20dropdown%202%5D%5D%20endpoints.%22%2C%22images%22%3A%7B%7D%2C%22widgets%22%3A%7B%22transformer%201%22%3A%7B%22type%22%3A%22transformer%22%2C%22graded%22%3Atrue%2C%22options%22%3A%7B%22starting%22%3A%7B%22shape%22%3A%7B%22type%22%3A%5B%22line%22%5D%2C%22coords%22%3A%5B%5B-5%2C-7%5D%2C%5B7%2C-3%5D%5D%7D%2C%22transformations%22%3A%5B%5D%7D%2C%22graphMode%22%3A%22interactive%22%2C%22listMode%22%3A%22dynamic%22%2C%22tools%22%3A%7B%22translation%22%3A%7B%22enabled%22%3Atrue%2C%22constraints%22%3A%7B%7D%7D%2C%22rotation%22%3A%7B%22enabled%22%3Atrue%2C%22constraints%22%3A%7B%22fixed%22%3Afalse%7D%2C%22coord%22%3A%5B0%2C0%5D%7D%2C%22reflection%22%3A%7B%22enabled%22%3Atrue%2C%22constraints%22%3A%7B%22fixed%22%3Afalse%7D%2C%22coords%22%3A%5B%5B1%2C1%5D%2C%5B3%2C3%5D%5D%7D%2C%22dilation%22%3A%7B%22enabled%22%3Atrue%2C%22constraints%22%3A%7B%22fixed%22%3Afalse%7D%2C%22coord%22%3A%5B6%2C6%5D%7D%7D%2C%22drawSolutionShape%22%3Afalse%2C%22gradeEmpty%22%3Afalse%2C%22graph%22%3A%7B%22range%22%3A%5B%5B-10%2C10%5D%2C%5B-10%2C10%5D%5D%2C%22step%22%3A%5B1%2C1%5D%2C%22markings%22%3A%22graph%22%2C%22labels%22%3A%5B%22x%22%2C%22y%22%5D%2C%22backgroundImage%22%3A%7B%22url%22%3Anull%2C%22scale%22%3A1%2C%22bottom%22%3A0%2C%22left%22%3A0%7D%2C%22showProtractor%22%3Afalse%2C%22showRuler%22%3Afalse%2C%22rulerLabel%22%3A%22%22%2C%22rulerTicks%22%3A10%2C%22gridStep%22%3A%5B1%2C1%5D%2C%22snapStep%22%3A%5B0.5%2C0.5%5D%7D%2C%22version%22%3A1.2%2C%22correct%22%3A%7B%22transformations%22%3A%5B%7B%22type%22%3A%22translation%22%2C%22vector%22%3A%5B-2%2C4%5D%7D%5D%2C%22shape%22%3A%7B%22type%22%3A%5B%22line%22%5D%2C%22coords%22%3A%5B%5B-7%2C-3%5D%2C%5B5%2C1%5D%5D%2C%22options%22%3A%5B%7B%7D%5D%7D%7D%7D%2C%22version%22%3A%7B%22major%22%3A0%2C%22minor%22%3A0%7D%7D%2C%22dropdown%201%22%3A%7B%22type%22%3A%22dropdown%22%2C%22graded%22%3Atrue%2C%22options%22%3A%7B%22choices%22%3A%5B%7B%22content%22%3A%22ray%22%2C%22correct%22%3Afalse%7D%2C%7B%22content%22%3A%22line%22%2C%22correct%22%3Atrue%7D%2C%7B%22content%22%3A%22segment%22%2C%22correct%22%3Afalse%7D%5D%2C%22placeholder%22%3A%22%22%7D%2C%22version%22%3A%7B%22major%22%3A0%2C%22minor%22%3A0%7D%7D%2C%22dropdown%202%22%3A%7B%22type%22%3A%22dropdown%22%2C%22graded%22%3Atrue%2C%22options%22%3A%7B%22choices%22%3A%5B%7B%22content%22%3A%220%22%2C%22correct%22%3Atrue%7D%2C%7B%22content%22%3A%223%22%2C%22correct%22%3Afalse%7D%2C%7B%22content%22%3A%221%22%2C%22correct%22%3Afalse%7D%5D%2C%22placeholder%22%3A%22%22%7D%2C%22version%22%3A%7B%22major%22%3A0%2C%22minor%22%3A0%7D%7D%7D%7D%2C%22answerArea%22%3A%7B%22type%22%3A%22multiple%22%2C%22options%22%3A%7B%22content%22%3A%22%22%2C%22images%22%3A%7B%7D%2C%22widgets%22%3A%7B%7D%7D%2C%22calculator%22%3Afalse%7D%2C%22itemDataVersion%22%3A%7B%22major%22%3A0%2C%22minor%22%3A1%7D%2C%22hints%22%3A%5B%7B%22content%22%3A%22Here%27s%20how%20to%20translate%20the%20%24%5C%5Cblue%5C%5Ctext%7Bblue%20line%7D%24%3A%20%20%5Cn%24%5C%5Cbullet%24%20Click%20the%20%5C%22Translate%5C%22%20button.%20%20%5Cn%24%5C%5Cbullet%24%20Drag%20any%20orange%20point%20%242%24%20units%20to%20the%20%2Aleft%2A%20and%20%244%24%20units%20%2Aup%2A.%22%2C%22images%22%3A%7B%7D%2C%22widgets%22%3A%7B%7D%7D%2C%7B%22content%22%3A%22When%20a%20line%20is%20translated%2C%20it%20remains%20a%20line.%20%20It%20still%20goes%20on%20forever%20in%20both%20directions.%20%20The%20new%20line%20has%20no%20endpoints%2C%20just%20like%20the%20original%20line.%5Cn%5CnThe%20translated%20line%20should%20look%20like%20this%3A%5Cn%21%5B%5D%28https%3A%2F%2Fka-perseus-graphie.s3.amazonaws.com%2Fb13b453e5ea64dec3e0a0d97110cf81c85424986.png%29%22%2C%22images%22%3A%7B%22https%3A%2F%2Fka-perseus-graphie.s3.amazonaws.com%2Fb13b453e5ea64dec3e0a0d97110cf81c85424986.png%22%3A%7B%22width%22%3A425%2C%22height%22%3A425%7D%7D%2C%22widgets%22%3A%7B%7D%7D%5D%7D
    
    Do all four transformations successfully without any javascript errors.
  2. Joel Burget

    Fix congruent angles exercise.

    joelburget authored
    congruency.js was still using the older interface to movable point. I
    just mechanically replaced `mouseTarget` / `mouseTarget[0]` with
    `mouseTarget.getMouseTarget()`.
    
    Test plan:
    * grep in exercises/ for "\bcongruency\b", look through to verify
      "Congruent Angles" is the only exercise using congruency.js
    * Complete a few "Congruent Angles" problems
    
    Auditors: emily
  3. Joel Burget

    Fix scientific notation intuition.

    joelburget authored
    Test plan:
    Repeatedly drag point left and right.
    
    Auditors: emily
  4. Joel Burget

    Comment out call to missing method.

    joelburget authored
    I don't think this double click functionality was widely used anyway.
    
    Test plan:
    Add compass, drag it around, scale it. No JS errors.
    
    Auditors: emily
  5. Emily Eisenberg

    Clean up some missed changes from charlie's review

    xymostech authored
    Summary: There was an instance of `drawArrowAtClipPoint` that hadn't
    been changed to `createArrow`, and the calculation of the ending point
    of rays wasn't correct. This fixes those things
    
    Test plan:
     - Make these changes in the perseus repo
     - Add an interactive-graph with the angle type
       - See that there isn't a javascript error
       - See that the extended rays extend correctly
    
    Auditors: charlie
Commits on Jan 7, 2015
  1. Emily Eisenberg

    Remove unnecessary mobile-only style

    xymostech authored
    Summary: We added a style to make the graphie look good on mobile, but a
    similar style has now been added into the main mobile app, so this is no
    longer needed.
    
    Test plan:
     - I think marcos tested this
    
    Auditors: marcos
  2. Peter Collingridge

    Ensure answer requires moving point

    petercollingridge authored
    Summary: For https://khanacademy.atlassian.net/browse/AI-460005
    
    Reviewers: eater, emily
    
    Reviewed By: emily
    
    Differential Revision: https://phabricator.khanacademy.org/D15493
  3. Peter Collingridge

    Add spaces so code renders correctly

    petercollingridge authored
    Summary: For https://khanacademy.atlassian.net/browse/AI-460947
    
    Reviewers: eater, emily
    
    Reviewed By: emily
    
    Differential Revision: https://phabricator.khanacademy.org/D15494
  4. Peter Collingridge

    Fix typo and make numbers mathy

    petercollingridge authored
    Summary:
    For https://khanacademy.atlassian.net/browse/AI-457110#
    I also rearranged the hints slightly, but I still don't really like them.
    
    Reviewers: eater, emily
    
    Reviewed By: emily
    
    Differential Revision: https://phabricator.khanacademy.org/D15492
  5. Peter Collingridge

    Ensure hints work when one number is zero

    petercollingridge authored
    Summary: (Request by Ben Stenhaug)
    
    Test Plan: Keep refreshing until one of the numbers is zero and check the hints. Check the other hints just in case.
    
    Reviewers: eater, emily
    
    Reviewed By: emily
    
    Differential Revision: https://phabricator.khanacademy.org/D15491
  6. Emily Eisenberg

    Remove places khan-exercises manually sets font-size

    xymostech authored
    Summary: In a bunch of places, we manually set the font-size (in pixels)
    of certain parts of the question (usually in the answer area so it would
    fit in the small box). This is unnecessary now since the answer area is
    in the body, and it looks bad on mobile because the fonts don't scale
    accordingly. This fixes a couple places that this happened.
    
    Also, I fixed the TeX in parabola_intuition_{2,3}, because it was a
    mess.
    
    Test plan:
     - Open all the exercises that changed locally, see that they look good
     - Open all the exercises that changed on mobile, see that they look
     good
    
    Auditors: joel, eater
  7. Emily Eisenberg

    Add show/hide methods back to movableLine/Point

    xymostech authored
    Summary: Looks like a single exercise (plotting_the_line_of_best_fit,
    and no I definitely didn't write that, what are you talking about) uses
    the hide and show functions on the visibleShape of movablePoints and
    movableLines. These functions stopped working when charlie's wrapped
    changes were merged in. This makes those work so the exercise works
    again.
    
    Test plan:
     - Load the plotting_the_line_of_best_fit exercise
     - See that the "A line fits the data well" and "no line fits the data
       well" radio buttons work correctly and hide and show the line and
       points.
    
    Auditors: charlie
  8. Emily Eisenberg

    Add event after initial hints are rendered

    xymostech authored
    Summary:
    We have events bound to the Exercises object that are triggered
    after the main body of the problem is rendered but not the hints, and
    events that trigger after each additional hint is taken, but no event
    that is triggered after the initial hints are rendered. This adds such
    an event, so that mobile can modify the initial hints (in particular, so
    it can replace qhint text boxes with myscript ones).
    
    Test Plan:
     - Put this code in the mobile app
     - Bind to this event and put a breakpoint
     - Load an exercise where hints have been taken
     - See that the hints are part of the body of the question when the
       breakpoint is hit
    
    Reviewers: joel
    
    Reviewed By: joel
    
    Differential Revision: https://phabricator.khanacademy.org/D15548
Something went wrong with that request. Please try again.