Skip to content
Commits on Oct 18, 2012
  1. @yunfangjuan
  2. @yunfangjuan

    fix per eater

    yunfangjuan committed Oct 4, 2012
  3. @yunfangjuan

    fix some bugs.

    yunfangjuan committed Oct 4, 2012
  4. @yunfangjuan
  5. @yunfangjuan

    polishing f(ax+b)+c

    yunfangjuan committed Oct 4, 2012
  6. @yunfangjuan
  7. @yunfangjuan

    adding the f(kx) exercise

    yunfangjuan committed Oct 2, 2012
  8. @yunfangjuan

    Some minor tweaks

    yunfangjuan committed Oct 1, 2012
  9. @yunfangjuan
  10. @yunfangjuan

    DO NOT REVIEW. PLACE HOLDER FOR SANDCASTLE. transforming functions

    yunfangjuan committed Sep 26, 2012
    Summary: function transformations.
    
    Test Plan: tested on my local machine.
    
    Reviewers: eater, stephanie
    
    Differential Revision: http://phabricator.khanacademy.org/D784
  11. @yunfangjuan
  12. @yunfangjuan
Commits on Oct 16, 2012
  1. @spicyj

    Back out new answer-types.js for now

    spicyj committed Oct 15, 2012
    Auditors: emily, eater
Commits on Oct 15, 2012
  1. @beneater

    Merge pull request #31899 from xymostech/fix-fractions-negative

    beneater committed Oct 15, 2012
    Make sure fractions doesn't incorrectly show -1
  2. @xymostech
  3. @xymostech

    Make sure fractions doesn't incorrectly show -1

    xymostech committed Oct 15, 2012
    I think this was a typo because the same structure
    (solution > 0 ? 1 : -1) is used several times afterwards as well.
  4. @beneater

    Fix to rate_problems_1 to ensure the givens make sense

    beneater committed Oct 15, 2012
    Summary:
    Previously one of the distances could be zero, so the given average
    speed didn't make sense. (How can you have an average speed over zero distance?)
    This just ensures neither distance is zero.
    
    Test Plan: Tested locally outside devappserver
    
    Reviewers: stephanie, yunfangjuan
    
    Reviewed By: stephanie
    
    Differential Revision: http://phabricator.khanacademy.org/D848
  5. @beneater

    Fix two with combining_like_terms_2:

    beneater committed Oct 15, 2012
    Summary:
    In the ax_fbx_fd problem type, the variable coefficient could simplify to 0
    and require entering "0x+5" instead of just "5", for example. Added a data-ensure
    to ensure the coefficient is always non-zero.
    
    Also, the final hint in the eax_ec_fd_fbx problem type left off the constant
    term unless it was 0 instead of the other way around.
    
    Test Plan:
    Test locally to verify the two problems were fixed in these two seeds:
    http://sandcastle.khanacademy.org/media/castles/Khan:master/exercises/combining_like_terms_2.html?seed=62&problem=ax_fbx_fd&debug
    http://sandcastle.khanacademy.org/media/castles/Khan:master/exercises/combining_like_terms_2.html?seed=42&problem=eax_ec_fd_fbx&debug
    
    Reviewers: stephanie, yunfangjuan
    
    Reviewed By: stephanie
    
    Differential Revision: http://phabricator.khanacademy.org/D843
  6. @beneater

    more -> at least

    beneater committed Oct 15, 2012
    Test Plan: Tested locally
    
    Reviewers: stephanie, yunfangjuan
    
    Reviewed By: stephanie
    
    Differential Revision: http://phabricator.khanacademy.org/D837
Commits on Oct 12, 2012
  1. @beneater

    Fix radio answer type to require selecting an answer and be whitespac…

    beneater committed Oct 12, 2012
    …e insensitive
    
    Test Plan: Tested limits_1 and expected_value exercises in devappserver. Checked that unselected radio couldn't be selected, correct answer was accepted, and history showed up in coach reports.
    
    Reviewers: emily
    
    Reviewed By: emily
    
    Differential Revision: http://phabricator.khanacademy.org/D838
  2. @beneater

    Merge pull request #31742 from xymostech/fix-snapx

    beneater committed Oct 12, 2012
    Remove our 3-layer redundant snapping
  3. @xymostech

    Remove our 3-layer redundant snapping

    xymostech committed Oct 12, 2012
    For some reason, we perform snapping 3 times, instead of the required 1.
    This apparently leads to some problems. I'm not sure why these problems
    occur, but they do, and this fixes them.
    
    Closes 31738, 31739
Commits on Oct 10, 2012
  1. @spicyj

    Fix set answer type

    spicyj committed Oct 9, 2012
    ... I think.
    
    Auditors: xymostech, eater
Commits on Oct 9, 2012
  1. @xymostech

    Make answer types much more modular, and more internally consistent

    xymostech committed Oct 9, 2012
    Summary:
    Separate answer-type creation into two steps, setup (where the answer area is
    messed with) and validator creation (where a function to validate solutions is
    created). These two may only communicate by a "guess" variable, generated by
    the setup portion and evaluated by the validator portion. This allows for
    cleaner and less hacky code, and also allows for multiple solutions to be
    validated using the same setup.
    
    Some of the khan-exercise.js code had to be modified to make this work
    correctly, but most of the changes come from the rework of answer-types.js
    
    Test Plan:
    Go through lots of exercises and make sure that they still work, and that the
    timeline still works with their answers
    
    Reviewers: eater
    
    Reviewed By: eater
    
    CC: alpert
    
    Differential Revision: http://phabricator.khanacademy.org/D793
Commits on Oct 6, 2012
  1. @beneater

    Lint

    beneater committed Oct 5, 2012
    Test plan: Cross fingers
    
    Auditors: alpert
Commits on Oct 5, 2012
  1. @csilvers

    Get rid of some more unused images

    csilvers committed Oct 5, 2012
    Summary:
    'grep css/ -r .' shows that only throbber.css is being used from this
    directory.
    
    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D809
  2. @csilvers

    Remove an unused image.

    csilvers committed Oct 5, 2012
    Summary:
    Ben eater sez, at http://phabricator.khanacademy.org/D807: "I happen
    to know that images/circ.png isn't used anywhere. We can remove it,
    fwiw."
    
    Test Plan: Trust ben :-)  Also, did 'grep -r circ.png .' and found nothing.
    
    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D808
  3. @csilvers

    Copy over the images from the KA repository.

    csilvers committed Oct 5, 2012
    Summary:
    The content of these images haven't changed, but the size has since we
    spent some time compressing images for KA.
    
    I used the following messy command to do this:
    
    khan-exercises$ find . -name '*.png' | while read i; do for subdir in "" "badges/" "avatars/"; do orig=~/khan/stable/`echo $i | sed -e s,/css,, -e s,images/,images/$subdir,`; [ -e $orig ] && cp -v $orig $i; done; done
    
    The following two files did not exist in the main KA repo, so I
    compressed them manually by running pngout on them:
       images/protractor.png images/circ.png
    
    Test Plan:
    Viewed all the images in a viewer, for before-change and after-change,
    and verified they look the same.
    
    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D807
  4. @csilvers

    Remove unused images.

    csilvers committed Oct 5, 2012
    Summary:
    'grep -r repeating-sprites .' shows that these files aren't referenced
    anywhere.
    
    Reviewers: eater
    
    Reviewed By: eater
    
    Differential Revision: http://phabricator.khanacademy.org/D806
Commits on Oct 4, 2012
  1. rename exercises/filenames and get rid of unused graphie import

    Stephanie H. Chang committed Oct 4, 2012
  2. refactor printMatrix to use deepZipWith

    Stephanie H. Chang committed Oct 4, 2012
  3. refactors for D797

    Stephanie H. Chang committed Oct 4, 2012
  4. fixes for D797

    Stephanie H. Chang committed Oct 4, 2012
  5. add scalar matrix multiplication exercise

    Stephanie H. Chang committed Oct 3, 2012
  6. Add exercises: Matrix addition and Matrix subtraction

    Stephanie H. Chang committed Oct 2, 2012
    Summary: Also, add prependVars to tmpl.js.
    
    Test Plan: Tested locally.
    
    Reviewers: eater, yunfangjuan
    
    Differential Revision: http://phabricator.khanacademy.org/D797
Something went wrong with that request. Please try again.