Summary: For https://khanacademy.atlassian.net/browse/AI-496882 I wonder whether I should remove all the red lines as most hints don't do this, but they are quite nicely done. Reviewers: emily, eater Reviewed By: eater Differential Revision: https://phabricator.khanacademy.org/D16147
Summary: This commit moves the entire #solutionarea div to the bottom of the question area, unless the question contains an element with the class name "render-answer-area-here" (in which case the div is placed immediately after this element). In addition, this commit removes entirely the old "acceptable formats" section at the top of the answer area in favor of tooltips attached directly to individual input elements. This is basically backporting the approach we've taken in Perseus to khan-exercises. Speaking of which, this commit also brings the expression editor in khan-exercises more in line with the Perseus version (rendered output above input) which is a necessary change because otherwise the tooltip obscures the output. Test Plan: Most of these changes were in place during the answer area moving party, and so in general all exercises should be confirmed to work. Tooltips were only finished afterwards though, so I've spot-checked the various answer types myself. Reviewers: aria Reviewed By: aria Subscribers: emily Differential Revision: http://phabricator.khanacademy.org/D14745
Summary: Also did some misc cleanup in khan-exercise.js, mostly related to module-y things ("151 ++----"). I combined local jquery-ui into one file to make it easier to load. Test Plan: Opened addition_1, deriviative_intuition, graphing_points_2 locally, and all looked fine. In webapp/khan-exercises/, ran: ``` npm install -g requirejs r.js -o requirejs.config.js ``` then saw that /exercises/addition_1 looked right. Reviewers: eater, jack Reviewed By: jack CC: alex Differential Revision: http://phabricator.khanacademy.org/D7095
Summary: Previously, we were sometimes inconsistent about this but we made a small effort to mark things as empty if anything was empty. I'm changing this so that it's marked empty only if everything is empty. Note my changes to the graphing exercises are not the result of a regression; they returned false before and now return empty on an unmoved graph. Test Plan: Ran unit tests (unit tests are great!), tested every exercise that has a checkbox. Reviewers: emily, eater Reviewed By: emily Differential Revision: http://phabricator.khanacademy.org/D3674
Summary: This was a bad one. :( I'm not sure what this .attr("required") was supposed to be... do we have cases where answers are optional (besides fallbacks)? Test Plan: Ran answer-types unit tests. Reviewers: eater, emily Reviewed By: emily Differential Revision: http://phabricator.khanacademy.org/D2922
…g entities with characters in data-if attributes.
… the data-if attributes.
…tly-expanding whitespace problem in the cleaner.
…rcises #FIXIT Test Plan: Locally check each exercise/problem type still looks the same(ish) Reviewers: alpert, cbhl Reviewed By: cbhl Differential Revision: http://phabricator.khanacademy.org/D2056
Summary: CCing Emily since you might appreciate the interesting answer type hack Test Plan: Tested locally Reviewers: stephanie Reviewed By: stephanie CC: emily Differential Revision: http://phabricator.khanacademy.org/D958
… of just |x|. Summary: Update absolute value exercise to have expressions like |x+5| instead of just |x|. Reviewers: eater Reviewed By: eater Differential Revision: http://phabricator.khanacademy.org/D429
…itional to allow "127.0.0.1". Test plan: Try out each exercise that I have modified, while using hints.