Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Jun 4, 2014
  1. @petercollingridge

    Add hint to define divisible

    petercollingridge authored
    Reviewers: eater
    Reviewed By: eater
    Differential Revision:
Commits on Mar 5, 2014
  1. @spicyj

    Use requirejs for module loading

    spicyj authored
    Summary: Also did some misc cleanup in khan-exercise.js, mostly related to module-y things ("151 ++----"). I combined local jquery-ui into one file to make it easier to load.
    Test Plan:
    Opened addition_1, deriviative_intuition, graphing_points_2 locally, and all looked fine.
    In webapp/khan-exercises/, ran:
    npm install -g requirejs
    r.js -o requirejs.config.js
    then saw that /exercises/addition_1 looked right.
    Reviewers: eater, jack
    Reviewed By: jack
    CC: alex
    Differential Revision:
Commits on Sep 9, 2013
  1. @csilvers

    Get rid of cardinal() everywhere escept the exercise testing cardinal…

    csilvers authored
    In most places, I replaced cardinal with the simpler
    cardinalThrough20() function, which shows a cardinal number if n is
    between 0 and 20, and the digits of n otherwise.  In almost all uses,
    n is provably between 0 and 20 so this should give mostly the same
    results as before.
    In a few cases, such as some of the age_word_problems, n can sometimes
    be > 20.  However, in those exercises, we seem to be mixing cardinal
    numbers with decimal numbers somewhat indisciminately anyway, so I
    doubt anyone will notice the change.
    Task T1060
    Get rid of ordinal() as well, replacing it with ordinalThrough20().
    This is enough to cover all the uses of ordinal to date.
    Test Plan:
    Ran python -mSimpleHTTPServer and visited
    and likewise for all the exercises in this commit, and looked at the
    text and hints to make sure they read ok.  I reloaded until the
    exercise(s) with the cardinal change came up.
    Ran python -mSimpleHTTPServer and visited
    and likewise for all the other exercises, and read the text and hints
    to make sure the ordinal numbers were displayed correctly.
    Reviewers: alpert, eater
    Reviewed By: alpert
    Maniphest Tasks: T1060
    Differential Revision:
Commits on Sep 1, 2013
  1. @spicyj

    Fix typo

    spicyj authored
    Auditors: eater
Commits on Jun 12, 2013
  1. @xymostech

    Don't use $._ inside of <var>s

    xymostech authored
    Take every use of $._ inside of normal <var>s and move them into <div
    class="vars"> instead. Also, add some tests to the linter to throw errors when
    $._ is used in <var>s.
    Test Plan:
    Run linter (not with --fix) on the exercises, see that there are no
    errors related to $._ in <var>s. Visit a bunch of changed exercises locally,
    make sure that there are no errors in the javascript console.
    Reviewers: john, csilvers, eater
    Reviewed By: csilvers
    CC: alpert
    Differential Revision:
Commits on Apr 24, 2013
  1. @jeresig
Commits on Apr 22, 2013
  1. @jeresig

    Clean up the newly-changed HTML exercises and also fix up the constan…

    jeresig authored
    …tly-expanding whitespace problem in the cleaner.
Commits on Apr 17, 2013
  1. @cbhl
Commits on Apr 16, 2013
  1. @cbhl
  2. @jeresig
  3. @jeresig
  4. @kamens

    Translate the Yes/No correct answer specification for Divisibility Te…

    kamens authored
    …sts. This is one grain of sand in the exercise i18n effort and is more a proof of concept than a complete solution.
    Test Plan:
    Go to http://localhost:8098/math/arithmetic/factors-multiples/divisibility_tests/e/divisibility_tests?lang=boxes and verify that the Yes/No options are translated into boxes.
    Choose an answer at random and try to answer the problem. Do this multiple times. Verify that one of the options is treated as the correct answer for each problem, and the other
    option is treated as incorrect.
    Reviewers: csilvers, alpert
    Reviewed By: csilvers
    Differential Revision:
Commits on Jun 23, 2012
  1. @Christi
Commits on Jun 21, 2012
  1. @beneater


    beneater authored
    fix #24554
Commits on Jun 11, 2012
  1. @beneater

    Code review fixes

    beneater authored
  2. @beneater
Something went wrong with that request. Please try again.