Skip to content
Commits on Oct 22, 2015
  1. @csilvers

    Change from $._ and $.ngettext over to i18n._ and i18n.ngettext.

    csilvers committed
    Summary:
    With D22593 and followups, we can now move from $._ to i18n._,
    removing an (arbitrary) dependence of translation code on jquery.
    
    This is a mostly-automated process: .  First I found files that use $._
    and changed them to i18n._.  Then I added the necessary require lines,
    either reusing an existing require of i18n.js if it exists, or adding
    a new one if it didn't:
    
        git grep -l '$\._(' | xargs perl -pli -e 's/\$\._/i18n._/g'
        git grep -l '$\.ngettext(' | xargs perl -pli -e 's/\$\.ngettext/i18n.ngettext/g'
    
    I then cleaned up lint_i18n_strings.py, particularly
    StringInVarFilter.
    
    I also had to add 'no-undef' eslint directives to a bunch of files,
    since khan-exercises doesn't have a proper require() system, and
    depends on i18n being a global.
    
    Test Plan:
    build/lint_i18n_strings_test.py
    
    Ran
       python -mSimpleHTTPServer
    and visited
       http://localhost:8000/exercises-packed/adding_decimals.html
    and saw it render properly.
    
    Reviewers: john
    
    Reviewed By: john
    
    Subscribers: emily
    
    Differential Revision: https://phabricator.khanacademy.org/D22647
Commits on Oct 13, 2015
  1. @jaredly

    Add more specific types to fix 2 exercises on mobile

    jaredly committed
    Summary:
    Points, Lines and Planes & Caesar Cipher Decryption were both unanswerable on
    mobile, because they both want something other than an equasion or a number.
    With more specific grammars, (and in conjunction with a recent update to the
    iOS app), they can now be answered!
    
    These are the only two exercises that I found which were unanswerable for
    grammar-related reasons, and I don't think there are any more, at least within
    khan-exercises.
    
    Test Plan:
    Fire up khan-exercises locally (see readme), and try out both affected
    exercises. Verify that they are still answerable on the web.
    
    Reviewers: charlie, emily
    
    Reviewed By: emily
    
    Subscribers: andy, bryan, #ios
    
    Differential Revision: https://phabricator.khanacademy.org/D22360
Commits on Aug 17, 2015
  1. @xymostech

    Add data-type="text" to points_lines_and_planes for mobile testing.

    xymostech committed
    Summary:
    The iOS app isn't able to detect that the text box in
    points_lines_and_planes is supposed to allow letters and not just
    numbers, which hopefully this should help. We can't test that this works
    for the mobile app because there's a bug with local testing, but this
    does work on webapp and shouldn't affect mobile either.
    
    Test Plan:
     - Visit
       http://exercises.ka.local/exercises/points_lines_and_planes.html?debug&problem=name-plane
     - See that the question is still answerable.
    
    Reviewers: bryan, eater
    
    Reviewed By: eater
    
    Differential Revision: https://phabricator.khanacademy.org/D20501
Commits on Nov 20, 2014
  1. @allofthenorthwood @alopatin

    Rearrange answer area content within some exercises

    allofthenorthwood committed with alopatin
    See https://docs.google.com/a/khanacademy.org/spreadsheets/d/1wCONrsK1ujRCLal7bcxS0cVkfpfKiPzapt3SsMJ_zqI/edit#gid=0
    
    Color: Blue
    
    Test Plan:
    Take all hints and succesfully answer a question within each problem
    type for all modified exercises.
    
    Auditors: alex
Commits on Mar 5, 2014
  1. @spicyj

    Use requirejs for module loading

    spicyj committed
    Summary: Also did some misc cleanup in khan-exercise.js, mostly related to module-y things ("151 ++----"). I combined local jquery-ui into one file to make it easier to load.
    
    Test Plan:
    Opened addition_1, deriviative_intuition, graphing_points_2 locally, and all looked fine.
    
    In webapp/khan-exercises/, ran:
    
    ```
    npm install -g requirejs
    r.js -o requirejs.config.js
    ```
    
    then saw that /exercises/addition_1 looked right.
    
    Reviewers: eater, jack
    
    Reviewed By: jack
    
    CC: alex
    
    Differential Revision: http://phabricator.khanacademy.org/D7095
Commits on Jun 4, 2013
  1. @xymostech

    Manually i18nize all of the minor exercises

    xymostech committed
    Summary:
    Manually make modifications to all the exercises for i18n. Most of the problems revolved around:
    
    - Wrapping Strings in variables or graphies with `$._`
    - `data-if`s in the middle of sentences, that needed to be pulled out around the entire sentence
    - Strings that needed to be put into Plural objects for pluralization
    - Decoupling strings from logic
    
    Test Plan:
    Visit the changed exercises. Make sure the question renders
    correctly and there are no javascript errors. Take all the hints and make sure
    nothing is rendered incorrectly. Do the translations into box language, and
    make sure that everything from the languages is boxy.
    
    Reviewers: csilvers, john
    
    Reviewed By: csilvers
    
    CC: alpert, eater
    
    Differential Revision: http://phabricator.khanacademy.org/D2504
Commits on Apr 24, 2013
  1. @jeresig
Commits on Apr 22, 2013
  1. @jeresig

    Clean up the newly-changed HTML exercises and also fix up the constan…

    jeresig committed
    …tly-expanding whitespace problem in the cleaner.
Commits on Apr 17, 2013
  1. @cbhl
Commits on Apr 16, 2013
  1. @cbhl
  2. @jeresig
  3. @jeresig
Commits on Apr 21, 2012
  1. @spicyj

    These are actually coplanar...

    spicyj committed
Commits on Apr 18, 2012
  1. @beneater
  2. @beneater

    whitespace

    beneater committed
  3. @dddao @beneater
  4. @dddao @beneater

    4/09 8PM I forgot about Ben's last hint for Problem 5. But I'm not su…

    dddao committed with beneater
    …re I could connect them in a way that wouldn't be confusing. Any configuration of four points with D included will be not co-planar, but if you connect them, your mind can still perceive them as being a quadrilateral, which can be put on a plane.
    
    
    Instead, I'll add a second hint about connecting three points at a time to form triangles, and then asking if those triangles are co-planar.
  5. @dddao @beneater

    4/08 8:33 PM, typo in the hints section for problem 1, reworded anoth…

    dddao committed with beneater
    …er hint, and changed the solution format for problems 3-5 so that "Yes" choice always comes before "No"
  6. @dddao @beneater
  7. @dddao @beneater

    first commit

    dddao committed with beneater
Something went wrong with that request. Please try again.