Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Congruent triangles 2 - Isosceles Triangles #32123

Closed
KhanBugz opened this Issue · 2 comments

3 participants

@KhanBugz
Collaborator

Triangle ABC is an Isosceles triangle Therefore Angle ABC and Angle ACB should be Congruent

congruent_triangles_2.html?seed=139&problem=parr

Answer timeline

[]

Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/5.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; MAAU; .NET4.0C; InfoPath.2)

MathJax is loaded, ready, queue length: 0

User hash: 1094378922

@mirandaconrado

realbug

The angles here are correct, as they are created first and randomly. However, the code that creates the side lengths to display truncates to 1 decimal place (utils/graphie-geometry.js:469). Therefore, the triangle ABC appears to be isosceles, but it really isn't.

I think it's a bug, but don't know the best way to solve it.

@MattFaus

But the non-truncated side lengths are available in the Triangle.sideLengths property, so I think it's up to the caller to protect themselves from this scenario.

The easiest change I can think of to keep this from happening but not cause undue burden on excercise creators would be to change randomTriangleAngles.triangle() to pick angles such that this problem does not occur.

@beneater beneater closed this issue from a commit
@beneater beneater Fix issue with congruent_triangles_2 not showing x
fix #45164; fix #45163; fix #45162; fix #45155; fix #45143; fix #45142;
fix #45141; fix #45140; fix #45134; fix #45125; fix #45105; fix #45101;
fix #45098; fix #45094; fix #45087; fix #45082; fix #45076; fix #45065;
fix #45057; fix #45044; fix #45034; fix #44966; fix #44928; fix #44817;
fix #36534; fix #32123

Test plan: http://localhost:8000/exercises/congruent_triangles_2.html?seed=62&problem=parr&debug note that "x" is shown.
01f837a
@beneater beneater closed this in 01f837a
@jeresig jeresig referenced this issue from a commit in jeresig/khan-exercises
@beneater beneater Fix issue with congruent_triangles_2 not showing x
fix #45164; fix #45163; fix #45162; fix #45155; fix #45143; fix #45142;
fix #45141; fix #45140; fix #45134; fix #45125; fix #45105; fix #45101;
fix #45098; fix #45094; fix #45087; fix #45082; fix #45076; fix #45065;
fix #45057; fix #45044; fix #45034; fix #44966; fix #44928; fix #44817;
fix #36534; fix #32123

Test plan: http://localhost:8000/exercises/congruent_triangles_2.html?seed=62&problem=parr&debug note that "x" is shown.
e0127a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.