Small fix to graphie-3d -- make sure a closed path is drawn #84085
Conversation
… should be path([v1,v2,v3,true]) for path to be closed path.
|
Hey @ivanistheone can you point me to an example of where I can see this in action? |
|
Hi Ben, Check lines 70 to 88 in Also, why use |
|
ah.. makes sense. I'll pull this into graphie-to-png and redeploy that as well. |
Small fix to graphie-3d -- make sure a closed path is drawn
|
should be updated on graphie-to-png now |
|
I'm gonna revert this. It's causing this to happen: |
| @@ -267,7 +267,7 @@ $.extend(KhanUtil, { | |||
| // draw the sketch's lines | |||
| sketch.drawLines= function() { | |||
| return graph.path( | |||
| sketch.mappedVerts(), | |||
| sketch.mappedVerts().concat(true), | |||
There was a problem hiding this comment.
This is the problem.
For a sketch, mappedVerts() reports the verts on the visible side --- so don't need a closed path,
just to draw some lines.
In the context of face.drawBack the concat(true) makes sense to close the path.
My mistake --- I shouldn't have changed sketch.drawLines willy-nilly just because it looks like "the same thing."
Test plan: none Auditors: jack
Small fix to graphie-3d -- make sure path is drawn:
should be
to draw a closed path.