Skip to content
This repository

A mobile application for Khan Academy.

branch: master

Fix one of our video progress iOS bugs, this one triggered by play/pa…

…use/ended events when switching between videos.

Summary:
Since we recently switched to not reloading the entire video page when switching between videos, we haven't been hooking up appropriate events to the video player when switching. This means that if you load Video A, then switch to Video B, when you click on Start/Pause/Scrub on Video B you actually are sending /api/.../log events for Video A.

This was one of the sources of 'I just watched a video and no progress icons updated' ... but I don't think it's the only source.

...but no longer. I'd put an exclamation mark there if I knew how to escape it in my shell, but I can just never remember.

Test Plan:
On iPad
Log in
Load Video A
Switch to Video B
Click play, wait a few seconds, click pause
Verify that the progress icon for Video B immediately fills in

Reviewers: laura, alpert

Reviewed By: alpert

CC: mgp

Differential Revision: http://phabricator.khanacademy.org/D7169
latest commit 723473ed80
Ben Kamens kamens authored March 07, 2014
Octocat-spinner-32 css Increase selectivity of selectors to fix icons October 18, 2011
Octocat-spinner-32 exercises @ d18df13 Improve formatting of answer area. Fixes #110. Fixes #113. September 22, 2011
Octocat-spinner-32 img Remove some images (to move to parent project media folder) June 18, 2013
Octocat-spinner-32 js Fix one of our video progress iOS bugs, this one triggered by play/pa… March 07, 2014
Octocat-spinner-32 .gitignore Add in a separate file for testing (hidden behind gitignore). Remove … June 29, 2011
Octocat-spinner-32 .gitmodules Add in exercises submodule. August 25, 2011
Octocat-spinner-32 index.html Unisubs now returns milliseconds November 27, 2012
Something went wrong with that request. Please try again.