Simulated mouse + keyboard playback broken #146

Closed
jlfwong opened this Issue May 2, 2012 · 5 comments

Projects

None yet

2 participants

@jlfwong
Contributor
jlfwong commented May 2, 2012

Audio is working, but the simulated playback is broken.

Hit play on http://khan-labs-test.khan-academy.appspot.com/labs/code/759528655 and open up the console.

Uncaught TypeError: Cannot read property 'end' of null

Owner
jeresig commented May 3, 2012

So this is really weird - as far as I can tell before recording began the mouse cursor was already in the editor (rather than at position 0,0, which is where the default is). I should probably lock the editor to make SUPER sure that you can't accidentally click before it begins recording.

@jeresig jeresig added a commit that closed this issue May 7, 2012
@jeresig jeresig Change the logic for when selection commands are ignored. Only drop c…
…ommands when a selection immediately follows another selection AND they are identical - but keep them if there have been other commands in-between, even if they are over the same selection range. Fixes #151. (hopefully) Fixes #146.
419ff54
@jeresig jeresig closed this in 419ff54 May 7, 2012
@jeresig jeresig reopened this May 18, 2012
Owner
jeresig commented May 18, 2012

Sounds like this is still an issue, it happened here as well:
http://khan-labs-test.khan-academy.appspot.com/labs/code/estimating-pi-with-darts/792374042

Owner
jeresig commented May 18, 2012

One thing that I just noticed in this previous problem is that there is only 1 line of code, although Jamie says that the cursor was starting on the second line. Might make for an avenue of exploration.

Owner
jeresig commented May 21, 2012

This took way too long to figure out, but I think I finally have - it appears as if middle clicking causes the selection to change but there are no events being reported (and thus are not logged). I'm looking into this now.

Owner
jeresig commented May 22, 2012

OK. So I figured it out: if you blur the editor and then focus it again by only middle clicking it, this effectively causes an empty selection to be created without re-selecting from the previous selection. As far as I can tell this is the only time that this occurs. Either way I've improved the logic such that I'm now tracking this empty selection edge case and it seems to be working on my end. Will be tracking/discussing over here: http://phabricator.khanacademy.org/D55

@jeresig jeresig closed this May 22, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment