Permalink
Commits on Aug 10, 2016
  1. Build files

    Summary: Includes fix in last commit for rendering the x-axis label in the plotter to the right position.
    
    Test Plan:
    - See previous commit
    
    Auditors: kevinb
    shadaj committed Aug 10, 2016
  2. Fix x-axis labels being positioned with the wrong y-value

    Summary: Because of doing the divide by scale in the wrong place, the y position of the x-axis label would be too high with the xomManatee flag enabled. This fixes the wrong parentheses location to only divide if not with the xomManatee flag.
    
    Test Plan:
    - Verified in Perseus demo that the x-axis label is now rendered to the correct location
    
    Auditors: kevinb
    shadaj committed Aug 10, 2016
  3. Build files

    Summary:
    - eb68ac4 Update plotter to have styles closer to mock
    - 25d6f66 Make plotter hairlines display under other elements on the graph
    - f214e37 Reset zoomable on window resize
    - ff7a411 Use a full-width x-axis when rendering bar and line charts in the plotter widget
    - 560bd7e Merge branch 'master' of github.com:Khan/perseus
    - cf4f645 Add a null getUserInput function to the video widget
    - 850e90c Make bars in the plotter have a green color while they are being interacted with
    
    Test Plan:
    - See individual commits
    
    Auditors: kevinb
    shadaj committed Aug 10, 2016
  4. Update plotter to have styles closer to mock

    Summary:
    Changes from sync with Louis, including making plotter hairlines display above the grid, changing the dotplot point size, and decreasing the bottom padding of dotplots.
    
    {F550602}
    
    {F550604}
    
    Test Plan: - Verified in Perseus demo that all changes render correctly with the xomManatee flag enabled
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29878
    shadaj committed Aug 10, 2016
  5. Make plotter hairlines display under other elements on the graph

    Summary:
    Updates the plotter hairline styles to match the mockups, where the hairlines are below other elements such as bars and movable points.
    
    https://app.asana.com/0/132409062806753/166319175082274
    
    Test Plan: - Verified in Perseus demo that hairlines now are covered up by other elements on the graph
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29867
    shadaj committed Aug 10, 2016
  6. Use a full-width x-axis when rendering bar and line charts in the plo…

    …tter widget
    
    Summary:
    Implements the full-width x-axis from the mockups by hiding the "0" y-axis label and extending the x-axis to touch the edges of the graph container.
    
    {F550579}
    
    {F550610}
    
    https://app.asana.com/0/132409062806753/166319175082276
    
    Test Plan: - Verified in Perseus demo that with the xomManatee flag enabled, the "0" label is hidden and the horizontal axis extends to the edges of the container
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29865
    shadaj committed Aug 10, 2016
  7. Make bars in the plotter have a green color while they are being inte…

    …racted with
    
    Summary:
    Updates the bar styles in the plotter to match the mockup changes to have a green fill during interaction.
    
    {F550574}
    
    https://app.asana.com/0/132409062806753/166319175082272
    
    Test Plan: - Verified in Perseus demo that bars switch to green during interaction and return to blue after
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29862
    shadaj committed Aug 10, 2016
  8. Build files

    Summary:
    - e03ecdd Properly enable the xomManatee flag in the edit tab of content previews
    
    Test Plan:
    - See individual commits
    
    Auditors: kevinb
    shadaj committed Aug 10, 2016
  9. Properly enable the xomManatee flag in the edit tab of content previews

    Summary: Previously, the xomManatee flag was dependent on localStorage.xomManatee, which isn't set in webapp. Now, whenever the preview is for a touch device the xomManatee flag is set to true.
    
    Test Plan:
    - Verified in webapp after building Perseus that content is rendered with the xomManatee flag (http://localhost:8081/math/early-math/cc-early-math-counting-topic/cc-early-math-counting/e/counting-objects/edit/xbbb09a2e67bc1e04 as an example)
    - Verified that the previously incorrectly rendered SAT problem now has the graphs rendered correctly
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29856
    shadaj committed Aug 10, 2016
Commits on Aug 8, 2016
  1. Polish graphing widget xomManatee styles

    Summary: Includes cleanup of point-tooltip shadow management, removes shadows on selected points, disables crispedges on paths, and displays hairlines in the plotter widget.
    
    Test Plan:
    - Verified in Perseus demo that all styles render correctly
    - Verified that without the xomManatee flag all the widgets look the same as before
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29797
    shadaj committed Aug 8, 2016
  2. Implement new graph arrowhead styles

    Summary:
    Implements the new, non-curved, arrowheads for use with the graph widgets.
    
    {F550476}
    
    Test Plan:
    - Verified in Perseus demo that new styles are properly applied in grapher widgets
    - Verified in Perseus demo that old arrowheads are used when the xomManatee flag is not set
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29787
    shadaj committed Aug 8, 2016
Commits on Aug 6, 2016
  1. Implement new highlight styles for movable points

    Summary: Implements the new movable points design where when highlighted, the border dissapears and the point shrinks.
    
    Test Plan:
    - Verified in Perseus demo that movable points have the new styles
    - Verified in Perseus demo that movable points correctly switch between the normal and highlighted styles
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29758
    shadaj committed Aug 5, 2016
Commits on Aug 5, 2016
  1. Implement updated styles for the interactive-graph widget

    Summary: Implements changes discussed during sync with Louis about the new graph styles. Changes the background of the graph as well as stroke widths for gridlines and the axes.
    
    Test Plan: - Verified in Perseus demo that interactive-graph widgets now render with the latest styles
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29709
    shadaj committed Aug 5, 2016
  2. Implement new number line styles

    Summary:
    Implements new colors, line styles, and point modes to match the mockups.
    
    {F550207}
    
    Test Plan:
    - Verified in Perseus demo that number lines are rendered properly with all new styles applied
    - Verified that without the xomManatee flag, number lines look the same as before
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29695
    shadaj committed Aug 4, 2016
  3. Implement new styles for line charts

    Summary: Implements new colors, point styles, and adds dragging prompt to line charts so that they match up with the mockups.
    
    Test Plan:
    - Verified in Perseus demo that line charts have all new styles defined in the mockups
    - Verified that without the xomManatee flag line charts look the same
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29665
    shadaj committed Aug 4, 2016
  4. Fix movable point shadows not appearing in Safari

    Summary: Fix filter syntax error and place filter on the SVG's parent
    
    Test Plan: - Verified in Safari that drop shadows for movable points appear in Safari
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29706
    shadaj committed Aug 5, 2016
  5. Add additional classes to content preview container to better simulat…

    …e applied styles
    
    Summary: Adds the bibliotron-(exercise/article) and fonts-loaded classes so that exercise use the latest widget styles and text is rendered in Proxima Nova.
    
    Test Plan:
    - Verified in exercise and article editors that previews now render text in Proxima Nova
    - Verified in exercise editor preview that multiple choice widgets use the latext XOM styles
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29698
    shadaj committed Aug 4, 2016
Commits on Aug 4, 2016
  1. Implement new styles for bar charts

    Summary:
    Brings over changes to sizing, axis drawing, bar manipulation, and colors to the bar chart with the xomManatee flag enabled.
    
    {F550133}
    
    Test Plan:
    - Verified in Perseus demo that all styles match the bar chart mockups
    - Verified that without the xomManatee flag, bar charts look the same as before
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29654
    shadaj committed Aug 3, 2016
  2. Implement new styles for dot and picture plots

    Summary:
    Implements the stylistic changes to the dot and picture plots to have a full width bottom bar, use new colors, and display a prompt for adding points.
    
    {F549936}
    
    https://app.asana.com/0/132409062806753/162844846760884
    
    Test Plan:
    - Verified in Perseus demo that dot and picture plots are rendered with new styles but still have the same functionality
    - Verified in Perseus demo that dot and picture plots look the same without the xomManatee flag
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29602
    shadaj committed Aug 2, 2016
Commits on Aug 2, 2016
  1. Transfer style changes from interactive-graph to grapher

    Summary: Brings over the movable point and grid stylistic changes made to the interactive-graph widget over to the grapher widget.
    
    Test Plan:
    - Verified in Perseus demo that the grapher widget has all the new XOM graph styles
    - Verified that without the xomManatee flag set, the graph looks and behaves the same as before
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29591
    shadaj committed Aug 2, 2016
  2. Update grid styles to match mockups

    Summary:
    Updates the grid colors, label positions, and other styles to match up with the new interactive graph mockups.
    
    {F549809}
    
    Test Plan:
    - Verified that the new grid styles match up with the interactive graph mockups
    - Verified that without the xomManatee flag, the interactive graph has the same styles as before
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29559
    shadaj committed Aug 2, 2016
  3. Make article previews scrollable again

    Summary: Due to the change to set overflow: hidden on the body, article previews were not scrollable. Now, when an article preview is being rendered the iframe will override the CSS style to set overflow: scroll.
    
    Test Plan: - Verified in the article editor that it is possible to scroll article previews but not other types of content
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29535
    shadaj committed Aug 1, 2016
  4. Update line colors in the interactive graph to match the mockup

    Summary: Previously, the lines would use the green interactive element color. Now, they use the blue color defined in the mockups.
    
    Test Plan:
    - Verified in Perseus demo that with xomManatee enabled, the line colors match the mockup
    - Verified that without xomManatee enabled, lines still have the old styles
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29543
    shadaj committed Aug 1, 2016
  5. Update tooltip styling to match mockup changes

    Summary:
    Updates the styling applied to tooltips and the out-of-bounds behavior to match the mockup changes.
    
    {F549811}
    
    Test Plan:
    - Verified that a trash tooltip is displayed when points are dragged out of bounds
    - Verified that tooltips have the same background as the tooltips in the mockups
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29549
    shadaj committed Aug 1, 2016
Commits on Jul 28, 2016
  1. Build files

    Summary:
    - d331a90 Improve iframe height measurement to properly handle the expression editor
    - 6aa9168 Add graded group set widget
    - 10111b8 Update 'Check Answer' to 'Check' and wrap strings with i18n.()
    - 4057df3 Add warnings when a graded group doesn't a prompt or at least one widget
    - f5d65e5 Some lint fixes
    
    Test Plan:
    - See individual commits
    
    Auditors: kevinb
    shadaj committed Jul 28, 2016
  2. Improve iframe height measurement to properly handle the expression e…

    …ditor
    
    Summary: Previously, the expression editor popover would be clipped because it has an absolute position. Now, we measure bounding boxes to calculate what the iframe height should be so the popover is no longer clipped.
    
    Test Plan:
    - Verified in Perseus demo and webapp that expression editor popovers are not clipped
    - Verified that previous resizing behavior is maintained
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29391
    shadaj committed Jul 27, 2016
Commits on Jul 26, 2016
  1. Implement new styles for movable points on interactive-graph

    Summary:
    Changes shape and shadow of points, adds hairlines when dragging points, and displays tooltips when enabled on the interactive graph
    
    {F548217}
    
    Test Plan:
    - Verify that all new behavior works as expected on mobile devices
    - Verify that devices without the xomManatee flag still render the original experience
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29205
    shadaj committed Jul 21, 2016
  2. Update preview widths to match content width in webapp

    Summary: Previously, the preview widths for tablet and desktop were based on the full device widths. Now the widths match the maximum width set when rendering content in webapp.
    
    Test Plan: - Verified in Perseus demo that the correct widths are set for tablet and desktop previews
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29211
    shadaj committed Jul 21, 2016
Commits on Jul 21, 2016
  1. Build files

    Summary:
    - 9f3bd67 Wait for MathJax to load before initializing Perseus
    - 42581fc Fix ugliness and first pass at new MC instructions
    - 9f49c48 Always use the advanced Expression keypad
    
    Test Plan:
    - See individual commits
    
    Auditors: kevinb
    shadaj committed Jul 21, 2016
  2. Wait for MathJax to load before initializing Perseus

    Summary: Fixes a failing unit test where MathJax would not be defined when Perseus.init was run. Now, if the promise for Khan.mathJaxLoaded is defined, we wait on it before initializing Perseus.
    
    Test Plan: - Verified that previously failing webapp test now passes with `tools/runtests.py --max-size=large js_css_packages/third_party_deps_sufficient_test.py`
    
    Reviewers: csilvers, kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D29127
    shadaj committed Jul 19, 2016
Commits on Jul 13, 2016
  1. Build files

    Summary: Includes changes for reloading iframes when the viewport changes.
    
    Test Plan:
    - See individual commits
    
    Auditors: kevinb
    shadaj committed Jul 13, 2016
  2. Force iframes to reload when the viewport changes

    Summary:
    To ensure that all styles match the viewport they are being rendered in, we force iframes to reload whenever there is a change in viewport size.
    
    https://app.asana.com/0/144847879372674/149957247718202
    
    Test Plan:
    - Verified in content editors that iframes are reloaded on viewport change
    - Verified that iframes do not reload when loading new content into the same viewport
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D28976
    shadaj committed Jul 13, 2016
Commits on Jul 12, 2016
  1. Build files

    Summary: Includes changes to remove the noframe device type.
    
    Test Plan:
    - Verify in browser that content editor loads with appropriate changes to webapp
    
    Auditors: kevinb
    shadaj committed Jul 12, 2016
  2. Remove all references to the noframe device type

    Summary: Now that DeviceFramer has the nochrome property, we can get rid of the noframe device type and replace those usages with normal device types. Now, in the edit tab, previews are shown without a device chrome and in the preview tab, previews are shown with a device chrome.
    
    Test Plan: - Verified in Perseus demo that all functionality works without references to noframe
    
    Reviewers: kevinb
    
    Reviewed By: kevinb
    
    Subscribers: jared
    
    Differential Revision: https://phabricator.khanacademy.org/D28964
    shadaj committed Jul 12, 2016
  3. Build files

    Summary:
    - 577a228 Add margin to mobile preview for articles
    - 1485490 Add the nochrome property to DeviceFramer for displaying containers but not device chromes
    - 93db4fa Make iframe containers render with an initial height of 100% so that content takes up the full height of device frames
    - 1bcb572 Update math-input to the latest version
    - cd625fb Fix spacing violations in ./node
    - 2659fb9 Fix spacing violation in webpack config
    - fe565ff Add spacing rules to the lint-disable lines
    
    Test Plan:
    - See individual commits
    
    Auditors: kevinb
    shadaj committed Jul 12, 2016