Add pointer-events:none; to hidden font container #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: opacity:0 isn't enough for Firefox to ignore the hiddent font container which results in the text cursor showing up and mouse events not getting through to the canvas. This diff adds pointer-events:none; to the container so that Firefox ignores it completely. Test Plan: - build live-editor - load http://localhost:8080/computer-programming/new/pjs - hover over the upper-left corner of the canvas - see that the mouse cursor is always the arrow Reviewers: ian john
kevinbarabash
added a commit
to Khan/live-editor
that referenced
this pull request
Dec 5, 2017
Summary: opacity:0; isn't enough for Firefox to ignore processing-js' hiddent font container which results in the text cursor showing up and mouse events not getting through to the canvas. This diff adds pointer-events:none; to the container so that Firefox ignores it completely. Change to processing-js is in Khan/processing-js#11. Test Plan: - npm run build - load http://localhost:8080/computer-programming/new/pjs (in Firefox) - hover over the upper-left corner of the canvas - see that the mouse cursor is always the arrow Reviewers: joshua, idr Reviewed By: idr Differential Revision: https://phabricator.khanacademy.org/D41143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opacity:0;isn't enough for Firefox to ignore the hiddent fontcontainer which results in the text cursor showing up and mouse
events not getting through to the canvas. This diff adds
pointer-events:none;to the container so that Firefox ignoresit completely. Diffs for live-editor and webapp will be done using
phabricator.
Test Plan: