New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias should allow symbol imports #22

Open
benjaminjkraft opened this Issue Mar 23, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@benjaminjkraft
Member

benjaminjkraft commented Mar 23, 2018

Currently, we only ever generate imports of modules, even if your old import was importing a symbol from a module and you're using auto-alias. We should also have a flag like FROM that says to use symbol imports whereever possible; then FROM would say use module from-imports whereever possible.

(None of this affects KA much, since we generally disallow symbol imports, but the rest of the world uses them surprisingly much!)

@benjaminjkraft benjaminjkraft changed the title from Alias should alow symbol imports to Alias should allow symbol imports Mar 23, 2018

benjaminjkraft added a commit that referenced this issue Mar 24, 2018

Add a test for symbol imports
We don't use these at KA, but the rest of the world does.  This was
mostly to convince myself we at least generate legal code.  I also
included a skipped test for #22, which I wrote first.

Test plan: `make check`

Auditors: csilvers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment