New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC tota11y as Chrome extension/Firefox add-on #131

Open
wants to merge 16 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@nickytonline
Copy link

nickytonline commented Sep 15, 2018

Came across #62 after I created this. Thought it'd be fun to make it an extension and apparently others do too according to #62.

tota11y

@khanbot

This comment has been minimized.

Copy link

khanbot commented Sep 15, 2018

Hey @nickytonline,

Thanks for the PR! Mind signing our Contributor License Agreement?

When you've done so, go ahead and comment [clabot:check] and I'll check again.

Yours truly,
khanbot

@nickytonline nickytonline force-pushed the nickytonline:poc/tota11y-as-chrome-extension branch from c3e98ba to e918cff Sep 15, 2018

@nickytonline nickytonline force-pushed the nickytonline:poc/tota11y-as-chrome-extension branch from e918cff to c691341 Sep 15, 2018

@nickytonline

This comment has been minimized.

Copy link

nickytonline commented Sep 15, 2018

[clabot:check]

@khanbot

This comment has been minimized.

Copy link

khanbot commented Sep 15, 2018

CLA signature looks good 👍

Seperated content script communication from t0ta11y script so that it…
… can still run as a bookmarklet on it's own without any extension specific stuff attached to it.

@nickytonline nickytonline force-pushed the nickytonline:poc/tota11y-as-chrome-extension branch from 20d3d7b to aa0760f Sep 15, 2018

@nickytonline

This comment has been minimized.

Copy link

nickytonline commented Sep 15, 2018

I completely forgot that you can use the same API and conventions for Firefox, so this will work as an extension in FireFox and Chrome.

@nickytonline nickytonline changed the title Poc/tota11y as Chrome extension POC tota11y as Chrome extension/Firefox add-on Sep 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment