Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build cl.hpp for releases, not just cl2.hpp #25

Closed
oddhack opened this issue Dec 9, 2016 · 6 comments · Fixed by #104
Closed

Build cl.hpp for releases, not just cl2.hpp #25

oddhack opened this issue Dec 9, 2016 · 6 comments · Fixed by #104
Assignees

Comments

@oddhack
Copy link

oddhack commented Dec 9, 2016

Could the release builds be extended to include generating the old cl.hpp as well? That would let me remove it from the OpenCL registry, where it's the only header file still stored there instead of in github.

@jrprice
Copy link
Contributor

jrprice commented Dec 9, 2016

Personally I'd like to get rid of the old cl.hpp completely, given that the new cl2.hpp supports all the 1.x versions of OpenCL as well and has many other general improvements. That would mean that the registry could just point users to cl2.hpp for all versions of OpenCL.

I'll see if I can get agreement to do this from the working group.

@oddhack
Copy link
Author

oddhack commented Dec 9, 2016

That would be even better. I didn't realize cl2.hpp was usable for CL 1.x (largely because the name suggests otherwise :-) )

@jrprice
Copy link
Contributor

jrprice commented Dec 9, 2016

I agree, the name may be misleading here. It's not backwards compatible with the previous version which is why there was a name change when adding the 2.0 support. We may want to consider another name change if we want to present this as a 'one size fits all' header.

@kpet
Copy link
Contributor

kpet commented Sep 16, 2019

I think a name change is indeed the way to go. The current state is pretty confusing and it wouldn't be hard to keep backwards compatibility with applications using cl2.hpp. opencl.hpp? Any other suggestions?

@kpet kpet assigned kpet and unassigned jrprice and kepatil Jun 9, 2020
kpet added a commit to kpet/OpenCL-CLHPP that referenced this issue Jun 9, 2020
And test cl2.hpp on all OpenCL versions except 1.0 and 1.1 (too
many failures to deal with as part of this change).

Contrinutes to KhronosGroup#25

Signed-off-by: Kévin Petit <kpet@free.fr>
kpet added a commit to kpet/OpenCL-CLHPP that referenced this issue Jun 9, 2020
And test cl2.hpp on all OpenCL versions except 1.0 and 1.1 (too
many failures to deal with as part of this change).

Contrinutes to KhronosGroup#25

Signed-off-by: Kévin Petit <kpet@free.fr>
kpet added a commit that referenced this issue Jun 10, 2020
* Remove deprecated cl.hpp

And test cl2.hpp on all OpenCL versions except 1.0 and 1.1 (too
many failures to deal with as part of this change).

Contrinutes to #25

Signed-off-by: Kévin Petit <kpet@free.fr>

* Add OpenCL 3.0 to the list of known versions

Retain 2.2 as the default until 3.0 is final.

Signed-off-by: Kévin Petit <kpet@free.fr>

* fix typo

* Bump minimum required CMake version to 3.0
kpet added a commit to kpet/OpenCL-CLHPP that referenced this issue Jun 10, 2020
No changes to the moved code (that's why I wanted to do this
as a separate PR).

Contributes to KhronosGroup#25

Signed-off-by: Kévin Petit <kpet@free.fr>
bashbaug pushed a commit that referenced this issue Jun 10, 2020
No changes to the moved code (that's why I wanted to do this
as a separate PR).

Contributes to #25

Signed-off-by: Kévin Petit <kpet@free.fr>
kpet added a commit to kpet/OpenCL-CLHPP that referenced this issue Jun 12, 2020
- Keep a cl2.hpp symlink for now for backwards compability
- Remove "CL2" from the name of examples
- Use opencl.hpp directly in tests and examples
- Remove a couple of unused variables in the trivial example

Fixes KhronosGroup#25

Signed-off-by: Kévin Petit <kpet@free.fr>
kpet added a commit to kpet/OpenCL-CLHPP that referenced this issue Sep 1, 2020
- Keep a cl2.hpp symlink for now for backwards compability
- Remove "CL2" from the name of examples
- Use opencl.hpp directly in tests and examples
- Remove a couple of unused variables in the trivial example

Fixes KhronosGroup#25

Signed-off-by: Kévin Petit <kpet@free.fr>

# Conflicts:
#	include/CL/cl2.hpp
@kpet kpet closed this as completed in #104 Sep 2, 2020
kpet added a commit that referenced this issue Sep 2, 2020
- Keep a cl2.hpp symlink for now for backwards compability
- Remove "CL2" from the name of examples
- Use opencl.hpp directly in tests and examples
- Remove a couple of unused variables in the trivial example

Fixes #25

Signed-off-by: Kévin Petit <kpet@free.fr>

# Conflicts:
#	include/CL/cl2.hpp
@rajhlinux
Copy link

I was getting compiler errors and never knew that cl2.hpp is the replacement and updated header file for cl.hpp

So many github projects like "Caffe" (Deep learning framework) and many others have not updated to cl2.hpp and getting this error on 2022... At least this thread clear things up.

@bashbaug
Copy link
Contributor

Would it be helpful to describe this more explicitly in the README? It currently describes cl2.hpp (and how it has been renamed to opencl.hpp), but there is currently no description for cl.hpp.

It would be nice to add more clarification to the Doxygen docs also, though it is at least mentioned there:

There are numerous compatibility, portability and memory management fixes in the new header as well as additional OpenCL 2.0 features. As a result the header is not directly backward compatible and for this reason we release it as opencl.hpp rather than a new version of cl.hpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants