New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build cl.hpp for releases, not just cl2.hpp #25
Comments
Personally I'd like to get rid of the old I'll see if I can get agreement to do this from the working group. |
That would be even better. I didn't realize cl2.hpp was usable for CL 1.x (largely because the name suggests otherwise :-) ) |
I agree, the name may be misleading here. It's not backwards compatible with the previous version which is why there was a name change when adding the 2.0 support. We may want to consider another name change if we want to present this as a 'one size fits all' header. |
I think a name change is indeed the way to go. The current state is pretty confusing and it wouldn't be hard to keep backwards compatibility with applications using |
And test cl2.hpp on all OpenCL versions except 1.0 and 1.1 (too many failures to deal with as part of this change). Contrinutes to KhronosGroup#25 Signed-off-by: Kévin Petit <kpet@free.fr>
And test cl2.hpp on all OpenCL versions except 1.0 and 1.1 (too many failures to deal with as part of this change). Contrinutes to KhronosGroup#25 Signed-off-by: Kévin Petit <kpet@free.fr>
* Remove deprecated cl.hpp And test cl2.hpp on all OpenCL versions except 1.0 and 1.1 (too many failures to deal with as part of this change). Contrinutes to #25 Signed-off-by: Kévin Petit <kpet@free.fr> * Add OpenCL 3.0 to the list of known versions Retain 2.2 as the default until 3.0 is final. Signed-off-by: Kévin Petit <kpet@free.fr> * fix typo * Bump minimum required CMake version to 3.0
No changes to the moved code (that's why I wanted to do this as a separate PR). Contributes to KhronosGroup#25 Signed-off-by: Kévin Petit <kpet@free.fr>
No changes to the moved code (that's why I wanted to do this as a separate PR). Contributes to #25 Signed-off-by: Kévin Petit <kpet@free.fr>
- Keep a cl2.hpp symlink for now for backwards compability - Remove "CL2" from the name of examples - Use opencl.hpp directly in tests and examples - Remove a couple of unused variables in the trivial example Fixes KhronosGroup#25 Signed-off-by: Kévin Petit <kpet@free.fr>
- Keep a cl2.hpp symlink for now for backwards compability - Remove "CL2" from the name of examples - Use opencl.hpp directly in tests and examples - Remove a couple of unused variables in the trivial example Fixes KhronosGroup#25 Signed-off-by: Kévin Petit <kpet@free.fr> # Conflicts: # include/CL/cl2.hpp
- Keep a cl2.hpp symlink for now for backwards compability - Remove "CL2" from the name of examples - Use opencl.hpp directly in tests and examples - Remove a couple of unused variables in the trivial example Fixes #25 Signed-off-by: Kévin Petit <kpet@free.fr> # Conflicts: # include/CL/cl2.hpp
I was getting compiler errors and never knew that cl2.hpp is the replacement and updated header file for cl.hpp So many github projects like "Caffe" (Deep learning framework) and many others have not updated to cl2.hpp and getting this error on 2022... At least this thread clear things up. |
Would it be helpful to describe this more explicitly in the README? It currently describes cl2.hpp (and how it has been renamed to opencl.hpp), but there is currently no description for cl.hpp. It would be nice to add more clarification to the Doxygen docs also, though it is at least mentioned there:
|
Could the release builds be extended to include generating the old cl.hpp as well? That would let me remove it from the OpenCL registry, where it's the only header file still stored there instead of in github.
The text was updated successfully, but these errors were encountered: