Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for __remove_address_space in C++ for OpenCL #647

Merged
merged 10 commits into from
Dec 15, 2021
Merged

Documentation for __remove_address_space in C++ for OpenCL #647

merged 10 commits into from
Dec 15, 2021

Conversation

Topotuna
Copy link
Contributor

Documentations provided along with __remove_address_space functionality in C++ for OpenCL.

Fixes: llvm.org/PR45326

Differential Revision: reviews.llvm.org/D106785

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2021

CLA assistant check
All committers have signed the CLA.

@kpet kpet requested a review from AnastasiaStulova August 11, 2021 12:29
@StuartDBrady StuartDBrady added the C++ for OpenCL C++ for OpenCL documentation related label Oct 4, 2021
@Topotuna Topotuna marked this pull request as ready for review December 6, 2021 15:39
Review suggestion

Co-authored-by: Anastasia Stulova <38433336+AnastasiaStulova@users.noreply.github.com>
cxx4opencl/address_spaces.txt Outdated Show resolved Hide resolved
cxx4opencl/address_spaces.txt Outdated Show resolved Hide resolved
cxx4opencl/address_spaces.txt Outdated Show resolved Hide resolved
Topotuna and others added 3 commits December 10, 2021 15:09
Co-authored-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
Co-authored-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
cxx4opencl/address_spaces.txt Show resolved Hide resolved
cxx4opencl/address_spaces.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@AnastasiaStulova AnastasiaStulova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

This needs to be merged after #616

@AnastasiaStulova AnastasiaStulova merged commit 1525c7b into KhronosGroup:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ for OpenCL C++ for OpenCL documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants