Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming style guide violations: XR_EXTX_overlay #42

Closed
rpavlik opened this issue Mar 23, 2020 · 2 comments
Closed

Naming style guide violations: XR_EXTX_overlay #42

rpavlik opened this issue Mar 23, 2020 · 2 comments

Comments

@rpavlik
Copy link
Contributor

@rpavlik rpavlik commented Mar 23, 2020

There are two enum types in this extension whose value names violate the style guide. Given that this is tagged as provisional, I suspect we can simply fix these (without leaving the old ones as aliases) for a release in the near future.

See the PR by a community member that brought this to my attention: KhronosGroup/OpenXR-SDK-Source#171


Messages for XrOverlaySessionCreateFlagBitsEXTX

Error: registry/xr.xml:1342: Got an enum value whose name does not match the pattern: got XR_OVERLAY_SESSION_CREATE_RELAXED_DISPLAY_TIME_EXTX but expected something that ended with _BIT_EXTX due to typename being XrOverlaySessionCreateFlagBitsEXTX


Messages for XrOverlayMainSessionFlagBitsEXTX

Error: registry/xr.xml:1339: Got an enum value whose name does not match the pattern: got XR_MAIN_SESSION_BIT_ENABLED_COMPOSITION_LAYER_INFO_DEPTH_EXTX but expected something that started with XR_OVERLAY_MAIN_SESSION due to typename being XrOverlayMainSessionFlagBitsEXTX
Error: registry/xr.xml:1339: Got an enum value whose name does not match the pattern: got XR_MAIN_SESSION_BIT_ENABLED_COMPOSITION_LAYER_INFO_DEPTH_EXTX but expected something that ended with _BIT_EXTX due to typename being XrOverlayMainSessionFlagBitsEXTX

@rpavlik-bot

This comment has been minimized.

Copy link
Collaborator

@rpavlik-bot rpavlik-bot commented Mar 23, 2020

An issue (number 1318) has been filed to correspond to this issue in the internal Khronos GitLab.

If you have a Khronos account, you can access that issue at KHR:openxr/openxr#1318.

@rpavlik

This comment has been minimized.

Copy link
Contributor Author

@rpavlik rpavlik commented Mar 28, 2020

Fixed in 1.0.8.

@rpavlik rpavlik closed this Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.