Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section 10.1: xrEnumerateSwapchainImages images parameter inconsistency #5

Closed
pH5 opened this issue Mar 21, 2019 · 2 comments

Comments

@pH5
Copy link

commented Mar 21, 2019

10.1. Swapchain Image Management
Parameter Descriptions

  • images is a pointer to an array of graphics API-specific XrSwapchainImage structures based off of XrSwapchainImageBaseHeader. It can be NULL if imageCapacityInput is 0.

vs

Valid Usage (Implicit)

  • If imageCapacityInput is not 0, images must be a pointer to an array of imageCapacityInput XrSwapchainImageBaseHeader structures

images should never be a pointer to an array of XrSwapchainImageBaseHeader structures, it must be an array of (larger) graphics API-specific structures that each start with a base header.

Should this state that they all must be of the same type?

@brycehutchings

This comment has been minimized.

Copy link

commented Mar 25, 2019

Agreed they should be homogeneous in type and never the literal XrSwapchainImageBaseHeader type.

@rpavlik

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

Fixed in 1.0.0 (valid usage generation needed adjustment to handle these types of parameters): now says "If imageCapacityInput is not 0, images must be a pointer to an array of imageCapacityInput XrSwapchainImageBaseHeader-based structures. See also: XrSwapchainImageD3D11KHR, XrSwapchainImageOpenGLESKHR, XrSwapchainImageD3D12KHR, XrSwapchainImageOpenGLKHR, XrSwapchainImageVulkanKHR"

@rpavlik rpavlik added the bug label Jul 30, 2019

@rpavlik rpavlik closed this Jul 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.