Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve extension 48 for XR_MND_egl_enable #39

Merged
merged 1 commit into from Nov 21, 2019

Conversation

@emersion
Copy link
Contributor

emersion commented Oct 28, 2019

This new extension will enable EGL.

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Oct 28, 2019

CLA assistant check
All committers have signed the CLA.

@emersion emersion force-pushed the emersion:gles-wayland branch from 2ce9608 to e54a018 Oct 28, 2019
@emersion emersion changed the title Reserve extension 48 for XR_KHR_opengl_es_enable_wayland Reserve extension 48 for XR_KHR_opengl_es_enable_egl Oct 28, 2019
@ddevault

This comment was marked as resolved.

Copy link

ddevault commented Oct 28, 2019

Please hold on merging this while we discuss it in greater detail.

@emersion emersion force-pushed the emersion:gles-wayland branch from e54a018 to fbbe340 Oct 28, 2019
@emersion emersion changed the title Reserve extension 48 for XR_KHR_opengl_es_enable_egl Reserve extension 48 for XR_KHR_egl_enable Oct 28, 2019
@emersion emersion force-pushed the emersion:gles-wayland branch from fbbe340 to 59f2850 Oct 28, 2019
@emersion emersion changed the title Reserve extension 48 for XR_KHR_egl_enable [WIP] Reserve extension 48 for XR_KHR_egl_enable Oct 28, 2019
@ddevault

This comment has been minimized.

Copy link

ddevault commented Oct 29, 2019

Okay, we're ready to have this merged.

@emersion emersion changed the title [WIP] Reserve extension 48 for XR_KHR_egl_enable Reserve extension 48 for XR_KHR_egl_enable Oct 29, 2019
@emersion emersion force-pushed the emersion:gles-wayland branch from 59f2850 to c7ea483 Nov 1, 2019
@emersion emersion changed the title Reserve extension 48 for XR_KHR_egl_enable Reserve extension 48 for XR_MND_egl_enable Nov 1, 2019
@emersion

This comment has been minimized.

Copy link
Contributor Author

emersion commented Nov 1, 2019

Renamed to XR_MND_egl_enable.

@ddevault

This comment has been minimized.

Copy link

ddevault commented Nov 6, 2019

Bump. This should be merged ASAP.

@emersion

This comment has been minimized.

Copy link
Contributor Author

emersion commented Nov 16, 2019

@rpavlik

This comment has been minimized.

Copy link
Contributor

rpavlik commented Nov 21, 2019

This reservation will be reserved, though the extension number will probably differ due to collision with internal changes.

@rpavlik rpavlik changed the base branch from master to staging Nov 21, 2019
@rpavlik rpavlik merged commit 0597a04 into KhronosGroup:staging Nov 21, 2019
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@rpavlik

This comment has been minimized.

Copy link
Contributor

rpavlik commented Nov 21, 2019

It will actually be number 49 in the upcoming patch release.

rpavlik added a commit that referenced this pull request Nov 22, 2019
Patch release for the 1.0 series.

Updates version to 1.0.4.

### GitHub Pull Requests

- Spec
  - Clarify Monado headless extension behavior related to `xrWaitFrame`
    <#38>
- Registry
  - Reserve a Monado EGL extension
    <#39>

### Internal issues

- General, Build, Other
  - Remove unused/unneeded files (internal MR 1609)
- Spec
  - Clarify subaction path description for XrActiveActionSet (internal MR 1592,
    internal issues 1243 and 1244)
  - Resolve misleading use of `xrLocateViews` before `xrWaitFrame` in helloXR
    and spec (internal MR 1584, internal issue 1227, public issue
    <KhronosGroup/OpenXR-SDK-Source#134>)
- Registry
  - Add `XR_EXT_conformance_automation` extension, for use **only** by
    conformance testing (internal MR 1577, 1608)
rpavlik added a commit to KhronosGroup/OpenXR-SDK-Source that referenced this pull request Nov 22, 2019
Patch release for the 1.0 series.

This release includes some fixes, extensions, and a small build system change:
the build system is now configured to use C++14. No code changes in the loader
or layers have yet taken place that require C++14. **Please file an issue** in
OpenXR-SDK-Source if there is some deployment platform where you would be unable
to use a loader making use of C++14 features.

### GitHub Pull Requests

These had been integrated into the public repo incrementally.

- General, Build, Other
  - #141 - Support system libs better (permit system jsoncpp, etc. for easier
    packaging)
- hello_xr
  - #144 - Fix hello_xr when running under Linux OpenGL X11
- Registry
  - Reserve a Monado EGL extension
    <KhronosGroup/OpenXR-Docs#39>

### Internal issues

- General, Build, Other
  - Switch C++ standard version to C++14 (internal MR 1602)
  - Remove unused/unneeded files (internal MR 1609)
- Loader
  - Fix typo in parameter/member names (internal MR 1607, internal issue 1233)
  - Fix deprecated usage of JsonCpp (internal MR 1604, internal issue 1212)
- hello_xr
  - Resolve misleading use of `xrLocateViews` before `xrWaitFrame` in helloXR
    and spec (internal MR 1584, internal issue 1227, public issue
    <#134>)
- Registry
  - Add `XR_EXT_conformance_automation` extension, for use **only** by
    conformance testing (internal MR 1577, 1608)
rpavlik added a commit to KhronosGroup/OpenXR-SDK that referenced this pull request Nov 22, 2019
Patch release for the 1.0 series.

This release includes some fixes, extensions, and a small build system change:
the build system is now configured to use C++14. No code changes in the loader
or layers have yet taken place that require C++14. **Please file an issue** in
OpenXR-SDK-Source if there is some deployment platform where you would be unable
to use a loader making use of C++14 features.

### GitHub Pull Requests

These had been integrated into the public repo incrementally.

- General, Build, Other
  - #141 - Support system libs better (permit system jsoncpp, etc. for easier
    packaging)
- hello_xr
  - #144 - Fix hello_xr when running under Linux OpenGL X11
- Registry
  - Reserve a Monado EGL extension
    <KhronosGroup/OpenXR-Docs#39>

### Internal issues

- General, Build, Other
  - Switch C++ standard version to C++14 (internal MR 1602)
  - Remove unused/unneeded files (internal MR 1609)
- Loader
  - Fix typo in parameter/member names (internal MR 1607, internal issue 1233)
  - Fix deprecated usage of JsonCpp (internal MR 1604, internal issue 1212)
- hello_xr
  - Resolve misleading use of `xrLocateViews` before `xrWaitFrame` in helloXR
    and spec (internal MR 1584, internal issue 1227, public issue
    <KhronosGroup/OpenXR-SDK-Source#134>)
- Registry
  - Add `XR_EXT_conformance_automation` extension, for use **only** by
    conformance testing (internal MR 1577, 1608)
rpavlik added a commit to KhronosGroup/OpenXR-Registry that referenced this pull request Nov 22, 2019
Patch release for the 1.0 series.

Updates version to 1.0.4.

### GitHub Pull Requests

- Spec
  - Clarify Monado headless extension behavior related to `xrWaitFrame`
    <KhronosGroup/OpenXR-Docs#38>
- Registry
  - Reserve a Monado EGL extension
    <KhronosGroup/OpenXR-Docs#39>

### Internal issues

- General, Build, Other
  - Remove unused/unneeded files (internal MR 1609)
- Spec
  - Clarify subaction path description for XrActiveActionSet (internal MR 1592,
    internal issues 1243 and 1244)
  - Resolve misleading use of `xrLocateViews` before `xrWaitFrame` in helloXR
    and spec (internal MR 1584, internal issue 1227, public issue
    <KhronosGroup/OpenXR-SDK-Source#134>)
- Registry
  - Add `XR_EXT_conformance_automation` extension, for use **only** by
    conformance testing (internal MR 1577, 1608)
@emersion emersion deleted the emersion:gles-wayland branch Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.